From: Richard Kimberly Heck <rikiheck@lyx.org>
Date: Mon, 4 Jan 2021 06:39:01 +0000 (-0500)
Subject: Simplify
X-Git-Url: https://git.lyx.org/gitweb/?a=commitdiff_plain;h=84e8ce4ce5004f2f5ec8d09ffec06b2d9dec3fea;hp=675072471730e52fe4f561b7a9e4f99da7f92483;p=features.git

Simplify
---

diff --git a/src/BufferView.cpp b/src/BufferView.cpp
index 681e38e2ca..3e807ffba4 100644
--- a/src/BufferView.cpp
+++ b/src/BufferView.cpp
@@ -796,23 +796,24 @@ void BufferView::bookmarkEditPosition()
 
 void BufferView::saveBookmark(unsigned int idx)
 {
+	if (buffer().isInternal())
+		return;
+
 	// tentatively save bookmark, id and pos will be used to
 	// acturately locate a bookmark in a 'live' lyx session.
 	// pit and pos will be updated with bottom level pit/pos
 	// when lyx exits.
-	if (!buffer_.isInternal()) {
-		theSession().bookmarks().save(
-			buffer_.fileName(),
-			d->cursor_.bottom().pit(),
-			d->cursor_.bottom().pos(),
-			d->cursor_.paragraph().id(),
-			d->cursor_.pos(),
-			idx
-			);
-		if (idx)
-			// emit message signal.
-			message(_("Save bookmark"));
-	}
+	theSession().bookmarks().save(
+		buffer_.fileName(),
+		d->cursor_.bottom().pit(),
+		d->cursor_.bottom().pos(),
+		d->cursor_.paragraph().id(),
+		d->cursor_.pos(),
+		idx
+	);
+	if (idx)
+		// emit message signal.
+		message(_("Save bookmark"));
 }