From: Jean-Marc Lasgouttes <lasgouttes@lyx.org>
Date: Tue, 16 Jul 2024 13:43:11 +0000 (+0200)
Subject: Fix faulty undo recording
X-Git-Url: https://git.lyx.org/gitweb/?a=commitdiff_plain;h=82f387dabc2b18de6a9917192f4304e92bff8bc1;p=lyx.git

Fix faulty undo recording

The recordUndo() call is very wrong, since we may be inserting over a
selection covering several paragraphs (undo itself works at paragraph
granularity).

recordUndoSelection() is the right operation in this case. It is
equivalent to recordUndo() when there is no selection.
---

diff --git a/src/Text.cpp b/src/Text.cpp
index 2a5ff9f0b8..d56cd10268 100644
--- a/src/Text.cpp
+++ b/src/Text.cpp
@@ -3600,7 +3600,7 @@ bool doInsertInset(Cursor & cur, Text * text,
 	if (InsetCollapsible * ci = inset->asInsetCollapsible())
 		ci->setButtonLabel();
 
-	cur.recordUndo();
+	cur.recordUndoSelection();
 	if (cmd.action() == LFUN_ARGUMENT_INSERT) {
 		bool cotextinsert = false;
 		InsetArgument * const ia = static_cast<InsetArgument *>(inset);