From: Juergen Spitzmueller <spitz@lyx.org>
Date: Sun, 10 Mar 2019 12:23:36 +0000 (+0100)
Subject: Do not percent-encode & in urls
X-Git-Tag: 2.3.3~11
X-Git-Url: https://git.lyx.org/gitweb/?a=commitdiff_plain;h=7d806ebbb66276a8f07304a6280c379e9fdbb10b;p=features.git

Do not percent-encode & in urls

This is query syntax

Fixes: #11511

follows up [c2db448ff5/lyxgit]

(cherry picked from commit 936cddc715d3a49ffbde42bba0cb19120701bc57)
---

diff --git a/src/insets/InsetHyperlink.cpp b/src/insets/InsetHyperlink.cpp
index 93dbaa94c5..07185a425e 100644
--- a/src/insets/InsetHyperlink.cpp
+++ b/src/insets/InsetHyperlink.cpp
@@ -133,8 +133,8 @@ void InsetHyperlink::latex(otexstream & os,
 	if (!url.empty()) {
 		// Use URI/URL-style percent-encoded string (hexadecimal).
 		// We exclude some characters that must not be transformed
-		// in hrefs (% # / : ? =) or that we need to treat manually (\).
-		url = to_percent_encoding(url, from_ascii("%#\\/:?="));
+		// in hrefs (% # / : ? = &) or that we need to treat manually (\).
+		url = to_percent_encoding(url, from_ascii("%#\\/:?=&"));
 		// We handle \ manually since \\ is valid
 		for (size_t i = 0, pos;
 			(pos = url.find('\\', i)) != string::npos;