From: Juergen Spitzmueller <spitz@lyx.org>
Date: Tue, 25 Sep 2018 11:13:56 +0000 (+0200)
Subject: Do not store empty posttext for qualified citations
X-Git-Tag: 2.3.2~59
X-Git-Url: https://git.lyx.org/gitweb/?a=commitdiff_plain;h=76c15f51ea82c978f877fc106be07c418bc93a58;p=features.git

Do not store empty posttext for qualified citations

Fixes: #11308
(cherry picked from commit 90b13452037dba56b16f8fb55cce36aebc226804)
---

diff --git a/src/frontends/qt4/GuiCitation.cpp b/src/frontends/qt4/GuiCitation.cpp
index 06dd4ed827..4e96b74555 100644
--- a/src/frontends/qt4/GuiCitation.cpp
+++ b/src/frontends/qt4/GuiCitation.cpp
@@ -738,7 +738,7 @@ vector<docstring> GuiCitation::getPostTexts()
 	for (int i = 0; i != selected_model_.rowCount(); ++i) {
 		QStandardItem const * key = selected_model_.item(i, 1);
 		QStandardItem const * post = selected_model_.item(i, 2);
-		if (key && post)
+		if (key && post && !key->text().isEmpty() && !post->text().isEmpty())
 			res.push_back(qstring_to_ucs4(key->text()) + " " + qstring_to_ucs4(post->text()));
 	}
 	return res;
diff --git a/status.23x b/status.23x
index 39cbc4cf4d..979bdb8300 100644
--- a/status.23x
+++ b/status.23x
@@ -124,6 +124,8 @@ What's new
 
 - Fix crash on Windows when closing external viewers (bug 11210).
 
+- Fix issue with erroneous qualified citations (bug 11308).
+
 
 
 * USER INTERFACE