From: Juergen Spitzmueller <spitz@lyx.org>
Date: Tue, 9 Jul 2019 08:47:18 +0000 (+0200)
Subject: Preserve star on citation style change via menu
X-Git-Tag: 2.3.4~87
X-Git-Url: https://git.lyx.org/gitweb/?a=commitdiff_plain;h=6afe2584536dd74c5d9a3108c63bab587ab5460e;p=features.git

Preserve star on citation style change via menu

Fixes: #11439
(cherry picked from commit 52fffee7f2a96025a872b5c3a8c4dc26eae04822)
---

diff --git a/src/frontends/qt4/Menus.cpp b/src/frontends/qt4/Menus.cpp
index 3773fd9d7a..5eafff6f74 100644
--- a/src/frontends/qt4/Menus.cpp
+++ b/src/frontends/qt4/Menus.cpp
@@ -1572,9 +1572,8 @@ void MenuDefinition::expandCiteStyles(BufferView const * bv)
 		return;
 	}
 
-	size_t const n = cmd.size();
 	bool const force = isUpperCase(cmd[0]);
-	bool const star = cmd[n] == '*';
+	bool const star = suffixIs(cmd, '*');
 
 	vector<docstring> const keys = getVectorFromString(key);
 
diff --git a/status.23x b/status.23x
index 140e9b2c86..e3c5522443 100644
--- a/status.23x
+++ b/status.23x
@@ -87,6 +87,9 @@ What's new
 - Fix additional problem with display of inline equations in outliner
   (bug 11423).
 
+- Preserve "all authors" state when switching citation style via context
+  menu (bug 11439).
+
 
 * INTERNALS