From: Juergen Spitzmueller <spitz@lyx.org>
Date: Sun, 1 Jan 2017 07:37:56 +0000 (+0100)
Subject: Make biblio_style private
X-Git-Tag: 2.3.0alpha1~536
X-Git-Url: https://git.lyx.org/gitweb/?a=commitdiff_plain;h=5d58bfadbc2a210e10f3620a6519466319069d54;p=features.git

Make biblio_style private

This should never ever be accessed directly
---

diff --git a/src/BufferParams.h b/src/BufferParams.h
index 13870f1d8c..29897fd975 100644
--- a/src/BufferParams.h
+++ b/src/BufferParams.h
@@ -462,9 +462,9 @@ public:
 	/// the available citation styles
 	std::vector<CitationStyle> citeStyles() const;
 
-	/// the default BibTeX style file for the document
-	std::string biblio_style;
-	/// the default BibTeX style file from the TextClass
+	/// Set the default BibTeX style file for the document
+	void setDefaultBiblioStyle(std::string const & s){ biblio_style = s; }
+	/// Get the default BibTeX style file from the TextClass
 	std::string const & defaultBiblioStyle() const;
 	/// whether the BibTeX style supports full author lists
 	bool const & fullAuthorList() const;
@@ -535,6 +535,8 @@ private:
 	LayoutModuleList cite_engine_;
 	/// the type of cite engine (authoryear or numerical)
 	CiteEngineType cite_engine_type_;
+	/// the default BibTeX style file for the document
+	std::string biblio_style;
 	///
 	DocumentClassPtr doc_class_;
 	///
diff --git a/src/frontends/qt4/GuiDocument.cpp b/src/frontends/qt4/GuiDocument.cpp
index 34b2fc0b91..077bc55fec 100644
--- a/src/frontends/qt4/GuiDocument.cpp
+++ b/src/frontends/qt4/GuiDocument.cpp
@@ -2642,7 +2642,7 @@ void GuiDocument::applyView()
 	bp_.use_bibtopic =
 		biblioModule->bibtopicCB->isChecked();
 
-	bp_.biblio_style = fromqstr(biblioModule->defaultBiblioCO->currentText());
+	bp_.setDefaultBiblioStyle(fromqstr(biblioModule->defaultBiblioCO->currentText()));
 
 	string const bibtex_command =
 		fromqstr(biblioModule->bibtexCO->itemData(