From: Stephan Witt <switt@lyx.org>
Date: Thu, 13 Feb 2020 14:24:12 +0000 (+0100)
Subject: Avoid potential leak of memory pointed to by QStandardItem catItem
X-Git-Url: https://git.lyx.org/gitweb/?a=commitdiff_plain;h=5d043fd108c9b4430fc46b3bdc087ed11877cce4;p=features.git

Avoid potential leak of memory pointed to by QStandardItem catItem
---

diff --git a/src/frontends/qt/GuiDocument.cpp b/src/frontends/qt/GuiDocument.cpp
index ac4b1f1bf1..8778790fb9 100644
--- a/src/frontends/qt/GuiDocument.cpp
+++ b/src/frontends/qt/GuiDocument.cpp
@@ -4467,12 +4467,13 @@ void GuiDocument::updateAvailableModules()
 	unavbrush.setColor(Qt::gray);
 	for (modInfoStruct const & m : modInfoList) {
 		QStandardItem * item = new QStandardItem();
-		QStandardItem * catItem = new QStandardItem();
+		QStandardItem * catItem;
 		QString const catname = m.category;
 		QList<QStandardItem *> fcats = modules_av_model_.findItems(catname, Qt::MatchExactly);
 		if (!fcats.empty())
 			catItem = fcats.first();
 		else {
+			catItem = new QStandardItem();
 			catItem->setText(catname);
 			catItem->setFont(catfont);
 			modules_av_model_.insertRow(i, catItem);