From: Pavel Sanda <sanda@lyx.org>
Date: Sat, 2 Mar 2024 23:26:26 +0000 (+0100)
Subject: * generate_contributions.py - another php 8 choking points
X-Git-Url: https://git.lyx.org/gitweb/?a=commitdiff_plain;h=56ab845ca5f02092b980a001b02aac74ce7bd745;p=features.git

* generate_contributions.py - another php 8 choking points
---

diff --git a/lib/generate_contributions.py b/lib/generate_contributions.py
index 542d90d719..bb0627fe58 100755
--- a/lib/generate_contributions.py
+++ b/lib/generate_contributions.py
@@ -227,10 +227,12 @@ function blanket_contrib($name, $email, $msg_title, $msg_ref, $date) {
 $email = str_replace(' () ', '@', $email);
 $email = str_replace(' ! ', '.', $email);
 
+if(!isset($output)){ $output = ''; }
+
 $output=$output. "
 
  <dt>
-  <b>[[mailto:${email} | ${name}]]</b>
+  <b>[[mailto:{$email} | {$name}]]</b>
  </dt>
  <dd>
   See the lyx-devel mailing list message
@@ -239,12 +241,12 @@ $output=$output. "
 if (isset($msg_ref) && $msg_ref != "") {
         $msg_ref = htmlspecialchars("$msg_ref");
         if (substr($msg_ref, 0, 2) == "m=") {
-                $output=$output. "[[https://marc.info/?l=lyx-devel&amp;" . ${msg_ref} . "|" . ${msg_title} . "]]";
+                $output=$output. "[[https://marc.info/?l=lyx-devel&amp;" . $msg_ref . "|" . $msg_title . "]]";
         } else {
-                $output=$output. "[[https://www.mail-archive.com/lyx-devel@lists.lyx.org/" . ${msg_ref} . ".html |" . ${msg_title} . "]]";
+                $output=$output. "[[https://www.mail-archive.com/lyx-devel@lists.lyx.org/" . $msg_ref . ".html |" . $msg_title . "]]";
         }
 } else {
-        $output=$output. "${msg_title}";
+        $output=$output. "{$msg_title}";
 }
 
 $output=$output. "&quot;
@@ -256,6 +258,8 @@ return $output;
 
 function blanket_output() {
 
+if(!isset($output)){ $output = ''; }
+
 $output=$output."<p>
      The following people hereby grant permission to license their
      contributions to LyX under the