From: Thibaut Cuvelier <tcuvelier@lyx.org>
Date: Thu, 22 Dec 2022 03:10:25 +0000 (+0100)
Subject: XML: improve formatting of error message for unrecognised tag type.
X-Git-Url: https://git.lyx.org/gitweb/?a=commitdiff_plain;h=4f314567b6a8d87d472c3388523a3e093560b652;p=features.git

XML: improve formatting of error message for unrecognised tag type.

Before, there was always a space after the tag, even when there were no attributes. Now, the space is output conditionally, so that the output makes more sense.

Before, one space too many for the tag name (title), casting doubt on whether the code had this space hard coded or not:

<!-- Output Error: Unrecognised tag type 'para' for 'title ' -->

After, no such space:

<!-- Output Error: Unrecognised tag type 'para' for 'title' -->
---

diff --git a/src/xml.cpp b/src/xml.cpp
index 7ee8d9137a..f466f61283 100644
--- a/src/xml.cpp
+++ b/src/xml.cpp
@@ -812,7 +812,8 @@ void xml::openTag(XMLStream & xs, const docstring & tag, const docstring & attr,
 	else if (tagtype == "none")
 		xs << xml::StartTag(tag, attr);
 	else
-		xs.writeError("Unrecognised tag type '" + tagtype + "' for '" + to_utf8(tag) + " " + to_utf8(attr) + "'");
+		xs.writeError("Unrecognised tag type '" + tagtype + "' for '" + to_utf8(tag) + (attr.empty() ? "" : " ") +
+				to_utf8(attr) + "'");
 }