From: Jean-Marc Lasgouttes <lasgouttes@lyx.org>
Date: Mon, 9 Sep 2024 13:29:39 +0000 (+0200)
Subject: Initialize client's name in main()
X-Git-Url: https://git.lyx.org/gitweb/?a=commitdiff_plain;h=3d323412ad5b4d47774de43f985202f20cabd156;p=lyx.git

Initialize client's name in main()

Initializing clientName at declaration time is not a good idea.

Spotted by Coverity scan.
---

diff --git a/src/client/client.cpp b/src/client/client.cpp
index 0a80107009..02ea67c008 100644
--- a/src/client/client.cpp
+++ b/src/client/client.cpp
@@ -460,8 +460,7 @@ int h(vector<docstring> const &)
 }
 
 
-docstring clientName =
-	from_ascii(to_string(::getppid()) + ">" + to_string(::getpid()));
+docstring clientName;
 
 int n(vector<docstring> const & arg)
 {
@@ -710,9 +709,12 @@ int LyXClientApp::run()
 
 int main(int argc, char * argv[])
 {
-	lyx::lyxerr.setStream(cerr);
+	using namespace lyx;
+	lyxerr.setStream(cerr);
+	cmdline::clientName =
+		from_ascii(to_string(::getppid()) + ">" + to_string(::getpid()));
 
-	lyx::LyXClientApp app(argc, argv);
+	LyXClientApp app(argc, argv);
 	return app.exec();
 }