From: Abdelrazak Younes <younes@lyx.org>
Date: Mon, 16 Oct 2006 09:08:05 +0000 (+0000)
Subject: Adjust the FIXME texts and Delete commented out setXY() call following Andre comments... 
X-Git-Tag: 1.6.10~12372
X-Git-Url: https://git.lyx.org/gitweb/?a=commitdiff_plain;h=3a32fff90ea676e86b20666c1e4c6f7c2d6b892a;p=features.git

Adjust the FIXME texts and Delete commented out setXY() call following Andre comments about it:

The coordcahce is for up/down navigation and vconverting mouseclicks to text positions. It is not for pure display/export which
is what drawT is about. It was a simple oversight not to remove it after some copying from the 'real' draw() method.



git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@15347 a592a061-630c-0410-9148-cb99ea01b6c8
---

diff --git a/src/mathed/MathData.C b/src/mathed/MathData.C
index f124a5d043..6b94f12ec0 100644
--- a/src/mathed/MathData.C
+++ b/src/mathed/MathData.C
@@ -333,21 +333,8 @@ void MathArray::drawT(TextPainter & pain, int x, int y) const
 {
 	//lyxerr << "x: " << x << " y: " << y << ' ' << pain.workAreaHeight() << endl;
 
-	// FIXME: Abdel 13/10/2006
-	// The setXV() call below is commented out for now because
-	// we don't have access to a BufferView at this level.
-	// In any case, this drawT() method is never used, this is dead code.
-	//
-	/* Georg explanation of current situation:
-	AFAIK the text painter was used to export math formulas as ASCII art.
-	Therefore the setXY() call makes sense. Imagine that the text painter is
-	like a real painter, but operating on a very coarse grid of character cells
-	where each cell can be filled with an ASCII character.
-	I don't know why it is currently disabled. I do know that we have a bugzilla
-	request for reenabling it. I believe only Andre can tell whether that is
-	doable or whether the whole drawT machinery should be removed.	
-	*/
-	//setXY(bv, x, y);
+	// FIXME: Abdel 16/10/2006
+	// This drawT() method is never used, this is dead code.
 
 	for (const_iterator it = begin(), et = end(); it != et; ++it) {
 		(*it)->drawT(pain, x, y);
diff --git a/src/mathed/TextPainter.h b/src/mathed/TextPainter.h
index 6f02fd57e0..261500d550 100644
--- a/src/mathed/TextPainter.h
+++ b/src/mathed/TextPainter.h
@@ -17,6 +17,16 @@
 
 #include <vector>
 
+// FIXME: Abdel 16/10/2006
+// This TextPainter class is never used, this is dead code.
+/* Georg explanation of current situation:
+AFAIK the text painter was used to export math formulas as ASCII art.
+The text painter is	like a real painter, but operating on a very coarse
+grid of character cells	where each cell can be filled with an ASCII character.
+I don't know why it is currently disabled. I do know that we have a bugzilla
+request for reenabling it.
+*/
+
 class TextPainter {
 	public:
 		///