From: Vincent van Ravesteijn <vfr@lyx.org>
Date: Mon, 3 May 2010 23:01:47 +0000 (+0000)
Subject: Fix another crash due to BufferView::last_inset_ being an invalid pointer.
X-Git-Tag: 2.0.0~3296
X-Git-Url: https://git.lyx.org/gitweb/?a=commitdiff_plain;h=351808718d3e8bb97487c0d98d0a416d2f265bf0;p=features.git

Fix another crash due to BufferView::last_inset_ being an invalid pointer.

Do not clear the mouse_hover state from anywhere else then BufferView, such that the last_inset_ pointer gets nulled. Besides, there is no reason to clear the mouse_hover state on collapsing the Inset.

See also r33908, r34117, r34348, r34353, r34354 and bug #3900.

git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@34364 a592a061-630c-0410-9148-cb99ea01b6c8
---

diff --git a/src/insets/InsetCollapsable.cpp b/src/insets/InsetCollapsable.cpp
index 74c53ef61b..78de68a9c9 100644
--- a/src/insets/InsetCollapsable.cpp
+++ b/src/insets/InsetCollapsable.cpp
@@ -591,10 +591,8 @@ void InsetCollapsable::setStatus(Cursor & cur, CollapseStatus status)
 {
 	status_ = status;
 	setButtonLabel();
-	if (status_ == Collapsed) {
+	if (status_ == Collapsed)
 		cur.leaveInset(*this);
-		mouse_hover_.clear();
-	}
 }