From: Juergen Spitzmueller <spitz@lyx.org>
Date: Sun, 1 Oct 2023 10:20:40 +0000 (+0200)
Subject: Revert the logic of 343a9749abe4f3
X-Git-Url: https://git.lyx.org/gitweb/?a=commitdiff_plain;h=2b69dc54daad7ba50c505e77203e99fe4d7d153c;p=features.git

Revert the logic of 343a9749abe4f3

It might be better to be explicit also with black, after all.
---

diff --git a/src/insets/InsetBox.cpp b/src/insets/InsetBox.cpp
index 1643a0df52..edfa6a569c 100644
--- a/src/insets/InsetBox.cpp
+++ b/src/insets/InsetBox.cpp
@@ -899,10 +899,9 @@ string const InsetBox::getBackgroundColor() const
 
 bool InsetBox::useFColorBox() const
 {
-	// we only need an \fcolorbox if the framecolor is something else
-	// than black in the output or if the backgroundcolor is not none
-	// (also needed with white, consider non-white page coloring)
-	return getFrameColor() != "black" || params_.backgroundcolor != "none";
+	// we need an \fcolorbox if the framecolor or the backgroundcolor
+	// is non-default. We also do it with black and white for consistency.
+	return params_.framecolor != "default" || params_.backgroundcolor != "none";
 }