From: Richard Kimberly Heck <rikiheck@lyx.org>
Date: Fri, 13 Sep 2019 15:49:29 +0000 (-0400)
Subject: Use const &
X-Git-Url: https://git.lyx.org/gitweb/?a=commitdiff_plain;h=269d054c4e9a7bf71a737c35231710bf039b16b0;p=features.git

Use const &
---

diff --git a/src/BiblioInfo.cpp b/src/BiblioInfo.cpp
index 746780ac6b..e7ca878a2b 100644
--- a/src/BiblioInfo.cpp
+++ b/src/BiblioInfo.cpp
@@ -776,7 +776,7 @@ I can tell, but it still feels like a hack. Fixing this would require quite a
 bit of work, however.
 */
 docstring BibTeXInfo::expandFormat(docstring const & format,
-		BibTeXInfoList const xrefs, int & counter, Buffer const & buf,
+		BibTeXInfoList const & xrefs, int & counter, Buffer const & buf,
 		CiteItem const & ci, bool next, bool second) const
 {
 	// incorrect use of macros could put us in an infinite loop
@@ -926,7 +926,7 @@ docstring BibTeXInfo::expandFormat(docstring const & format,
 }
 
 
-docstring const & BibTeXInfo::getInfo(BibTeXInfoList const xrefs,
+docstring const & BibTeXInfo::getInfo(BibTeXInfoList const & xrefs,
 	Buffer const & buf, CiteItem const & ci) const
 {
 	bool const richtext = ci.richtext;
@@ -1000,7 +1000,7 @@ docstring const & BibTeXInfo::operator[](string const & field) const
 
 
 docstring BibTeXInfo::getValueForKey(string const & oldkey, Buffer const & buf,
-	CiteItem const & ci, BibTeXInfoList const xrefs, size_t maxsize) const
+	CiteItem const & ci, BibTeXInfoList const & xrefs, size_t maxsize) const
 {
 	// anything less is pointless
 	LASSERT(maxsize >= 16, maxsize = 16);
diff --git a/src/BiblioInfo.h b/src/BiblioInfo.h
index 5709be47c5..8a36183d03 100644
--- a/src/BiblioInfo.h
+++ b/src/BiblioInfo.h
@@ -69,7 +69,7 @@ public:
 	docstring const getYear() const;
 	/// \return formatted BibTeX data suitable for framing.
 	/// \param vector of pointers to crossref/xdata information
-	docstring const & getInfo(BibTeXInfoList const xrefs,
+	docstring const & getInfo(BibTeXInfoList const & xrefs,
 			Buffer const & buf, CiteItem const & ci) const;
 	/// \return formatted BibTeX data for a citation label
 	docstring const getLabel(BibTeXInfoList const xrefs,
@@ -123,7 +123,7 @@ private:
 	/// to get the data from xref BibTeXInfo objects, which would normally
 	/// be the one referenced in the crossref or xdata field.
 	docstring getValueForKey(std::string const & key, Buffer const & buf,
-		CiteItem const & ci, BibTeXInfoList const xrefs, size_t maxsize = 4096) const;
+		CiteItem const & ci, BibTeXInfoList const & xrefs, size_t maxsize = 4096) const;
 	/// replace %keys% in a format string with their values
 	/// called from getInfo()
 	/// format strings may contain:
@@ -141,7 +141,7 @@ private:
 	/// moreover, keys that look like "%_key%" are treated as translatable
 	/// so that things like "pp." and "vol." can be translated.
 	docstring expandFormat(docstring const & fmt,
-		BibTeXInfoList const xrefs, int & counter,
+		BibTeXInfoList const & xrefs, int & counter,
 		Buffer const & buf, CiteItem const & ci,
 		bool next = false, bool second = false) const;
 	/// true if from BibTeX; false if from bibliography environment