From: Jean-Marc Lasgouttes <lasgouttes@lyx.org>
Date: Tue, 7 Mar 2017 10:56:59 +0000 (+0100)
Subject: Fix test to make coverity happy
X-Git-Tag: 2.3.0alpha1~269
X-Git-Url: https://git.lyx.org/gitweb/?a=commitdiff_plain;h=25d64bf43aba78a1ed20c88dfdc4cac269b53985;p=features.git

Fix test to make coverity happy

It is not obvious that cur is not null iff thisSlice is not -1, but
this is what happens in the caller.
---

diff --git a/src/mathed/MathData.cpp b/src/mathed/MathData.cpp
index 3f298afad1..9d218987d3 100644
--- a/src/mathed/MathData.cpp
+++ b/src/mathed/MathData.cpp
@@ -781,7 +781,10 @@ void MathData::collectParameters(Cursor * cur,
 		// fix cursor
 		vector<CursorSlice> argSlices;
 		int argPos = 0;
-		if (thisSlice != -1 && thisPos == int(pos))
+		// Note: The two expressions on the first line are equivalent
+		// (see caller), but making this explicit pleases coverity.
+		if (cur && thisSlice != -1
+			&& thisPos == int(pos))
 			cur->cutOff(thisSlice, argSlices);
 
 		// which kind of parameter is it? In {}? With index x^n?