From: Scott Kostyshak <skostysh@lyx.org>
Date: Fri, 6 Mar 2020 14:18:59 +0000 (-0500)
Subject: Fix Qt deprecation warn for setConfirmOverwrite()
X-Git-Url: https://git.lyx.org/gitweb/?a=commitdiff_plain;h=2360a935ff8c3669b600ebf5bb816e5dab977094;p=features.git

Fix Qt deprecation warn for setConfirmOverwrite()

Fix the following warning:

  error: ‘void QFileDialog::setConfirmOverwrite(bool)’ is deprecated: Use setOption(DontConfirmOverwrite, !enabled) instead [-Werror=deprecated-declarations]

Note in the change that "false" changes to "true" because the option
is *Dont*ConfirmOverwrite.

QFileDialog::setConfirmOverwrite() is obsolete at least since 4.8
and QFileDialog::setOption() is available since 4.5 [1].

[1] https://doc.qt.io/archives/qt-4.8/qfiledialog-obsolete.html
[2] https://doc.qt.io/qt-5/qfiledialog.html#setOption
---

diff --git a/src/frontends/qt/FileDialog.cpp b/src/frontends/qt/FileDialog.cpp
index f4bc5fd385..fb05f43e55 100644
--- a/src/frontends/qt/FileDialog.cpp
+++ b/src/frontends/qt/FileDialog.cpp
@@ -102,7 +102,7 @@ FileDialog::Result FileDialog::save(QString const & path,
 		LyXFileDialog dlg(title_, path, filters, private_->b1, private_->b2);
 		dlg.setFileMode(QFileDialog::AnyFile);
 		dlg.setAcceptMode(QFileDialog::AcceptSave);
-		dlg.setConfirmOverwrite(false);
+		dlg.setOption(QFileDialog::DontConfirmOverwrite, true);
 		if (selectedFilter != 0 && !selectedFilter->isEmpty())
 			dlg.selectNameFilter(*selectedFilter);