From: Jean-Marc Lasgouttes <lasgouttes@lyx.org>
Date: Mon, 14 Jun 2021 13:36:45 +0000 (+0200)
Subject: Allow line inset to draw a vertical line.
X-Git-Tag: 2.4-beta2~1227
X-Git-Url: https://git.lyx.org/gitweb/?a=commitdiff_plain;h=22cb573cacb9a148458d401deff725971def8b45;p=lyx.git

Allow line inset to draw a vertical line.

Qpainter::drawline cannot draw a line which is thicker than it is long.
Draw a rectangle instead.

Fix bug #12307.
---

diff --git a/src/insets/InsetLine.cpp b/src/insets/InsetLine.cpp
index cb0a074738..70469be37a 100644
--- a/src/insets/InsetLine.cpp
+++ b/src/insets/InsetLine.cpp
@@ -140,16 +140,10 @@ void InsetLine::draw(PainterInfo & pi, int x, int y) const
 	Dimension const dim = dimension(*pi.base.bv);
 
 	// get the surrounding text color
-	Color Line_color = pi.base.font.realColor();
+	Color line_color = pi.base.font.realColor();
 
 	// the offset is a vertical one
-	// the horizontal dimension must be corrected with the height because
-	// of left and right border of the painted line for big height.
-	pi.pain.line(x + height_/2 + 1,
-		     y - offset_ - height_/2,
-		     x + dim.wid - height_/2 - 2,
-		     y - offset_ - height_/2,
-		     Line_color, Painter::line_solid, height_);
+	pi.pain.fillRectangle(x, y - offset_ - height_, dim.wid, height_, line_color);
 }