From: Jean-Marc Lasgouttes <lasgouttes@lyx.org>
Date: Wed, 20 Mar 2019 16:25:25 +0000 (+0100)
Subject: Initialize hasTitle in Intervall constructor
X-Git-Tag: lyx-2.4.0dev-acb2ca7b~2427
X-Git-Url: https://git.lyx.org/gitweb/?a=commitdiff_plain;h=1c755fefa50886cf760d0b03b983e49896b16af5;p=features.git

Initialize hasTitle in Intervall constructor

I also moved around some things while I was at it.

Spotted by coverity scan.
---

diff --git a/src/lyxfind.cpp b/src/lyxfind.cpp
index b347448828..d5b750dbf8 100644
--- a/src/lyxfind.cpp
+++ b/src/lyxfind.cpp
@@ -1114,11 +1114,15 @@ static vector<Border> borders = vector<Border>(30);
 #define MAXOPENED 30
 class Intervall {
   bool isPatternString;
- public:
- explicit Intervall(bool isPattern) :
-  isPatternString(isPattern),
-    ignoreidx(-1),
-    actualdeptindex(0) { depts[0] = 0; closes[0] = 0;};
+public:
+  explicit Intervall(bool isPattern, string const & p) :
+  	isPatternString(isPattern), par(p), ignoreidx(-1), actualdeptindex(0),
+  	hasTitle(false)
+  {
+    depts[0] = 0;
+    closes[0] = 0;
+  }
+
   string par;
   int ignoreidx;
   int depts[MAXOPENED];
@@ -1463,10 +1467,8 @@ class LatexInfo {
   void removeHead(KeyInfo&, int count=0);
 
  public:
- LatexInfo(string par, bool isPatternString) : entidx(-1), interval(isPatternString) {
-    interval.par = par;
-    interval.hasTitle = false;
-    interval.titleValue = "";
+ LatexInfo(string par, bool isPatternString) : entidx(-1), interval(isPatternString, par)
+  {
     buildKeys(isPatternString);
     entries = vector<KeyInfo>();
     buildEntries(isPatternString);