From: Julien Rioux <jrioux@lyx.org>
Date: Tue, 11 Oct 2011 18:33:35 +0000 (+0000)
Subject: Allow \nocite again with the basic citation engine (backport r39777).
X-Git-Tag: 2.0.2~160
X-Git-Url: https://git.lyx.org/gitweb/?a=commitdiff_plain;h=1c56ffc10f8202d56fedb366346c58de103828eb;p=features.git

Allow \nocite again with the basic citation engine (backport r39777).

Fix a bug introduced in r26547. Also reorders the entries for
natbib-numerical into a more natural, visually pleasing order.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/branches/BRANCH_2_0_X@39830 a592a061-630c-0410-9148-cb99ea01b6c8
---

diff --git a/src/BiblioInfo.cpp b/src/BiblioInfo.cpp
index c031058aa3..0df795e506 100644
--- a/src/BiblioInfo.cpp
+++ b/src/BiblioInfo.cpp
@@ -1033,30 +1033,35 @@ string citationStyleToString(const CitationStyle & s)
 
 vector<CiteStyle> citeStyles(CiteEngine engine)
 {
-	unsigned int nStyles = 0;
-	unsigned int start = 0;
+	vector<CiteStyle> styles(0);
 
 	switch (engine) {
 		case ENGINE_BASIC:
-			nStyles = 2;
-			start = 0;
+			styles.push_back(CITE);
 			break;
+		case ENGINE_JURABIB:
+			styles.push_back(CITE);
 		case ENGINE_NATBIB_AUTHORYEAR:
-		case ENGINE_NATBIB_NUMERICAL:
-			nStyles = nCiteStyles - 1;
-			start = 1;
+			styles.push_back(CITET);
+			styles.push_back(CITEP);
+			styles.push_back(CITEALT);
+			styles.push_back(CITEALP);
+			styles.push_back(CITEAUTHOR);
+			styles.push_back(CITEYEAR);
+			styles.push_back(CITEYEARPAR);
 			break;
-		case ENGINE_JURABIB:
-			nStyles = nCiteStyles;
-			start = 0;
+		case ENGINE_NATBIB_NUMERICAL:
+			styles.push_back(CITET);
+			styles.push_back(CITEALT);
+			styles.push_back(CITEAUTHOR);
+			styles.push_back(CITEP);
+			styles.push_back(CITEALP);
+			styles.push_back(CITEYEAR);
+			styles.push_back(CITEYEARPAR);
 			break;
 	}
 
-	vector<CiteStyle> styles(nStyles);
-	size_t i = 0;
-	int j = start;
-	for (; i != styles.size(); ++i, ++j)
-		styles[i] = citeStylesArray[j];
+	styles.push_back(NOCITE);
 
 	return styles;
 }
diff --git a/status.20x b/status.20x
index c044fab428..dd1f573b29 100644
--- a/status.20x
+++ b/status.20x
@@ -146,6 +146,8 @@ What's new
 - Don't allow copy-pasting newline characters in Document->Settings
   and Tools->Preferences (bug 5840).
 
+- Allow the \nocite LaTeX command when using the basic citation engine.
+
 
 * ADVANCED FIND AND REPLACE