From: Kornel Benko <kornel@lyx.org>
Date: Sat, 24 Oct 2020 12:05:19 +0000 (+0200)
Subject: Checking po-files (shortcut handling)
X-Git-Tag: lyx-2.4.0dev-acb2ca7b~6
X-Git-Url: https://git.lyx.org/gitweb/?a=commitdiff_plain;h=12557b094ce1a6376cf77003a443592af235f2a7;hp=8af747c9d9f4d5f496313256e044e8a5b99147f4;p=features.git

Checking po-files (shortcut handling)

1.) Allow ' ' as a menu shortcut (corrected for missing/unexpected spaces at message end)
2.) Adapt for utf-8 shortcuts (corrected chacking for missing/unexpected shortcuts)
---

diff --git a/po/pocheck.pl b/po/pocheck.pl
index 391245a11e..db59aa0b77 100755
--- a/po/pocheck.pl
+++ b/po/pocheck.pl
@@ -168,8 +168,11 @@ foreach my $pofilename ( @ARGV ) {
     }
 
     if ($check_spaces) {
-      # Check space at the end of a message
-      if ( ( $msgid =~ m/  *?(\|.*)?$/ ) != ( $msgstr =~ m/  *?(\|.*)?$/ ) ) {
+      # Check space at the end of a message (if not a shortcut)
+      my ($msgid1, $msgstr1);
+      ($msgid1 = $msgid) =~ s/\|.$//;
+      ($msgstr1 = $msgstr) =~ s/\|.$//;	# TODO: Shortcut may be utf-8 char
+      if (($msgid1 =~ / $/) != ($msgstr1 =~ / $/)) {
         print "Line $linenum: Missing or unexpected space:\n  '$msgid' => '$msgstr'\n"
           unless $only_total;
         ++$bad{"Bad spaces"};
@@ -188,8 +191,16 @@ foreach my $pofilename ( @ARGV ) {
     }
 
     if ($check_menu) {
-      # Check for "|..." shortcuts
-      if ( ( $msgid =~ m/\|[^ ]/ ) != ( $msgstr =~ m/\|[^ ]/ ) ) {
+      # Check for "|..." shortcuts (space shortcut allowed)
+      # Shortcut is either 1 char (ascii in msgid) or utf8 char (in msgstr)
+      my ($s1, $s2) = (0,0);
+      $s1 = 1 if ($msgid =~ /\|([^\|])$/);
+      if ($msgstr =~ /\|([^\|]+)$/) {
+	my $chars = $1;
+	my $u = decode('utf-8', $chars);
+	$s2 = 1 if (length($u) == 1);
+      }
+      if($s1 != $s2) {
         print "Line $linenum: Missing or unexpected menu shortcut:\n  '$msgid' => '$msgstr'\n"
           unless $only_total;
         ++$bad{"Bad menu shortcuts"};