From: Richard Heck <rgheck@lyx.org>
Date: Sun, 10 Jul 2016 05:43:19 +0000 (-0400)
Subject: Simplify logic a bit. (This was meant to be part of a previous
X-Git-Tag: 2.2.1~50
X-Git-Url: https://git.lyx.org/gitweb/?a=commitdiff_plain;h=103bf05099652510ea0eaa5e45256acd32cba476;p=features.git

Simplify logic a bit. (This was meant to be part of a previous
commit.)

(cherry picked from commit 2104d41f71ff39f5c3f9f5a485707633b1bfb25b)
---

diff --git a/src/Buffer.cpp b/src/Buffer.cpp
index 22c993ca8b..c20ce12b03 100644
--- a/src/Buffer.cpp
+++ b/src/Buffer.cpp
@@ -4318,12 +4318,11 @@ Buffer::ExportStatus Buffer::preview(string const & format, bool includeall) con
 
 	if (status != ExportSuccess)
 		return status;
-	if (previewFile.exists()) {
-		if (!formats.view(*this, previewFile, format))
-			return PreviewError;
-		else
-			return PreviewSuccess;
-	} 
+
+	if (previewFile.exists())
+		return formats.view(*this, previewFile, format) ?
+			PreviewSuccess : PreviewError;
+
 	// Successful export but no output file?
 	// Probably a bug in error detection.
 	LATTEST(status != ExportSuccess);