From: Jean-Marc Lasgouttes <jean-marc.lasgouttes@inria.fr>
Date: Tue, 11 Jul 2017 13:28:06 +0000 (+0200)
Subject: When cleaning up before quitting, take care of exceptions
X-Git-Tag: 2.3.0beta1~189
X-Git-Url: https://git.lyx.org/gitweb/?a=commitdiff_plain;h=0d565f7b350b4dfecfa9337b4b80173282d191ab;p=features.git

When cleaning up before quitting, take care of exceptions

We do not want the cleanup work to be interrupted by a buffer exception.

Spotted by coverity. See bug #9979 for discussion.
---

diff --git a/src/LyX.cpp b/src/LyX.cpp
index bb88f82dbb..0a0a31959b 100644
--- a/src/LyX.cpp
+++ b/src/LyX.cpp
@@ -419,8 +419,12 @@ void LyX::prepareExit()
 	// Write the index file of the converter cache
 	ConverterCache::get().writeIndex();
 
-	// close buffers first
-	pimpl_->buffer_list_.closeAll();
+	// closing buffer may throw exceptions, but we ignore them since we
+	// are quitting.
+	try {
+		// close buffers first
+		pimpl_->buffer_list_.closeAll();
+	} catch (ExceptionMessage const &) {}
 
 	// register session changes and shutdown server and socket
 	if (use_gui) {