From: Pavel Sanda <sanda@lyx.org>
Date: Sat, 2 Mar 2024 23:07:08 +0000 (+0100)
Subject: * generate_contributions.py - php 8 chokes on those
X-Git-Url: https://git.lyx.org/gitweb/?a=commitdiff_plain;h=0bd6fe0fc4fd9bf48bc6bc2a4a84366a80cba88a;p=features.git

* generate_contributions.py - php 8 chokes on those

@anyone: please do not commit changes generated by generate_contributions.py
until we switch to the new web server. Not sure what will this output do
with older php.
---

diff --git a/lib/generate_contributions.py b/lib/generate_contributions.py
index 36316db33d..542d90d719 100755
--- a/lib/generate_contributions.py
+++ b/lib/generate_contributions.py
@@ -162,20 +162,22 @@ function credits_contrib($name, $email, $msg) {
 $email = str_replace(' () ', '@', $email);
 $email = str_replace(' ! ', '.', $email);
 
+if(!isset($output)){ $output = ''; }
+
 if (isset($email) && $email != "") {
         if (strncasecmp($email,"https",4) == 0)
-            $output =$output. "<dt><b>[[${email} | ${name}]]</b>";
+            $output =$output. "<dt><b>[[{$email} | {$name}]]</b>";
          else
-            $output=$output. "<dt><b>[[mailto:${email} | ${name}]]</b>";
+            $output=$output. "<dt><b>[[mailto:{$email} | {$name}]]</b>";
 } else
-        $output=$output. "<dt><b>${name}</b>";
+        $output=$output. "<dt><b>{$name}</b>";
 
 $msg = preg_replace("/\\n */", "\\n  ", ltrim($msg));
 
 $output=$output. "
  </dt>
  <dd>
-  ${msg}
+  {$msg}
  </dd>";
  
 return $output;
@@ -183,6 +185,8 @@ return $output;
 
 function credits_output() {
 
+if(!isset($output)){ $output = ''; }
+
 $output=$output."<p>
      If your name doesn't appear here although you've done
      something for LyX, or your entry is wrong or incomplete,