From: Jean-Marc Lasgouttes <lasgouttes@lyx.org>
Date: Tue, 11 Jan 2005 13:22:42 +0000 (+0000)
Subject: enable Goto error (bug 1760)
X-Git-Tag: 1.6.10~14670
X-Git-Url: https://git.lyx.org/gitweb/?a=commitdiff_plain;h=06788449ec3cb63b33f8cde0b9004de2aa2aba33;p=features.git

enable Goto error (bug 1760)


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@9464 a592a061-630c-0410-9148-cb99ea01b6c8
---

diff --git a/src/frontends/controllers/ChangeLog b/src/frontends/controllers/ChangeLog
index f0eec8a4da..5cb1b8f71a 100644
--- a/src/frontends/controllers/ChangeLog
+++ b/src/frontends/controllers/ChangeLog
@@ -1,3 +1,8 @@
+2005-01-10  Jean-Marc Lasgouttes  <lasgouttes@lyx.org>
+
+	* ControlErrorList.C (goTo): fix the commented-out code (bug
+	1760).
+
 2005-01-10  Angus Leeming  <leeming@lyx.org>
 
 	* ControlAboutlyx.C:
diff --git a/src/frontends/controllers/ControlErrorList.C b/src/frontends/controllers/ControlErrorList.C
index 2542f2bc8b..28a7d07dff 100644
--- a/src/frontends/controllers/ControlErrorList.C
+++ b/src/frontends/controllers/ControlErrorList.C
@@ -69,17 +69,14 @@ void ControlErrorList::goTo(int item)
 	}
 
 	// Now make the selection.
-#ifdef WITH_WARNINGS
-#warning FIXME (goto error)
-#warning This should be implemented using an LFUN. (Angus)
-#endif
-#if 0
+	// This should be implemented using an LFUN. (Angus)
 	pos_type const end = std::min(err.pos_end, pit->size());
 	pos_type const start = std::min(err.pos_start, end);
 	pos_type const range = end - start;
-	PosIterator const pos(pit, start);
-	kernel().bufferview()->putSelectionAt(pos, range, false);
-#endif
+	DocIterator const dit = makeDocIterator(pit, start);
+	kernel().bufferview()->putSelectionAt(dit, range, false);
+	// If we used an LFUN, we would not need that
+	kernel().bufferview()->update();
 }
 
 } // namespace frontend