From: Richard Kimberly Heck <rikiheck@lyx.org>
Date: Sun, 23 Feb 2020 21:29:58 +0000 (-0500)
Subject: Revert "Fix memory leak reported by Scott."
X-Git-Url: https://git.lyx.org/gitweb/?a=commitdiff_plain;h=02da025ce92eec303d23954c81624d4fd7574af5;p=features.git

Revert "Fix memory leak reported by Scott."

It leads to a double delete error.

This reverts commit 11397a2e82ba19b69818f9891132ff7074bc1759.
---

diff --git a/src/Buffer.cpp b/src/Buffer.cpp
index 56e19b81be..eb65e811b4 100644
--- a/src/Buffer.cpp
+++ b/src/Buffer.cpp
@@ -545,10 +545,8 @@ Buffer::~Buffer()
 			if (it == cloned_buffers.end()) {
 				// We will leak in this case, but it is safe to continue.
 				LATTEST(false);
-			} else {
-				delete(*it);
+			} else
 				cloned_buffers.erase(it);
-			}
 			delete d->clone_list_;
 		}
 		// FIXME Do we really need to do this right before we delete d?