From: John Levon <levon@movementarian.org>
Date: Thu, 31 Oct 2002 20:45:57 +0000 (+0000)
Subject: fix external dialog
X-Git-Tag: 1.6.10~18036
X-Git-Url: https://git.lyx.org/gitweb/?a=commitdiff_plain;h=00c9ef1b8408592327a9111bd5c39f94ad685483;p=features.git

fix external dialog


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@5568 a592a061-630c-0410-9148-cb99ea01b6c8
---

diff --git a/src/frontends/qt2/ChangeLog b/src/frontends/qt2/ChangeLog
index c10a005cdd..1fb051d704 100644
--- a/src/frontends/qt2/ChangeLog
+++ b/src/frontends/qt2/ChangeLog
@@ -1,9 +1,13 @@
 2002-10-31  John Levon  <levon@movementarian.org>
 
-	* qt2/QGraphics.C:
-	* qt2/QGraphicsDialog.C:
-	* qt2/QGraphicsDialog.h:
-	* qt2/ui/QGraphicsDialog.ui: bb unit fixes
+	* QExternal.C: fix crash, valid check
+ 
+2002-10-31  John Levon  <levon@movementarian.org>
+
+	* QGraphics.C:
+	* QGraphicsDialog.C:
+	* QGraphicsDialog.h:
+	* ui/QGraphicsDialog.ui: bb unit fixes
  
 2002-10-30  John Levon  <levon@movementarian.org>
 
diff --git a/src/frontends/qt2/QExternal.C b/src/frontends/qt2/QExternal.C
index 90042d0370..69f2a6965f 100644
--- a/src/frontends/qt2/QExternal.C
+++ b/src/frontends/qt2/QExternal.C
@@ -74,7 +74,7 @@ string const & QExternal::helpText()
 {
 	InsetExternal::Params & params = controller().params();
 
-	params.templ = controller().getTemplate(dialog_->externalCO->currentItem() + 1);
+	params.templ = controller().getTemplate(dialog_->externalCO->currentItem());
 	return params.templ.helpText;
 }
 
@@ -86,15 +86,5 @@ void QExternal::apply()
 	params.filename = dialog_->fileED->text().latin1();
 	params.parameters = dialog_->paramsED->text().latin1();
 
-	params.templ = controller().getTemplate(dialog_->externalCO->currentItem() + 1);
-}
-
-
-bool QExternal::isValid()
-{
-	bool const valid = !string(dialog_->fileED->text()).empty();
-	dialog_->viewPB->setEnabled(valid);
-	dialog_->editPB->setEnabled(valid);
-	dialog_->updatePB->setEnabled(valid);
-	return valid;
+	params.templ = controller().getTemplate(dialog_->externalCO->currentItem());
 }