]> git.lyx.org Git - features.git/commitdiff
Avoid potential crashes with missing document buffer in dispatch of buffer based...
authorStephan Witt <switt@lyx.org>
Mon, 17 Feb 2020 12:36:37 +0000 (13:36 +0100)
committerJean-Marc Lasgouttes <lasgouttes@lyx.org>
Thu, 18 Jun 2020 13:48:52 +0000 (15:48 +0200)
Use LASSERT with appropriate action instead of LATTEST assertions.
Debug build is unchanged and asserts, release build skips the action gracefully.

src/frontends/qt/GuiView.cpp

index 29f97e72a112e6fda2ba09a0ef13746f39fd627d..83a2593c548abe4c315f5d7996e70126bf16a5f6 100644 (file)
@@ -4330,8 +4330,8 @@ void GuiView::dispatch(FuncRequest const & cmd, DispatchResult & dr)
                        string sdata = trim(to_utf8(cmd.argument()).substr(name.size()));
 
                        if (name == "latexlog") {
-                               // gettatus checks that
-                               LATTEST(doc_buffer);
+                               // getStatus checks that
+                               LASSERT(doc_buffer, break);
                                Buffer::LogType type;
                                string const logfile = doc_buffer->logName(&type);
                                switch (type) {
@@ -4346,7 +4346,7 @@ void GuiView::dispatch(FuncRequest const & cmd, DispatchResult & dr)
                                showDialog("log", sdata);
                        } else if (name == "vclog") {
                                // getStatus checks that
-                               LATTEST(doc_buffer);
+                               LASSERT(doc_buffer, break);
                                string const sdata2 = "vc " +
                                        Lexer::quoteString(doc_buffer->lyxvc().getLogFile());
                                showDialog("log", sdata2);
@@ -4508,7 +4508,7 @@ void GuiView::dispatch(FuncRequest const & cmd, DispatchResult & dr)
                case LFUN_FORWARD_SEARCH: {
                        // it seems safe to assume we have a document buffer, since
                        // getStatus wants one.
-                       LATTEST(doc_buffer);
+                       LASSERT(doc_buffer, break);
                        Buffer const * doc_master = doc_buffer->masterBuffer();
                        FileName const path(doc_master->temppath());
                        string const texname = doc_master->isChild(doc_buffer)