]> git.lyx.org Git - features.git/commitdiff
Use UndoGroupHelper to track undo group lifetime
authorJean-Marc Lasgouttes <lasgouttes@lyx.org>
Wed, 29 Nov 2017 13:55:56 +0000 (14:55 +0100)
committerJean-Marc Lasgouttes <lasgouttes@lyx.org>
Wed, 29 Nov 2017 13:55:56 +0000 (14:55 +0100)
src/frontends/qt4/GuiCompleter.cpp

index 9858b8d01a88166a51753bc230d3ed3d06c65980..c90520dc92d8f1ddd7f9b93d2bef62fc26eefc54 100644 (file)
@@ -676,7 +676,7 @@ void GuiCompleter::tab()
        }
 
        // Make undo possible
-       cur.beginUndoGroup();
+       UndoGroupHelper ugh;
        cur.recordUndo();
 
        // If completion is active, at least complete by one character
@@ -690,14 +690,11 @@ void GuiCompleter::tab()
                hidePopup();
                hideInline(cur);
                updateVisibility(false, false);
-               cur.endUndoGroup();
                return;
        }
        docstring nextchar = completion.substr(prefix.size(), 1);
-       if (!cur.inset().insertCompletion(cur, nextchar, false)) {
-               cur.endUndoGroup();
+       if (!cur.inset().insertCompletion(cur, nextchar, false))
                return;
-       }
        updatePrefix(cur);
 
        // try to complete as far as it is unique
@@ -717,7 +714,6 @@ void GuiCompleter::tab()
        // redraw if needed
        if (cur.result().screenUpdate())
                gui_->bufferView().processUpdateFlags(cur.result().screenUpdate());
-       cur.endUndoGroup();
 }