small refactoring

git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23876 a592a061-630c-0410-9148-cb99ea01b6c8

diff --git a/src/frontends/qt4/GuiSymbols.cpp b/src/frontends/qt4/GuiSymbols.cpp
index ac5aac45ee83b815b4b5e389d6f78b89acab7a47..38a87bfc5ac8bce893582135e4a194791fe75372 100644 (file)
--- a/src/frontends/qt4/GuiSymbols.cpp
+++ b/src/frontends/qt4/GuiSymbols.cpp
@@ -263,24 +263,27 @@ void GuiSymbols::on_categoryCO_activated(QString const & text)
 {
        if (!categoryFilterCB->isChecked())
                updateSymbolList(false);
-       else if (used_blocks.find(text) != used_blocks.end())
-               symbolsLW->scrollToItem(used_blocks[text],
-                       QAbstractItemView::PositionAtTop);
+       else
+               scrollToItem(text);
 }
 
 
 void GuiSymbols::on_categoryFilterCB_toggled(bool on)
 {
        updateSymbolList(on);
-       if (on) {
-               QString const category = categoryCO->currentText();
-               if (used_blocks.find(category) != used_blocks.end())
-                       symbolsLW->scrollToItem(used_blocks[category],
-                               QAbstractItemView::PositionAtTop);
-       }
+       if (on)
+               scrollToItem(categoryCO->currentText());        
 }
 
 
+void GuiSymbols::scrollToItem(QString const & category)
+{
+       if (used_blocks.find(category) != used_blocks.end()) {
+               symbolsLW->scrollToItem(used_blocks[category],
+                       QAbstractItemView::PositionAtTop);
+       }
+}
+
 void GuiSymbols::updateSymbolList(bool update_combo)
 {
        QString category = categoryCO->currentText();

diff --git a/src/frontends/qt4/GuiSymbols.h b/src/frontends/qt4/GuiSymbols.h
index c83f0eafaee0b0fc224b8f72b778180a5cf5017c..85622a51499e1cfaeedc645be2940b017273e3a4 100644 (file)
--- a/src/frontends/qt4/GuiSymbols.h
+++ b/src/frontends/qt4/GuiSymbols.h
@@ -51,6 +51,7 @@ public Q_SLOTS:
        void on_chosenLE_textChanged(QString const &);
 
 private:
+       void scrollToItem(QString const & category);
        /** update the widgets (symbol browser, category combo)
         *  \p combo indicates if the combo box has to be refreshed
         *  as well (which is rather expensive)