delete some emits that I missed, add comments about emitting signals

git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@14273 a592a061-630c-0410-9148-cb99ea01b6c8

diff --git a/src/frontends/qt3/BulletsModule.C b/src/frontends/qt3/BulletsModule.C
index fcc356500e2b14f9e7287aaa6590cbd6a9b80607..e8d55bf93c8a541d256df5e6e2dbade6795e20b0 100644 (file)
--- a/src/frontends/qt3/BulletsModule.C
+++ b/src/frontends/qt3/BulletsModule.C
@@ -142,6 +142,7 @@ BulletsModule::~BulletsModule()
 
 void BulletsModule::updateSizes()
 {
+        // emit signal
        changed();
 
        // -1 apparently means default...
@@ -185,6 +186,7 @@ void BulletsModule::selected1()
        tmpbulletset = false;
        bullets_[0] = tmpbullet;
        setBullet(bullet1PB, bulletsize1CO, bullets_[0]);
+        // emit signal
        changed();
 }
 
@@ -196,6 +198,7 @@ void BulletsModule::selected2()
        tmpbulletset = false;
        bullets_[1] = tmpbullet;
        setBullet(bullet2PB, bulletsize2CO, bullets_[1]);
+        // emit signal
        changed();
 }
 
@@ -207,6 +210,7 @@ void BulletsModule::selected3()
        tmpbulletset = false;
        bullets_[2] = tmpbullet;
        setBullet(bullet3PB, bulletsize3CO, bullets_[2]);
+        // emit signal
        changed();
 }
 
@@ -218,6 +222,7 @@ void BulletsModule::selected4()
        tmpbulletset = false;
        bullets_[3] = tmpbullet;
        setBullet(bullet4PB, bulletsize4CO, bullets_[3]);
+        // emit signal
        changed();
 }
 

diff --git a/src/frontends/qt3/QBrowseBox.C b/src/frontends/qt3/QBrowseBox.C
index 4bca767263f33c33e4a42ba116be2de57780a80f..12fb87c3ab4efbe048c669c2278f2bbabda49e14 100644 (file)
--- a/src/frontends/qt3/QBrowseBox.C
+++ b/src/frontends/qt3/QBrowseBox.C
@@ -161,6 +161,7 @@ void QBrowseBox::keyPressEvent(QKeyEvent * e)
                moveRight();
                break;
        case Key_Return:
+                // emit signal
                selected(activecell_.x(), activecell_.y());
                if ( isVisible() && parentWidget() &&
                     parentWidget()->inherits("QPopupMenu") )

diff --git a/src/frontends/qt3/QCommandBuffer.C b/src/frontends/qt3/QCommandBuffer.C
index 70fb5f4f1a66a6996bc680a448f26a6f8fa365d8..5abc67af17e087e3eb4f99b63f65065b337aac8b 100644 (file)
--- a/src/frontends/qt3/QCommandBuffer.C
+++ b/src/frontends/qt3/QCommandBuffer.C
@@ -50,6 +50,7 @@ protected:
                    || e->x() > width() || e->y() > height()) {
                        hide();
                } else {
+                        // emit signal
                        selected(currentText());
                }
        }

diff --git a/src/frontends/qt3/QCommandEdit.C b/src/frontends/qt3/QCommandEdit.C
index 540d70140fc532aaa4f0ae4850c031ecd9ddb3f2..564e64ff1c35a191ecda32e3c84204c0983ed8d6 100644 (file)
--- a/src/frontends/qt3/QCommandEdit.C
+++ b/src/frontends/qt3/QCommandEdit.C
@@ -26,14 +26,17 @@ void QCommandEdit::keyPressEvent(QKeyEvent * e)
 {
        switch (e->key()) {
        case Key_Escape:
+                // emit signal
                escapePressed();
                break;
 
        case Key_Up:
+                // emit signal
                upPressed();
                break;
 
        case Key_Down:
+                // emit signal
                downPressed();
                break;
 
@@ -54,6 +57,7 @@ bool QCommandEdit::event(QEvent * e)
        if (ev->key() != Key_Tab)
                return QLineEdit::event(e);
 
+        // emit signal
        tabPressed();
        return true;
 }

diff --git a/src/frontends/qt3/emptytable.C b/src/frontends/qt3/emptytable.C
index a82235ceba70dc52d10602850725d19504873292..e07910aeecee21fdb863eca9d2bd93c20fb35662 100644 (file)
--- a/src/frontends/qt3/emptytable.C
+++ b/src/frontends/qt3/emptytable.C
@@ -75,6 +75,7 @@ void EmptyTable::setNumberColumns(int nr_cols)
        updateGeometry();
        setAutoUpdate(true);
        update();
+        // emit signal
        colsChanged(nr_cols);
 }
 
@@ -90,6 +91,7 @@ void EmptyTable::setNumberRows(int nr_rows)
        updateGeometry();
        setAutoUpdate(true);
        update();
+        // emit signal
        rowsChanged(nr_rows);
 }
 

diff --git a/src/frontends/qt3/floatplacement.C b/src/frontends/qt3/floatplacement.C
index 37ee9fbe178d865e08123b859ae7ef12bb03ca29..77eb940b0c7889cb073b3c37539cc4cad3b997c7 100644 (file)
--- a/src/frontends/qt3/floatplacement.C
+++ b/src/frontends/qt3/floatplacement.C
@@ -101,6 +101,7 @@ void FloatPlacement::useSideways()
 
 void FloatPlacement::changedSlot()
 {
+        // emit signal
        changed();
 }
 

diff --git a/src/frontends/qt3/iconpalette.C b/src/frontends/qt3/iconpalette.C
index 1a814b067e70f55dd268daa7c364eba3fad806cf..82d56690154d7b94fa84138da7fcaaa1434ad3e2 100644 (file)
--- a/src/frontends/qt3/iconpalette.C
+++ b/src/frontends/qt3/iconpalette.C
@@ -57,7 +57,8 @@ void IconPalette::clicked()
        vector<Button>::const_iterator const end(buttons_.end());
        for (; it != end; ++it) {
                if (sender() == it->first) {
-                        button_clicked(it->second);
+                        // emit signal
+                        button_clicked(it->second);
                        return;
                }
        }

diff --git a/src/frontends/qt3/lengthcombo.C b/src/frontends/qt3/lengthcombo.C
index cc29ddb070bdc3df69e329e9aaf4625e8f94d1f7..35f87e23e471c5a8cfd1609635383beeab833192 100644 (file)
--- a/src/frontends/qt3/lengthcombo.C
+++ b/src/frontends/qt3/lengthcombo.C
@@ -35,6 +35,7 @@ LyXLength::UNIT LengthCombo::currentLengthItem() const
 
 void LengthCombo::has_activated(int)
 {
+        // emit signal
        selectionChanged(currentLengthItem());
 }
 

diff --git a/src/frontends/qt3/qsetborder.C b/src/frontends/qt3/qsetborder.C
index 7ee1b73841c1d92cb62ac501148519a6a4c9e05b..4975de81acca1f8de85c966f6f5ae97a5d8d551b 100644 (file)
--- a/src/frontends/qt3/qsetborder.C
+++ b/src/frontends/qt3/qsetborder.C
@@ -71,11 +71,13 @@ void QSetBorder::mousePressEvent(QMouseEvent * e)
                if (e->y() < height() - e->x()) {
                        if (left_.enabled) {
                                setLeft(!left_.set);
+                                // emit signal
                                leftSet(left_.set);
                        }
                } else {
                        if (bottom_.enabled) {
                                setBottom(!bottom_.set);
+                                // emit signal
                                bottomSet(bottom_.set);
                        }
                }
@@ -83,16 +85,19 @@ void QSetBorder::mousePressEvent(QMouseEvent * e)
                if (e->y() < height() - e->x()) {
                        if (top_.enabled) {
                                setTop(!top_.set);
+                                // emit signal
                                topSet(top_.set);
                        }
                } else {
                        if (right_.enabled) {
                                setRight(!right_.set);
+                                // emit signal
                                rightSet(right_.set);
                        }
                }
        }
        update();
+        // emit signal
        clicked();
 }
 

diff --git a/src/frontends/qt4/BulletsModule.C b/src/frontends/qt4/BulletsModule.C
index 54b85691ed55bb7fd749d57ef806b03ea17902de..9aabcbdff33b8b1002845b616f97e4b1ccf188ba 100644 (file)
--- a/src/frontends/qt4/BulletsModule.C
+++ b/src/frontends/qt4/BulletsModule.C
@@ -149,7 +149,8 @@ BulletsModule::~BulletsModule()
 
 void BulletsModule::updateSizes()
 {
-       emit changed();
+        // emit signal
+       changed();
 
        // -1 apparently means default...
        bullets_[0].setSize(bulletsize1CO->currentItem() - 1);
@@ -192,7 +193,8 @@ void BulletsModule::selected1()
        tmpbulletset = false;
        bullets_[0] = tmpbullet;
        setBullet(bullet1PB, bulletsize1CO, bullets_[0]);
-       emit changed();
+        // emit signal
+       changed();
 }
 
 
@@ -203,7 +205,8 @@ void BulletsModule::selected2()
        tmpbulletset = false;
        bullets_[1] = tmpbullet;
        setBullet(bullet2PB, bulletsize2CO, bullets_[1]);
-       emit changed();
+        // emit signal
+       changed();
 }
 
 
@@ -214,7 +217,8 @@ void BulletsModule::selected3()
        tmpbulletset = false;
        bullets_[2] = tmpbullet;
        setBullet(bullet3PB, bulletsize3CO, bullets_[2]);
-       emit changed();
+        // emit signal
+       changed();
 }
 
 
@@ -225,7 +229,8 @@ void BulletsModule::selected4()
        tmpbulletset = false;
        bullets_[3] = tmpbullet;
        setBullet(bullet4PB, bulletsize4CO, bullets_[3]);
-       emit changed();
+        // emit signal
+       changed();
 }
 
 

diff --git a/src/frontends/qt4/InsertTableWidget.C b/src/frontends/qt4/InsertTableWidget.C
index 319e6fd22722a1a2877493f855f868dc1101205f..7b43f45bbd0c27aa4c3f2b6755b5eca46175bc76 100644 (file)
--- a/src/frontends/qt4/InsertTableWidget.C
+++ b/src/frontends/qt4/InsertTableWidget.C
@@ -55,7 +55,8 @@ void InsertTableWidget::show(bool show)
        init();\r
        resetGeometry();\r
        setVisible(true);\r
-       emit visible(true);\r
+        // emit signal\r
+       visible(true);\r
 }\r
 \r
 \r
@@ -109,7 +110,8 @@ void InsertTableWidget::mouseReleaseEvent(QMouseEvent * event)
                QString const data = QString("%1 %2").arg(bottom_).arg(right_);\r
                lyxView_.getLyXFunc().dispatch(FuncRequest(LFUN_TABULAR_INSERT, fromqstr(data)));\r
        }\r
-       emit visible(false);\r
+        // emit signal\r
+       visible(false);\r
        close();\r
 }\r
 \r

diff --git a/src/frontends/qt4/QBranches.C b/src/frontends/qt4/QBranches.C
index 39776cef95521fc262bc0493d8fed5bb44c0b1a1..e0f1c1275f68aca15fb76cc2e26eebda36dd935c 100644 (file)
--- a/src/frontends/qt4/QBranches.C
+++ b/src/frontends/qt4/QBranches.C
@@ -86,7 +86,8 @@ void QBranches::update()
                if (bname == sel_branch)
                        branchesTW->setItemSelected(newItem, true);
        }
-       emit changed();
+        // emit signal
+       changed();
 }
 
 void QBranches::apply(BufferParams & params) const

diff --git a/src/frontends/qt4/QCommandBuffer.C b/src/frontends/qt4/QCommandBuffer.C
index d2eab207c94e9ba3dd4035b2fedf45dc3fe2a43f..7081e0820e1e3b9766aefa9539bd700a3219cdeb 100644 (file)
--- a/src/frontends/qt4/QCommandBuffer.C
+++ b/src/frontends/qt4/QCommandBuffer.C
@@ -58,7 +58,8 @@ protected:
                    || e->x() > width() || e->y() > height()) {
                        hide();
                } else {
-                       emit itemPressed(currentItem());
+                        // emit signal
+                       itemPressed(currentItem());
                }
        }
 

diff --git a/src/frontends/qt4/QCommandEdit.C b/src/frontends/qt4/QCommandEdit.C
index dd786e6072f2c0c96c0e09bb5c28728cbcd51943..d0882f49d7139ce03ab415132e742f17aee5dc1e 100644 (file)
--- a/src/frontends/qt4/QCommandEdit.C
+++ b/src/frontends/qt4/QCommandEdit.C
@@ -29,15 +29,18 @@ void QCommandEdit::keyPressEvent(QKeyEvent * e)
 {
        switch (e->key()) {
        case Qt::Key_Escape:
-               emit escapePressed();
+                // emit signal
+               escapePressed();
                break;
 
        case Qt::Key_Up:
-               emit upPressed();
+                // emit signal
+               upPressed();
                break;
 
        case Qt::Key_Down:
-               emit downPressed();
+                // emit signal
+               downPressed();
                break;
 
        default:
@@ -57,7 +60,8 @@ bool QCommandEdit::event(QEvent * e)
        if (ev->key() != Qt::Key_Tab)
                return QLineEdit::event(e);
 
-       emit tabPressed();
+        // emit signal
+       tabPressed();
        return true;
 }
 

diff --git a/src/frontends/qt4/QLToolbar.C b/src/frontends/qt4/QLToolbar.C
index 91c4e8a58ca6a6d6215e80b833e71dde23cd52da..10df4f9143c972ec3f5e79cbfe1cf5642cdea5ef 100644 (file)
--- a/src/frontends/qt4/QLToolbar.C
+++ b/src/frontends/qt4/QLToolbar.C
@@ -282,7 +282,8 @@ void QLToolbar::update()
        for (size_t i=0; i<ActionVector.size(); ++i)
                ActionVector[i]->update();
 
-       emit updated();
+        // emit signal
+       updated();
 }
 
 

diff --git a/src/frontends/qt4/QMathDialog.h b/src/frontends/qt4/QMathDialog.h
index 1a49f572ef087be9fbfb2b481c815b5651bf79d7..633506b8b7fcbbabb52fa2e73497677114623263 100644 (file)
--- a/src/frontends/qt4/QMathDialog.h
+++ b/src/frontends/qt4/QMathDialog.h
@@ -34,7 +34,8 @@ signals:
        void action(const std::string &);
 protected slots:
        void action() {
-               emit action(action_);
+                // emit signal
+               action(action_);
        }
 private:
        std::string action_;

diff --git a/src/frontends/qt4/QPrefsDialog.C b/src/frontends/qt4/QPrefsDialog.C
index f421b348e821fe7324719bb1eb6917fa69f83f40..4b04e673eb3523b4ad4c19dda2ccacaec20acbc0 100644 (file)
--- a/src/frontends/qt4/QPrefsDialog.C
+++ b/src/frontends/qt4/QPrefsDialog.C
@@ -560,6 +560,7 @@ void PrefColors::change_color()
                QPixmap coloritem(32, 32);
                coloritem.fill(c);
                lyxObjectsLW->currentItem()->setIcon(QIcon(coloritem));
+                // emit signal
                changed();
        }
 }

diff --git a/src/frontends/qt4/emptytable.C b/src/frontends/qt4/emptytable.C
index 888d288c93384cbb08badf69e802b4d1ba293722..53925c2e76671b0ff57e66405964e799dd7f4e58 100644 (file)
--- a/src/frontends/qt4/emptytable.C
+++ b/src/frontends/qt4/emptytable.C
@@ -81,7 +81,8 @@ void EmptyTable::setNumberColumns(int nr_cols)
        setColumnCount(nr_cols);
        resetCellSize();
        updateGeometry();
-       emit colsChanged(nr_cols);
+        // emit signal
+       colsChanged(nr_cols);
 }
 
 
@@ -94,7 +95,8 @@ void EmptyTable::setNumberRows(int nr_rows)
        setRowCount(nr_rows);
        resetCellSize();
        updateGeometry();
-       emit rowsChanged(nr_rows);
+        // emit signal
+       rowsChanged(nr_rows);
 }
 
 /*

diff --git a/src/frontends/qt4/floatplacement.C b/src/frontends/qt4/floatplacement.C
index 54fba48b8eedd27f664cd7030fad688915ae3b1c..3151a7f00851204710df233f2b66a78b130f0086 100644 (file)
--- a/src/frontends/qt4/floatplacement.C
+++ b/src/frontends/qt4/floatplacement.C
@@ -104,7 +104,8 @@ void FloatPlacement::useSideways()
 
 void FloatPlacement::changedSlot()
 {
-       emit changed();
+        // emit signal
+       changed();
 }
 
 

diff --git a/src/frontends/qt4/iconpalette.C b/src/frontends/qt4/iconpalette.C
index 6766c5e85e07f87f435349546b17c910ed5c908d..c3c508c2ce4ce9618298fe43c72e71566d541aa1 100644 (file)
--- a/src/frontends/qt4/iconpalette.C
+++ b/src/frontends/qt4/iconpalette.C
@@ -62,7 +62,8 @@ void IconPalette::clicked()
        vector<Button>::const_iterator const end(buttons_.end());
        for (; it != end; ++it) {
                if (sender() == it->first) {
-                       emit button_clicked(it->second);
+                        // emit signal
+                       button_clicked(it->second);
                        return;
                }
        }

diff --git a/src/frontends/qt4/lengthcombo.C b/src/frontends/qt4/lengthcombo.C
index 2d681fb9c8786f26a24316d5a73f79c04f9bf976..197e90ae5dfbc9c8678fd8f2536391eff9ef51e0 100644 (file)
--- a/src/frontends/qt4/lengthcombo.C
+++ b/src/frontends/qt4/lengthcombo.C
@@ -44,7 +44,8 @@ LyXLength::UNIT LengthCombo::currentLengthItem() const
 
 void LengthCombo::has_activated(int)
 {
-       emit selectionChanged(currentLengthItem());
+        // emit signal
+       selectionChanged(currentLengthItem());
 }
 
 

diff --git a/src/frontends/qt4/qsetborder.C b/src/frontends/qt4/qsetborder.C
index 542ca8e43e2c971ff6c5f8b59a613ef468f3c9f4..c6e1861fdf05c4d886dda09094353e0e9426bb0a 100644 (file)
--- a/src/frontends/qt4/qsetborder.C
+++ b/src/frontends/qt4/qsetborder.C
@@ -74,29 +74,34 @@ void QSetBorder::mousePressEvent(QMouseEvent * e)
                if (e->y() < height() - e->x()) {
                        if (left_.enabled) {
                                setLeft(!left_.set);
-                               emit leftSet(left_.set);
+                                // emit signal
+                               leftSet(left_.set);
                        }
                } else {
                        if (bottom_.enabled) {
                                setBottom(!bottom_.set);
-                               emit bottomSet(bottom_.set);
+                                // emit signal
+                               bottomSet(bottom_.set);
                        }
                }
        } else {
                if (e->y() < height() - e->x()) {
                        if (top_.enabled) {
                                setTop(!top_.set);
-                               emit topSet(top_.set);
+                                // emit signal
+                               topSet(top_.set);
                        }
                } else {
                        if (right_.enabled) {
                                setRight(!right_.set);
-                               emit rightSet(right_.set);
+                                // emit signal
+                               rightSet(right_.set);
                        }
                }
        }
        update();
-       emit clicked();
+        // emit signal
+       clicked();
 }