Improve Update::FitCursor when there is a selection

It is better indeed to try to make the whole selection fit on screen.

Fixes bug #11012.

diff --git a/src/BufferView.cpp b/src/BufferView.cpp
index 4495093cf2b3356a0fb1495e497ce1e1672a8719..eda08ed6f97aa8b8b1feca0d529a8fe1b4af8a78 100644 (file)
--- a/src/BufferView.cpp
+++ b/src/BufferView.cpp
@@ -527,7 +527,13 @@ void BufferView::processUpdateFlags(Update::flags flags)
        // Then make sure that the screen contains the cursor if needed
        if (flags & Update::FitCursor) {
                if (needsFitCursor()) {
-                       scrollToCursor(d->cursor_, false);
+                       // First try to make the selection start visible
+                       // (which is just the cursor when there is no selection)
+                       scrollToCursor(d->cursor_.selectionBegin(), false);
+                       // Is the cursor visible? (only useful if cursor is at end of selection)
+                       if (needsFitCursor())
+                               // then try to make cursor visible instead
+                               scrollToCursor(d->cursor_, false);
                        // Metrics have to be recomputed (maybe again)
                        updateMetrics(flags);
                }