]> git.lyx.org Git - features.git/commitdiff
Submenus now expand even if all items are disabled
authorScott Kostyshak <skostysh@lyx.org>
Fri, 21 Feb 2014 15:26:36 +0000 (10:26 -0500)
committerScott Kostyshak <skostysh@lyx.org>
Mon, 28 Jul 2014 16:59:34 +0000 (12:59 -0400)
As stated in the Apple HIG[1] (via JMarc):

  Ensure that a submenu’s title is undimmed even when all its commands
  are unavailable. As with menu titles, it’s important for users to be
  able to view a submenu’s contents, even if none of them are
  available in the current context.

[1]
https://developer.apple.com/library/mac/documentation/UserExperience/Conceptual/AppleHIGuidelines/Menus/Menus.html#//apple_ref/doc/uid/TP30000356-TP6

src/frontends/qt4/Menus.cpp

index 707251dfbb27749c9d092b7cf6fcfd035f44abc0..7fa219b394d93d3bfc5a3b53b3f54f8c87c7b9b2 100644 (file)
@@ -418,8 +418,7 @@ void MenuDefinition::addWithStatusCheck(MenuItem const & i)
                                // Only these kind of items affect the status of the submenu
                                if ((cit->kind() == MenuItem::Command
                                        || cit->kind() == MenuItem::Submenu
-                                       || cit->kind() == MenuItem::Help)
-                                   && cit->status().enabled()) {
+                                       || cit->kind() == MenuItem::Help)) {
                                        enabled = true;
                                        break;
                                }