]> git.lyx.org Git - features.git/commitdiff
Fix Qt deprecation warns for setTextColor()
authorScott Kostyshak <skostysh@lyx.org>
Thu, 19 Mar 2020 14:16:19 +0000 (10:16 -0400)
committerJean-Marc Lasgouttes <lasgouttes@lyx.org>
Thu, 18 Jun 2020 13:48:54 +0000 (15:48 +0200)
This commit fixes the following warning from Qt 5.14:

  error: ‘void QTreeWidgetItem::setTextColor(int, const QColor&)’ is deprecated: Use QTreeWidgetItem::setForeground() instead [-Werror=deprecated-declarations]

setForeground was introduced in Qt 4.2 [1].

We have a couple of commented out uses of a setTextColor() method in
GuiDocument.cpp, but the QTextEdit::setTextColor() is not deprecated so no
change is needed.

[1] https://doc.qt.io/archives/qt-4.8/qtreewidgetitem.html#setForeground

src/frontends/qt/PanelStack.cpp

index c61c8e02442f531fb3eae7ac2c0abde51a46f900..243542d32150368d44b1bdae39092494c5044877 100644 (file)
@@ -212,7 +212,7 @@ static void setTreeItemStatus(QTreeWidgetItem * tree_item, bool enabled)
        // Change the color from black to gray or viceversa
        QPalette::ColorGroup new_color =
                enabled ? QPalette::Active : QPalette::Disabled;
-       tree_item->setTextColor(0, QApplication::palette().color(new_color,
+       tree_item->setForeground(0, QApplication::palette().color(new_color,
                                                                 QPalette::Text));
 }