Avoid a couple of copies

Spotted by Coverity scan.

diff --git a/src/insets/InsetCitation.cpp b/src/insets/InsetCitation.cpp
index 8dc71541bbb4896715db356533a18f78ab4f00f1..73a17e70ff8ff7089c5459256247d84c97b16e9d 100644 (file)
--- a/src/insets/InsetCitation.cpp
+++ b/src/insets/InsetCitation.cpp
@@ -476,7 +476,7 @@ docstring InsetCitation::complexLabel(bool for_xhtml) const
                        break;
                }
        }
-       
+
        string cite_type = getCmdName();
        bool const uppercase = isUpperCase(cite_type[0]);
        if (uppercase)
@@ -502,8 +502,6 @@ docstring InsetCitation::complexLabel(bool for_xhtml) const
                && (keys.size() > 1
                    || !getParam("pretextlist").empty()
                    || !getParam("posttextlist").empty());
-       QualifiedList pres = getQualifiedLists(getParam("pretextlist"));
-       QualifiedList posts = getQualifiedLists(getParam("posttextlist"));
 
        CiteItem ci;
        ci.textBefore = getParam("before");
@@ -512,8 +510,8 @@ docstring InsetCitation::complexLabel(bool for_xhtml) const
        ci.Starred = starred;
        ci.max_size = UINT_MAX;
        ci.isQualified = qualified;
-       ci.pretexts = pres;
-       ci.posttexts = posts;
+       ci.pretexts = getQualifiedLists(getParam("pretextlist"));
+       ci.posttexts = getQualifiedLists(getParam("posttextlist"));
        if (for_xhtml) {
                ci.max_key_size = UINT_MAX;
                ci.context = CiteItem::Export;