initialize scrollbar parameters to some sensible dummy values.

valgrind reported conditional jumps on uninitialized values
in BufferView.cpp:1920

git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@24298 a592a061-630c-0410-9148-cb99ea01b6c8

diff --git a/src/BufferView.cpp b/src/BufferView.cpp
index c1e291c5f8c30e6a7cf67df23995df4651d6b44a..b9a6aae461d7ae347ebeb0216052e013024ff60a 100644 (file)
--- a/src/BufferView.cpp
+++ b/src/BufferView.cpp
@@ -1602,8 +1602,8 @@ void BufferView::lfunScroll(FuncRequest const & cmd)
 {
        string const scroll_type = cmd.getArg(0);
        int const scroll_step = 
-               (scroll_type == "line")? d->scrollbarParameters_.single_step
-               : (scroll_type == "page")? d->scrollbarParameters_.page_step : 0;
+               (scroll_type == "line") ? d->scrollbarParameters_.single_step
+               : (scroll_type == "page") ? d->scrollbarParameters_.page_step : 0;
        if (scroll_step == 0)
                return;
        string const scroll_quantity = cmd.getArg(1);

diff --git a/src/BufferView.h b/src/BufferView.h
index df8d4b2b8f54d23290f340ac9f51ddc605a816b0..9dbab432986f51f8d6fc47334370bd2bb4a96797 100644 (file)
--- a/src/BufferView.h
+++ b/src/BufferView.h
@@ -51,6 +51,9 @@ enum CursorStatus {
 /// Scrollbar Parameters.
 struct ScrollbarParameters
 {
+       ScrollbarParameters()
+               : min(0), max(1), position(0), single_step(1), page_step(1)
+       {}
        /// Minimum scrollbar position in pixels.
        int min;
        /// Maximum scrollbar position in pixels.