Do not check again and again for non existing files

If the file of an InsetInclude does not exist, loadIfNeeded will try
again and again to look for it. This is very bad for files with many
include insets, especially on windows.

Fixes bug #11656.

(cherry picked from commit aeed6fb8fa35c045697fe6950c6109be8d30884c)

diff --git a/src/insets/InsetInclude.cpp b/src/insets/InsetInclude.cpp
index 9c00bbaa34ededea7be7a6345d66bb619cc6ab81..e21de4d4b8984a914a525b9f4e89e9fe714a853a 100644 (file)
--- a/src/insets/InsetInclude.cpp
+++ b/src/insets/InsetInclude.cpp
@@ -460,8 +460,10 @@ Buffer * InsetInclude::loadIfNeeded() const
        Buffer * child = theBufferList().getBuffer(included_file);
        if (!child) {
                // the readonly flag can/will be wrong, not anymore I think.
-               if (!included_file.exists())
+               if (!included_file.exists()) {
+                       failedtoload_ = true;
                        return 0;
+               }
 
                child = theBufferList().newBuffer(included_file.absFileName());
                if (!child)

diff --git a/status.23x b/status.23x
index 22b9b5dd234cb76fd21c59934d28a4058f347e5a..4de5e0179e69d0222658bde630d56f77e6b3bf38 100644 (file)
--- a/status.23x
+++ b/status.23x
@@ -36,6 +36,9 @@ What's new
 
 - Fix display with Wayland (bug 11692).
 
+- Improve editing performance when there are Include insets that point to
+  non-existing files. (bug 11656).
+
 
 * DOCUMENTATION AND LOCALIZATION