Graph::getReachable(): pass a parameter by const reference

Spotted by coverity.

diff --git a/src/Graph.cpp b/src/Graph.cpp
index 0165bdacc9a4c95d626f21996f83f010c1a52959..608d0bd8b5d99cb12b8de0105ee7c6dd46129f9e 100644 (file)
--- a/src/Graph.cpp
+++ b/src/Graph.cpp
@@ -79,9 +79,8 @@ Graph::EdgePath const
 }
 
 
-Graph::EdgePath const
-       Graph::getReachable(int from, bool only_viewable,
-               bool clear_visited, set<int> excludes)
+Graph::EdgePath const Graph::getReachable(int from, bool only_viewable, bool clear_visited,
+                                             set<int> const & excludes)
 {
        EdgePath result;
        queue<int> Q;

diff --git a/src/Graph.h b/src/Graph.h
index 3f3404052f880b33a7cca7ffed89c92cfe2d99dc..4361ca11126c10550a730ad2e0e360d4d234053f 100644 (file)
--- a/src/Graph.h
+++ b/src/Graph.h
@@ -33,8 +33,8 @@ public:
        /// \return a vector of the vertices from which "to" can be reached
        EdgePath const getReachableTo(int to, bool clear_visited);
        /// \return a vector of the reachable vertices, avoiding all "excludes"
-       EdgePath const getReachable(int from, bool only_viewable,
-               bool clear_visited, std::set<int> excludes = std::set<int>());
+       EdgePath const getReachable(int from, bool only_viewable, bool clear_visited,
+                                   std::set<int> const & excludes = std::set<int>());
        /// can "from" be reached from "to"?
        bool isReachable(int from, int to);
        /// find a path from "from" to "to". always returns one of the