* when going backwards and entering a cell/paragraph, there is no

  inset yet. The lastpos() position is only virtual to place the cursor
  at a cell/paragraph end
* cleanups, documentation

git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23354 a592a061-630c-0410-9148-cb99ea01b6c8

diff --git a/src/DocIterator.cpp b/src/DocIterator.cpp
index 7aa7acf97715e28b1dacf65e53dacf954d07bc67..6130db53c4e10f5e80542c48727aa10ea589204a 100644 (file)
--- a/src/DocIterator.cpp
+++ b/src/DocIterator.cpp
@@ -261,30 +261,27 @@ void DocIterator::forwardPos()
        CursorSlice & tip = top();
        //lyxerr << "XXX\n" << *this << endl;
 
-       // this is used twice and shows up in the profiler!
-       pos_type const lastp = lastpos();
-
-       // move into an inset to the right if possible
-       Inset * n = 0;
-
-       if (tip.pos() != lastp) {
-               // this is impossible for pos() == size()
+       // not at cell/paragraph end?
+       if (tip.pos() != tip.lastpos()) {
+               // move into an inset to the right if possible
+               Inset * n = 0;
                if (inMathed())
                        n = (tip.cell().begin() + tip.pos())->nucleus();
                else
                        n = paragraph().getInset(tip.pos());
+               if (n && n->isActive()) {
+                       //lyxerr << "... descend" << endl;
+                       push_back(CursorSlice(*n));
+                       return;
+               }
        }
 
-       if (n && n->isActive()) {
-               //lyxerr << "... descend" << endl;
-               push_back(CursorSlice(*n));
-               return;
-       }
-
+       // jump to the next cell/paragraph if possible
        if (!tip.at_end()) {
                tip.forwardPos();
                return;
        }
+
        // otherwise leave inset and jump over inset as a whole
        pop_back();
        // 'tip' is invalid now...
@@ -373,6 +370,7 @@ void DocIterator::backwardPos()
                return;
        }
 
+       // at inset beginning?
        if (top().at_begin()) {
                pop_back();
                return;
@@ -380,14 +378,16 @@ void DocIterator::backwardPos()
 
        top().backwardPos();
 
+       // entered another cell/paragraph from the right?
+       if (top().pos() == top().lastpos())
+               return;
+
        // move into an inset to the left if possible
        Inset * n = 0;
-
        if (inMathed())
                n = (top().cell().begin() + top().pos())->nucleus();
        else
                n = paragraph().getInset(top().pos());
-
        if (n && n->isActive()) {
                push_back(CursorSlice(*n));
                top().idx() = lastidx();