RCS read-only toggling also doesn't work correctly for a long time.

http://www.mail-archive.com/lyx-devel@lists.lyx.org/msg156626.html

git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@32745 a592a061-630c-0410-9148-cb99ea01b6c8

diff --git a/src/LyXAction.cpp b/src/LyXAction.cpp
index 8e5a6c6c80b46ea1bd41abc9eeec8691e0d55769..e7e978ffe630771041ca3fa62ec131ac01dc2f47 100644 (file)
--- a/src/LyXAction.cpp
+++ b/src/LyXAction.cpp
@@ -2967,9 +2967,8 @@ void LyXAction::init()
 /*!
  * \var lyx::FuncCode lyx::LFUN_BUFFER_TOGGLE_READ_ONLY
  * \li Action: Toggle editing mode of the current document between read/write and read-only.
- * \li Notion: In the ->Readonly mode checks-in/commits the data if the file is under version control.
-               In the Readonly-> mode checkouts the data from repository. \n
-               If these operations fail, buffer won't be toggled.
+ * \li Notion: This function is not allowed if the file is under version control, since
+               read-only flag is often used in version control file locking.
  * \li Syntax: buffer-toggle-read-only
  * \li Origin: Lgb, 27 May 1997
  * \endvar

diff --git a/src/VCBackend.cpp b/src/VCBackend.cpp
index bf117d249462f3e94d3b4d8b0afae8da2f1afddf..422483347c303bf234c1f5b8ced66a42290218bc 100644 (file)
--- a/src/VCBackend.cpp
+++ b/src/VCBackend.cpp
@@ -273,7 +273,11 @@ void RCS::getLog(FileName const & tmpf)
 
 bool RCS::toggleReadOnlyEnabled()
 {
-       return true;
+       // This got broken somewhere along lfuns dispatch reorganization.
+       // reloadBuffer would be needed after this, but thats problematic
+       // since we are inside Buffer::dispatch.
+       // return true;
+       return false;
 }