Remove some useless expressions

Spotted by cppcheck

diff --git a/src/BiblioInfo.cpp b/src/BiblioInfo.cpp
index e7ca878a2bd51eaabbe3c3b0dd5b6e7eb5c2db79..8d5bfe5f7206ea68f6b0a85a8409429bc79ef051 100644 (file)
--- a/src/BiblioInfo.cpp
+++ b/src/BiblioInfo.cpp
@@ -1330,7 +1330,6 @@ docstring const BiblioInfo::getInfo(docstring const & key,
                return docstring(_("Bibliography entry not found!"));
        BibTeXInfo const & data = it->second;
        BibTeXInfoList xrefptrs;
-       vector<docstring> const xrefs = getXRefs(data);
        for (docstring const & xref : getXRefs(data)) {
                BiblioInfo::const_iterator const xrefit = find(xref);
                if (xrefit != end())

diff --git a/src/BufferView.cpp b/src/BufferView.cpp
index b960da639989f746a9b343d2a2b68229c94093e3..0aad452fd0f2a4c04088922a3f1fe7278180ab0d 100644 (file)
--- a/src/BufferView.cpp
+++ b/src/BufferView.cpp
@@ -3185,7 +3185,6 @@ void BufferView::draw(frontend::Painter & pain, bool paint_caret)
                // however, the different coordinates of insets and paragraphs
                // needs to be updated.
                LYXERR(Debug::PAINTING, "Strategy: NoScreenUpdate");
-               pi.full_repaint = false;
                if (pain.isNull()) {
                        pi.full_repaint = true;
                        tm.draw(pi, 0, y);

diff --git a/src/Text3.cpp b/src/Text3.cpp
index aba73974defc1cb0649643f55eace38926fd25e9..664ffb459b8fbd0c9426908330ae36565795e3b8 100644 (file)
--- a/src/Text3.cpp
+++ b/src/Text3.cpp
@@ -581,7 +581,6 @@ Language const * getLanguage(Cursor const & cur, string const & lang)
 docstring resolveLayout(docstring layout, DocIterator const & dit)
 {
        Paragraph const & par = dit.paragraph();
-       docstring const old_layout = par.layout().name();
        DocumentClass const & tclass = dit.buffer()->params().documentClass();
 
        if (layout.empty())

diff --git a/src/frontends/qt/GuiView.cpp b/src/frontends/qt/GuiView.cpp
index 581967fc4d6a2f2279727e0e61855bc687f1e97d..bbc9beb378c91fa819c3a190078de8e6f8d52e4e 100644 (file)
--- a/src/frontends/qt/GuiView.cpp
+++ b/src/frontends/qt/GuiView.cpp
@@ -1996,7 +1996,6 @@ bool GuiView::getStatus(FuncRequest const & cmd, FuncStatus & flag)
                        break;
                }
                return doc_buffer->getStatus(cmd, flag);
-               break;
        }
 
        case LFUN_BUFFER_EXPORT_AS: