Pass some variables as reference

Spotted by cppcheck.

diff --git a/src/frontends/qt/GuiBibtex.cpp b/src/frontends/qt/GuiBibtex.cpp
index 8414daa1cd8937365028c34d63d2ccc173433bcf..897224cfeea35390976ef80a2e136a45bf8ffdda 100644 (file)
--- a/src/frontends/qt/GuiBibtex.cpp
+++ b/src/frontends/qt/GuiBibtex.cpp
@@ -520,7 +520,7 @@ vector<docstring> GuiBibtex::getFileEncodings()
 }
 
 
-void GuiBibtex::setFileEncodings(vector<docstring> const m)
+void GuiBibtex::setFileEncodings(vector<docstring> const & m)
 {
        for (docstring const & s: m) {
                docstring key;

diff --git a/src/frontends/qt/GuiBibtex.h b/src/frontends/qt/GuiBibtex.h
index 997902e4ab9954a65e0ae96e92ec8d720838ad52..214ff854c837bd7c0056281e7fcab1c0c16e2576 100644 (file)
--- a/src/frontends/qt/GuiBibtex.h
+++ b/src/frontends/qt/GuiBibtex.h
@@ -88,7 +88,7 @@ private:
        ///
        std::vector<docstring> getFileEncodings();
        ///
-       void setFileEncodings(std::vector<docstring> const m);
+       void setFileEncodings(std::vector<docstring> const & m);
 
        ///
        bool initialiseParams(std::string const & data);

diff --git a/src/frontends/qt/GuiCitation.cpp b/src/frontends/qt/GuiCitation.cpp
index e5610589c893492eff628e01c98e170027898324..88a22fe2e080442936601c847334805540d8341c 100644 (file)
--- a/src/frontends/qt/GuiCitation.cpp
+++ b/src/frontends/qt/GuiCitation.cpp
@@ -692,7 +692,7 @@ QStringList GuiCitation::selectedKeys()
 }
 
 
-void GuiCitation::setPreTexts(vector<docstring> const m)
+void GuiCitation::setPreTexts(vector<docstring> const & m)
 {
        // account for multiple use of the same keys
        QList<QModelIndex> handled;
@@ -731,7 +731,7 @@ vector<docstring> GuiCitation::getPreTexts()
 }
 
 
-void GuiCitation::setPostTexts(vector<docstring> const m)
+void GuiCitation::setPostTexts(vector<docstring> const & m)
 {
        // account for multiple use of the same keys
        QList<QModelIndex> handled;

diff --git a/src/frontends/qt/GuiCitation.h b/src/frontends/qt/GuiCitation.h
index 428ea50a97de293a584d5e3f13dd4eafade126d2..d3a23b587c815fcd2a5827b0c83c6d3e904017fa 100644 (file)
--- a/src/frontends/qt/GuiCitation.h
+++ b/src/frontends/qt/GuiCitation.h
@@ -121,11 +121,11 @@ private:
        /// Get selected keys
        QStringList selectedKeys();
        /// Set pre texts of qualified lists
-       void setPreTexts(std::vector<docstring> const m);
+       void setPreTexts(std::vector<docstring> const & m);
        /// Get pre texts of qualified lists
        std::vector<docstring> getPreTexts();
        /// Set post texts of qualified lists
-       void setPostTexts(std::vector<docstring> const m);
+       void setPostTexts(std::vector<docstring> const & m);
        /// Get post texts of qualified lists
        std::vector<docstring> getPostTexts();