]> git.lyx.org Git - features.git/commitdiff
Add commented-out code that might prove useful one day
authorJean-Marc Lasgouttes <lasgouttes@lyx.org>
Mon, 20 Feb 2023 13:51:19 +0000 (14:51 +0100)
committerJean-Marc Lasgouttes <lasgouttes@lyx.org>
Mon, 20 Feb 2023 13:53:07 +0000 (14:53 +0100)
The code in the dead branch looks reasonable to me, but I was not able
to prove that it solves a problem (yet).

src/Row.cpp

index 361ef968cca2d4c06f799a40484f4d6c7c5c3995..102b1ea4ae9df206947a3d8fea66037cd7879c65 100644 (file)
@@ -189,8 +189,20 @@ bool Row::Element::splitAt(int const width, int next_width, bool force,
                // first_e row should be broken after the original element
                first_e.row_flags |= BreakAfter;
        } else {
-               // Restore the after flags of the original element.
+#if 1
+               // remove the BreakAfter that got added above.
                first_e.row_flags &= ~BreakAfter;
+#else
+               // FIXME : the code below looks like a good idea, but I do not
+               //         have a use case yet. The question is what happens
+               //         when breaking at the end of a string with a
+               //         trailing space.
+               // if it turns out that no breaking was necessary, remove the
+               // BreakAfter that got added above.
+               if (first_e.dim.wid <= width)
+                       first_e.row_flags &= ~BreakAfter;
+#endif
+               // Restore the after flags of the original element.
                first_e.row_flags |= row_flags & AfterFlags;
        }