Make some constructors explicit

Spotted by cppcheck.

diff --git a/src/insets/ExternalTemplate.cpp b/src/insets/ExternalTemplate.cpp
index ae9148b4e859a4fe8aba5e3e4ca0188f059ea995..ba6922d123cfc04434596cfd6c5e9535acde6c48 100644 (file)
--- a/src/insets/ExternalTemplate.cpp
+++ b/src/insets/ExternalTemplate.cpp
@@ -74,7 +74,7 @@ class DumpPreambleDef {
 public:
        typedef TemplateManager::PreambleDefs::value_type value_type;
 
-       DumpPreambleDef(ostream & os) : os_(os) {}
+       explicit DumpPreambleDef(ostream & os) : os_(os) {}
 
        void operator()(value_type const & vt) {
                os_ << "PreambleDef " << vt.first << '\n'
@@ -91,7 +91,7 @@ class DumpTemplate {
 public:
        typedef TemplateManager::Templates::value_type value_type;
 
-       DumpTemplate(ostream & os) : os_(os) {}
+       explicit DumpTemplate(ostream & os) : os_(os) {}
 
        void operator()(value_type const & vt) {
                Template const & et = vt.second;
@@ -137,7 +137,7 @@ class DumpFormat {
 public:
        typedef Template::Formats::value_type value_type;
 
-       DumpFormat(ostream & o) : os_(o) {}
+       explicit DumpFormat(ostream & o) : os_(o) {}
 
        void operator()(value_type const & vt) const {
                Template::Format const & ft = vt.second;

diff --git a/src/insets/ExternalTransforms.h b/src/insets/ExternalTransforms.h
index cd3e5e226a0e1354d66de3709597ad2f86ed43c6..d6735b60b5cbf1a7165155ad6eb520ea8e7f97d4 100644 (file)
--- a/src/insets/ExternalTransforms.h
+++ b/src/insets/ExternalTransforms.h
@@ -149,7 +149,7 @@ private:
 class ResizeCommand : public TransformCommand {
 protected:
        ResizeData data;
-       ResizeCommand(ResizeData const & data_) : data(data_) {}
+       explicit ResizeCommand(ResizeData const & data_) : data(data_) {}
 
 private:
        virtual std::string const front_placeholder_impl() const
@@ -165,7 +165,7 @@ public:
                { return ptr_type(new ResizeLatexCommand(data)); }
 
 private:
-       ResizeLatexCommand(ResizeData const & data_)
+       explicit ResizeLatexCommand(ResizeData const & data_)
                : ResizeCommand(data_) {}
        virtual std::string const front_impl() const;
        virtual std::string const back_impl() const;
@@ -175,7 +175,7 @@ private:
 class RotationCommand : public TransformCommand {
 protected:
        RotationData data;
-       RotationCommand(RotationData const & data_) : data(data_) {}
+       explicit RotationCommand(RotationData const & data_) : data(data_) {}
 
 private:
        virtual std::string const front_placeholder_impl() const
@@ -191,7 +191,7 @@ public:
                { return ptr_type(new RotationLatexCommand(data)); }
 
 private:
-       RotationLatexCommand(RotationData const & data_)
+       explicit RotationLatexCommand(RotationData const & data_)
                : RotationCommand(data_) {}
        virtual std::string const front_impl() const;
        virtual std::string const back_impl() const;
@@ -221,7 +221,7 @@ private:
 class ClipOption : public TransformOption {
 protected:
        ClipData data;
-       ClipOption(ClipData const & data_) : data(data_) {}
+       explicit ClipOption(ClipData const & data_) : data(data_) {}
 
 private:
        virtual std::string const placeholder_impl() const
@@ -235,7 +235,7 @@ public:
                { return ptr_type(new ClipLatexOption(data)); }
 
 private:
-       ClipLatexOption(ClipData const & data_)
+       explicit ClipLatexOption(ClipData const & data_)
                : ClipOption(data_) {}
        virtual std::string const option_impl() const;
 };
@@ -247,7 +247,7 @@ public:
                { return ptr_type(new ExtraOption(data)); }
 
 private:
-       ExtraOption(std::string const & data_) : data(data_) {}
+       explicit ExtraOption(std::string const & data_) : data(data_) {}
 
        virtual std::string const placeholder_impl() const
                { return "$$Extra"; }
@@ -260,7 +260,7 @@ private:
 class ResizeOption : public TransformOption {
 protected:
        ResizeData data;
-       ResizeOption(ResizeData const & data_) : data(data_) {}
+       explicit ResizeOption(ResizeData const & data_) : data(data_) {}
 
 private:
        virtual std::string const placeholder_impl() const
@@ -274,7 +274,7 @@ public:
                { return ptr_type(new ResizeLatexOption(data)); }
 
 private:
-       ResizeLatexOption(ResizeData const & data_)
+       explicit ResizeLatexOption(ResizeData const & data_)
                : ResizeOption(data_) {}
        virtual std::string const option_impl() const;
 };
@@ -283,7 +283,7 @@ private:
 class RotationOption : public TransformOption {
 protected:
        RotationData data;
-       RotationOption(RotationData const & data_) : data(data_) {}
+       explicit RotationOption(RotationData const & data_) : data(data_) {}
 
 private:
        virtual std::string const placeholder_impl() const
@@ -297,7 +297,7 @@ public:
                { return ptr_type(new RotationLatexOption(data)); }
 
 private:
-       RotationLatexOption(RotationData const & data_)
+       explicit RotationLatexOption(RotationData const & data_)
                : RotationOption(data_) {}
        virtual std::string const option_impl() const;
 };

diff --git a/src/insets/InsetBox.h b/src/insets/InsetBox.h
index e181bd738a229df472781879f480e84849727c7f..6dd671c9a4deaad01b8e0c1d7dc685a4b9e03c5f 100644 (file)
--- a/src/insets/InsetBox.h
+++ b/src/insets/InsetBox.h
@@ -24,7 +24,7 @@ class InsetBoxParams
 {
 public:
        ///
-       InsetBoxParams(std::string const &);
+       explicit InsetBoxParams(std::string const &);
        ///
        void write(std::ostream & os) const;
        ///

diff --git a/src/insets/InsetExternal.h b/src/insets/InsetExternal.h
index 032b3a2f8c45c75639c48294da10b2f7b273f44e..20ccfededf32a0fcd368553450a9beb9f02b0ad9 100644 (file)
--- a/src/insets/InsetExternal.h
+++ b/src/insets/InsetExternal.h
@@ -94,7 +94,7 @@ class InsetExternal : public Inset
        // complicated to implement it consistently with the copy constructor
        InsetExternal & operator=(InsetExternal const &);
 public:
-       InsetExternal(Buffer *);
+       explicit InsetExternal(Buffer *);
        ///
        ~InsetExternal();
        ///

diff --git a/src/insets/InsetFloatList.h b/src/insets/InsetFloatList.h
index 3d6a7a356905d0f7530fc5bd2c5e60bfae198924..7d1df4765aa015fa1a4dda8d02aef84744078016 100644 (file)
--- a/src/insets/InsetFloatList.h
+++ b/src/insets/InsetFloatList.h
@@ -23,7 +23,7 @@ namespace lyx {
 class InsetFloatList : public InsetCommand {
 public:
        ///
-       InsetFloatList(Buffer *);
+       explicit InsetFloatList(Buffer *);
        ///
        InsetFloatList(Buffer *, std::string const & type);
 

diff --git a/src/insets/InsetFoot.h b/src/insets/InsetFoot.h
index d032e04848fc7d38c817dfd15feb23136849cc81..04e03fde7b0fd0fc57fec11171e30dd26fd2f9e3 100644 (file)
--- a/src/insets/InsetFoot.h
+++ b/src/insets/InsetFoot.h
@@ -25,7 +25,7 @@ class InsetFoot : public InsetFootlike
 {
 public:
        ///
-       InsetFoot(Buffer *);
+       explicit InsetFoot(Buffer *);
 private:
        ///
        InsetCode lyxCode() const { return FOOT_CODE; }

diff --git a/src/insets/InsetFootlike.h b/src/insets/InsetFootlike.h
index f4bcbdef19445eef05d42ee074a8dbb211cc4410..ce6f5045ce872ea9ec173348d6a5716d63cfff1c 100644 (file)
--- a/src/insets/InsetFootlike.h
+++ b/src/insets/InsetFootlike.h
@@ -23,7 +23,7 @@ namespace lyx {
 class InsetFootlike : public InsetCollapsible {
 public:
        ///
-       InsetFootlike(Buffer *);
+       explicit InsetFootlike(Buffer *);
        ///
        bool hasSettings() const { return false; }
 private:

diff --git a/src/insets/InsetGraphics.h b/src/insets/InsetGraphics.h
index 2cba4f05fa3f47a13e80c170733a39ef0b4832a8..b5fc5c830d892e88f08645c3d9d1088bd5bbfdb5 100644 (file)
--- a/src/insets/InsetGraphics.h
+++ b/src/insets/InsetGraphics.h
@@ -34,7 +34,7 @@ class InsetGraphics : public Inset
 {
 public:
        ///
-       InsetGraphics(Buffer * buf);
+       explicit InsetGraphics(Buffer * buf);
        ///
        ~InsetGraphics();
 

diff --git a/src/insets/InsetIPA.h b/src/insets/InsetIPA.h
index fe8cd992522ca0266e4a3dfcf2511be55b741c9d..d499edfdc81ccfe7ad07d222d763092b03fa8105 100644 (file)
--- a/src/insets/InsetIPA.h
+++ b/src/insets/InsetIPA.h
@@ -32,7 +32,7 @@ class InsetIPA : public InsetText {
 
 public:
        ///
-       InsetIPA(Buffer *);
+       explicit InsetIPA(Buffer *);
        ///
        ~InsetIPA();
        ///

diff --git a/src/insets/InsetMarginal.h b/src/insets/InsetMarginal.h
index 008a3dd039fae9c64a622ca8eb879edd15d2a181..db0f6db0239d15cdf9543f29088a916dc77a1563 100644 (file)
--- a/src/insets/InsetMarginal.h
+++ b/src/insets/InsetMarginal.h
@@ -25,7 +25,7 @@ namespace lyx {
 class InsetMarginal : public InsetFootlike {
 public:
        ///
-       InsetMarginal(Buffer *);
+       explicit InsetMarginal(Buffer *);
        ///
        InsetCode lyxCode() const { return MARGIN_CODE; }
        ///

diff --git a/src/insets/InsetNewline.h b/src/insets/InsetNewline.h
index 53389d237000366266f53d93925d5002381c9de2..e0a13f38d415172d62f489973b5f5d9732058ece 100644 (file)
--- a/src/insets/InsetNewline.h
+++ b/src/insets/InsetNewline.h
@@ -44,7 +44,7 @@ public:
        ///
        InsetNewline();
        ///
-       InsetNewline(InsetNewlineParams par) : Inset(0)
+       explicit InsetNewline(InsetNewlineParams par) : Inset(0)
        { params_.kind = par.kind; }
        ///
        static void string2params(std::string const &, InsetNewlineParams &);

diff --git a/src/insets/InsetPreview.h b/src/insets/InsetPreview.h
index f0808d7246733fdc54352eb7b25ce6f51d3af46e..6a9d29043c4e9d678b498a39a8b83441cda33f11 100644 (file)
--- a/src/insets/InsetPreview.h
+++ b/src/insets/InsetPreview.h
@@ -32,7 +32,7 @@ class InsetPreview : public InsetText {
 
 public:
        ///
-       InsetPreview(Buffer *);
+       explicit InsetPreview(Buffer *);
        ///
        ~InsetPreview();
        ///

diff --git a/src/insets/InsetSpace.h b/src/insets/InsetSpace.h
index a4fd6151f90a458c9a8429573e6d0cdc735f03a1..2784022955b6e80adfe84234ced1eec780394325 100644 (file)
--- a/src/insets/InsetSpace.h
+++ b/src/insets/InsetSpace.h
@@ -74,7 +74,7 @@ struct InsetSpaceParams {
                CUSTOM_PROTECTED
        };
        ///
-       InsetSpaceParams(bool m = false) : kind(NORMAL), math(m) {}
+       explicit InsetSpaceParams(bool m = false) : kind(NORMAL), math(m) {}
        ///
        void write(std::ostream & os) const;
        ///

diff --git a/src/insets/InsetTabular.h b/src/insets/InsetTabular.h
index 17e05d75ddc4270e22fc18788d27e6800c15b73a..65cc2ae2e1d118999afa4ae5d07cd0af27b0dbdf 100644 (file)
--- a/src/insets/InsetTabular.h
+++ b/src/insets/InsetTabular.h
@@ -52,7 +52,7 @@ class InsetTableCell : public InsetText
 {
 public:
        ///
-       InsetTableCell(Buffer * buf);
+       explicit InsetTableCell(Buffer * buf);
        ///
        InsetCode lyxCode() const { return CELL_CODE; }
        ///
@@ -690,7 +690,7 @@ public:
        class CellData {
        public:
                ///
-               CellData(Buffer *);
+               explicit CellData(Buffer *);
                ///
                CellData(CellData const &);
                ///

diff --git a/src/insets/InsetVSpace.h b/src/insets/InsetVSpace.h
index 21afbcd03605392a1f999bf0e46fc4a9c656d570..b2c8ac9780bb799af576770e4ece9bff7fdc3dc9 100644 (file)
--- a/src/insets/InsetVSpace.h
+++ b/src/insets/InsetVSpace.h
@@ -24,7 +24,7 @@ public:
        ///
        InsetVSpace() : Inset(0) {}
        ///
-       InsetVSpace(VSpace const &);
+       explicit InsetVSpace(VSpace const &);
        /// How much?
        VSpace const & space() const { return space_; }
        ///

diff --git a/src/insets/RenderGraphic.h b/src/insets/RenderGraphic.h
index b41b82e61aa1c33753dd18e29d0cb34b2dadecab..da09c4cc0faefe0f6229b09efbfed4b136bf099d 100644 (file)
--- a/src/insets/RenderGraphic.h
+++ b/src/insets/RenderGraphic.h
@@ -24,7 +24,7 @@ namespace lyx {
 class RenderGraphic : public RenderBase
 {
 public:
-       RenderGraphic(Inset const *);
+       explicit RenderGraphic(Inset const *);
        RenderGraphic(RenderGraphic const &, Inset const *);
        RenderBase * clone(Inset const *) const;
 

diff --git a/src/insets/RenderPreview.h b/src/insets/RenderPreview.h
index 2f83aff5dc17d2eea2b03dd4777d2ca9a33d9145..c6eee309d07016900ba0288f1e7084ed1b9757a6 100644 (file)
--- a/src/insets/RenderPreview.h
+++ b/src/insets/RenderPreview.h
@@ -45,7 +45,7 @@ public:
        /// Return true if preview is enabled in mathed (from LyXRC::preview)
        static bool previewMath();
 
-       RenderPreview(Inset const *);
+       explicit RenderPreview(Inset const *);
        RenderPreview(RenderPreview const &, Inset const *);
        RenderBase * clone(Inset const *) const;
 
@@ -110,7 +110,7 @@ private:
 
 class RenderMonitoredPreview : public RenderPreview {
 public:
-       RenderMonitoredPreview(Inset const *);
+       explicit RenderMonitoredPreview(Inset const *);
        ///
        void draw(PainterInfo & pi, int x, int y) const;
        ///