]> git.lyx.org Git - features.git/commitdiff
Remove some xforms cruft from BufferView.h BufferView_pimpl.h.
authorAngus Leeming <leeming@lyx.org>
Tue, 3 Apr 2001 14:30:58 +0000 (14:30 +0000)
committerAngus Leeming <leeming@lyx.org>
Tue, 3 Apr 2001 14:30:58 +0000 (14:30 +0000)
John's name-changing patch.

git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@1878 a592a061-630c-0410-9148-cb99ea01b6c8

89 files changed:
src/BufferView.h
src/BufferView_pimpl.h
src/ChangeLog
src/frontends/ChangeLog
src/frontends/Dialogs.h
src/frontends/controllers/ButtonController.h
src/frontends/controllers/ButtonControllerBase.C
src/frontends/controllers/ButtonControllerBase.h
src/frontends/controllers/ButtonPolicies.C
src/frontends/controllers/ButtonPolicies.h
src/frontends/controllers/ChangeLog
src/frontends/controllers/ControlButton.C [deleted file]
src/frontends/controllers/ControlButton.h [deleted file]
src/frontends/controllers/ControlButtons.C [new file with mode: 0644]
src/frontends/controllers/ControlButtons.h [new file with mode: 0644]
src/frontends/controllers/ControlCitation.C
src/frontends/controllers/ControlCitation.h
src/frontends/controllers/ControlConnections.h
src/frontends/controllers/ControlDialogs.h
src/frontends/controllers/ControlExternal.C
src/frontends/controllers/ControlInset.h
src/frontends/controllers/ControlToc.C
src/frontends/controllers/ControlVCLog.C
src/frontends/controllers/Makefile.am
src/frontends/controllers/README
src/frontends/controllers/ViewBase.h
src/frontends/gnome/ChangeLog
src/frontends/gnome/Dialogs.C
src/frontends/gnome/FormUrl.C
src/frontends/gnome/GnomeBase.C
src/frontends/gnome/GnomeBase.h
src/frontends/qt2/ChangeLog
src/frontends/qt2/Dialogs.C
src/frontends/qt2/FormCharacter.C
src/frontends/qt2/FormCitation.C
src/frontends/qt2/FormDocument.C
src/frontends/qt2/FormDocument.h
src/frontends/qt2/FormSearch.C
src/frontends/qt2/Qt2Base.C
src/frontends/qt2/Qt2Base.h
src/frontends/qt2/qt2BC.C
src/frontends/qt2/qt2BC.h
src/frontends/xforms/ChangeLog
src/frontends/xforms/Dialogs.C
src/frontends/xforms/FormBase.C
src/frontends/xforms/FormBase.h
src/frontends/xforms/FormBaseDeprecated.C
src/frontends/xforms/FormBibitem.C
src/frontends/xforms/FormBibtex.C
src/frontends/xforms/FormBrowser.C
src/frontends/xforms/FormBrowser.h
src/frontends/xforms/FormCharacter.C
src/frontends/xforms/FormCharacter.h
src/frontends/xforms/FormCitation.C
src/frontends/xforms/FormCopyright.C
src/frontends/xforms/FormCredits.C
src/frontends/xforms/FormDocument.C
src/frontends/xforms/FormDocument.h
src/frontends/xforms/FormError.C
src/frontends/xforms/FormExternal.C
src/frontends/xforms/FormGraphics.C
src/frontends/xforms/FormInclude.C
src/frontends/xforms/FormIndex.C
src/frontends/xforms/FormMathsBitmap.C
src/frontends/xforms/FormMathsBitmap.h
src/frontends/xforms/FormMathsDeco.C
src/frontends/xforms/FormMathsDeco.h
src/frontends/xforms/FormMathsDelim.C
src/frontends/xforms/FormMathsDelim.h
src/frontends/xforms/FormMathsMatrix.C
src/frontends/xforms/FormMathsMatrix.h
src/frontends/xforms/FormMathsPanel.C
src/frontends/xforms/FormMathsPanel.h
src/frontends/xforms/FormMathsSpace.C
src/frontends/xforms/FormMathsSpace.h
src/frontends/xforms/FormMinipage.C
src/frontends/xforms/FormParagraph.C
src/frontends/xforms/FormParagraph.h
src/frontends/xforms/FormPreamble.C
src/frontends/xforms/FormPreamble.h
src/frontends/xforms/FormPreferences.C
src/frontends/xforms/FormPrint.C
src/frontends/xforms/FormRef.C
src/frontends/xforms/FormSearch.C
src/frontends/xforms/FormTabularCreate.C
src/frontends/xforms/FormToc.C
src/frontends/xforms/FormUrl.C
src/frontends/xforms/input_validators.C
src/frontends/xforms/input_validators.h

index 56cafa50c62cc0ced9f1d71d74fd92e0a7e64d0e..871ecd051896f7ed8dddf15ce83929b17efc7913 100644 (file)
@@ -16,7 +16,6 @@
 #pragma interface
 #endif
 
-#include FORMS_H_LOCATION
 #include "LString.h"
 #include "undo.h"
 #include "commandtags.h"
index e7a9c8ba750b0108d3bd656c8ba707e28131b513..4ae5f7f6cae63dde495db91f31d169835846f3b6 100644 (file)
@@ -134,8 +134,6 @@ private:
        ///
        long current_scrollbar_value;
        ///
-       FL_OBJECT * figinset_canvas;
-       ///
        Timeout cursor_timeout;
         ///
        int last_click_x;
index 39c1f51212b09652843bdff8e5e4fa7a1e2811b4..e481e95fa57fad855ccb7fc063d62f5526120314 100644 (file)
@@ -1,3 +1,9 @@
+2001-04-03  Angus Leeming  <a.leeming@ic.ac.uk>
+
+       * BufferView.h: 
+       * BufferView_pimpl.h: remove xforms cruft. Both classes are
+       independent of xforms.
+
 2001-04-02  Juergen Vigna  <jug@sad.it>
 
        * spellchecker.C: fixed namespace placing!
index 942fd02a2c45764a7912b6c4a6348cd2612fbbee..eb811a10c0803874ff7cc59fd15da84201412c2e 100644 (file)
@@ -1,3 +1,7 @@
+2001-04-03  John Levon  <moz@compsoc.man.ac.uk>
+
+       * Dialogs.h: s/popup/dialog/
+
 2001-03-22  Jean-Marc Lasgouttes  <Jean-Marc.Lasgouttes@inria.fr>
 
        * Liason.C (printBuffer): do not forget file name
index 28db300368ee22abf7c72da19a5a41548b3b6e6a..a183a20657134dd8ca0131cd90866b0225c27536 100644 (file)
@@ -61,13 +61,13 @@ public:
        Dialogs(LyXView *);
        //@}
 
-       /** Redraw all visible popups because, for example, the GUI colours
+       /** Redraw all visible dialogs because, for example, the GUI colours
            have been re-mapped. */
        static SigC::Signal0<void> redrawGUI;
 
        /**@name Global Hide and Update Signals */
        //@{
-       /// Hide all visible popups
+       /// Hide all visible dialogs
        SigC::Signal0<void> hideAll;
        
        /// Hide any dialogs that require a buffer for them to operate
index ed18f63cbf9f3ea13f87147dfe3c3173e198b0c6..d79733183c38c9f45aef241ecd62a0542dcfa4aa 100644 (file)
@@ -32,7 +32,7 @@ public:
        /// 
        void setCancel(Button * obj) { cancel_ = obj; }
        ///
-       void setUndoAll(Button * obj) { undo_all_ = obj; }
+       void setRestore(Button * obj) { restore_ = obj; }
        ///
        void addReadOnly(Widget * obj) { read_only_.push_back(obj); }
        ///
@@ -51,8 +51,8 @@ private:
 
        Button * okay_;
        Button * apply_;
-       Button * undo_all_;
        Button * cancel_;
+       Button * restore_;
        
        typedef std::list<Widget *> Widgets;
        Widgets read_only_;
@@ -62,7 +62,7 @@ private:
 template <class Button, class Widget>
 GuiBC<Button, Widget>::GuiBC(string const & cancel, string const & close)
        : ButtonControllerBase(cancel, close)
-       , okay_(0), apply_(0), cancel_(0), undo_all_(0)
+       , okay_(0), apply_(0), restore_(0), cancel_(0)
 {}
 
 
@@ -77,9 +77,9 @@ void GuiBC<Button, Widget>::refresh()
                bool const enabled = bp().buttonStatus(ButtonPolicy::APPLY);
                setButtonEnabled(apply_, enabled);
        }
-       if (undo_all_) {
-               bool const enabled = bp().buttonStatus(ButtonPolicy::UNDO_ALL);
-               setButtonEnabled(undo_all_, enabled);
+       if (restore_) {
+               bool const enabled = bp().buttonStatus(ButtonPolicy::RESTORE);
+               setButtonEnabled(restore_, enabled);
        }
        if (cancel_) {
                bool const enabled = bp().buttonStatus(ButtonPolicy::CANCEL);
index f446d785c55b7d9747e974cccfc913cd3b34c3fe..ecd9f2dd7d068ae4edd506f0c9d48d2f66888af5 100644 (file)
@@ -53,9 +53,9 @@ void ButtonControllerBase::cancel()
 }
 
 
-void ButtonControllerBase::undoAll()
+void ButtonControllerBase::restore()
 {
-       input(ButtonPolicy::SMI_UNDO_ALL);
+       input(ButtonPolicy::SMI_RESTORE);
 }
 
 
index e395047bd2837972100c1f7b7c9533fbdd66baaa..d82098ab2da5d396a6e78c63d54075771563fd7a 100644 (file)
@@ -56,7 +56,7 @@ public:
        ///
        void cancel();
        ///
-       void undoAll();
+       void restore();
        ///
        void hide();
        ///
index fc18daa2a398c2cc2197e6ae2035b2c17e54ab26..bb1ffe631cf3c7a87277ecb9ee9f597808d9b2e3 100644 (file)
@@ -61,8 +61,8 @@ PreferencesPolicy::PreferencesPolicy()
 {
        // Build the state output map
        outputs_[INITIAL] = CLOSE;
-       outputs_[VALID] = UNDO_ALL | OKAY | APPLY | CANCEL;
-       outputs_[INVALID] = UNDO_ALL | CANCEL;
+       outputs_[VALID] = RESTORE | OKAY | APPLY | CANCEL;
+       outputs_[INVALID] = RESTORE | CANCEL;
        outputs_[APPLIED] = OKAY | CLOSE;
 
        // Build the state machine one state at a time
@@ -87,13 +87,13 @@ PreferencesPolicy::PreferencesPolicy()
        state_machine_[VALID][SMI_INVALID] = INVALID;
        state_machine_[VALID][SMI_APPLY] = APPLIED;
        state_machine_[VALID][SMI_OKAY] = INITIAL;
-       state_machine_[VALID][SMI_UNDO_ALL] = INITIAL;
+       state_machine_[VALID][SMI_RESTORE] = INITIAL;
        // State::INVALID
        state_machine_[INVALID][SMI_VALID] = VALID;
        state_machine_[INVALID][SMI_INVALID] = INVALID;
        state_machine_[INVALID][SMI_READ_ONLY] = INVALID;
        state_machine_[INVALID][SMI_READ_WRITE] = INVALID;
-       state_machine_[INVALID][SMI_UNDO_ALL] = INITIAL;
+       state_machine_[INVALID][SMI_RESTORE] = INITIAL;
        // State::APPLIED
        state_machine_[APPLIED][SMI_VALID] = VALID;
        state_machine_[APPLIED][SMI_INVALID] = INVALID;
@@ -135,8 +135,8 @@ OkCancelPolicy::OkCancelPolicy()
 {
        // Build the state output map
        outputs_[INITIAL] = CLOSE;
-       outputs_[VALID] = UNDO_ALL | OKAY | CANCEL;
-       outputs_[INVALID] = UNDO_ALL | CANCEL;
+       outputs_[VALID] = RESTORE | OKAY | CANCEL;
+       outputs_[INVALID] = RESTORE | CANCEL;
 
        // Build the state machine one state at a time
        // NOTE:  Since CANCEL and HIDE always go to INITIAL they are
@@ -154,13 +154,13 @@ OkCancelPolicy::OkCancelPolicy()
        state_machine_[VALID][SMI_READ_WRITE] = VALID;
        state_machine_[VALID][SMI_INVALID] = INVALID;
        state_machine_[VALID][SMI_OKAY] = INITIAL;
-       state_machine_[VALID][SMI_UNDO_ALL] = INITIAL;
+       state_machine_[VALID][SMI_RESTORE] = INITIAL;
        // State::INVALID
        state_machine_[INVALID][SMI_VALID] = VALID;
        state_machine_[INVALID][SMI_INVALID] = INVALID;
        state_machine_[INVALID][SMI_READ_ONLY] = INVALID;
        state_machine_[INVALID][SMI_READ_WRITE] = INVALID;
-       state_machine_[INVALID][SMI_UNDO_ALL] = INITIAL;
+       state_machine_[INVALID][SMI_RESTORE] = INITIAL;
 }
 
 
@@ -190,11 +190,11 @@ OkCancelReadOnlyPolicy::OkCancelReadOnlyPolicy()
 {
        // Build the state output map
        outputs_[INITIAL] = CLOSE;
-       outputs_[VALID] = UNDO_ALL | OKAY | CANCEL;
-       outputs_[INVALID] = UNDO_ALL | CANCEL;
+       outputs_[VALID] = RESTORE | OKAY | CANCEL;
+       outputs_[INVALID] = RESTORE | CANCEL;
        outputs_[RO_INITIAL] = CLOSE;
-       outputs_[RO_VALID] = UNDO_ALL | CANCEL;
-       outputs_[RO_INVALID] = UNDO_ALL | CANCEL;
+       outputs_[RO_VALID] = RESTORE | CANCEL;
+       outputs_[RO_INVALID] = RESTORE | CANCEL;
 
        // Build the state machine one state at a time
        // NOTE:  Since CANCEL and HIDE always go to INITIAL they are
@@ -211,13 +211,13 @@ OkCancelReadOnlyPolicy::OkCancelReadOnlyPolicy()
        state_machine_[VALID][SMI_READ_WRITE] = VALID;
        state_machine_[VALID][SMI_INVALID] = INVALID;
        state_machine_[VALID][SMI_OKAY] = INITIAL;
-       state_machine_[VALID][SMI_UNDO_ALL] = INITIAL;
+       state_machine_[VALID][SMI_RESTORE] = INITIAL;
        state_machine_[VALID][SMI_READ_ONLY] = RO_VALID;
        // State::INVALID
        state_machine_[INVALID][SMI_INVALID] = INVALID;
        state_machine_[INVALID][SMI_READ_WRITE] = INVALID;
        state_machine_[INVALID][SMI_VALID] = VALID;
-       state_machine_[INVALID][SMI_UNDO_ALL] = INITIAL;
+       state_machine_[INVALID][SMI_RESTORE] = INITIAL;
        state_machine_[INVALID][SMI_READ_ONLY] = RO_INVALID;
        // State::RO_INITIAL
        state_machine_[RO_INITIAL][SMI_READ_ONLY] = RO_INITIAL;
@@ -229,13 +229,13 @@ OkCancelReadOnlyPolicy::OkCancelReadOnlyPolicy()
        state_machine_[RO_VALID][SMI_READ_ONLY] = RO_VALID;
        state_machine_[RO_VALID][SMI_INVALID] = RO_INVALID;
        state_machine_[RO_VALID][SMI_READ_WRITE] = VALID;
-       state_machine_[RO_VALID][SMI_UNDO_ALL] = RO_INITIAL;
+       state_machine_[RO_VALID][SMI_RESTORE] = RO_INITIAL;
        // State::RO_INVALID
        state_machine_[RO_INVALID][SMI_READ_ONLY] = RO_INVALID;
        state_machine_[RO_INVALID][SMI_INVALID] = RO_INVALID;
        state_machine_[RO_INVALID][SMI_VALID] = RO_VALID;
        state_machine_[RO_INVALID][SMI_READ_WRITE] = INVALID;
-       state_machine_[RO_INVALID][SMI_UNDO_ALL] = RO_INITIAL;
+       state_machine_[RO_INVALID][SMI_RESTORE] = RO_INITIAL;
 }
 
 
@@ -267,11 +267,11 @@ NoRepeatedApplyReadOnlyPolicy::NoRepeatedApplyReadOnlyPolicy()
 {
        // Build the state output map
        outputs_[INITIAL] = CLOSE;
-       outputs_[VALID] = UNDO_ALL | OKAY | APPLY | CANCEL;
-       outputs_[INVALID] = UNDO_ALL | CANCEL;
+       outputs_[VALID] = RESTORE | OKAY | APPLY | CANCEL;
+       outputs_[INVALID] = RESTORE | CANCEL;
        outputs_[RO_INITIAL] = CLOSE;
-       outputs_[RO_VALID] = UNDO_ALL | CANCEL;
-       outputs_[RO_INVALID] = UNDO_ALL | CANCEL;
+       outputs_[RO_VALID] = RESTORE | CANCEL;
+       outputs_[RO_INVALID] = RESTORE | CANCEL;
 
        // Build the state machine one state at a time
        // NOTE:  Since CANCEL and HIDE always go to INITIAL they are
@@ -289,13 +289,13 @@ NoRepeatedApplyReadOnlyPolicy::NoRepeatedApplyReadOnlyPolicy()
        state_machine_[VALID][SMI_INVALID] = INVALID;
        state_machine_[VALID][SMI_OKAY] = INITIAL;
        state_machine_[VALID][SMI_APPLY] = INITIAL;
-       state_machine_[VALID][SMI_UNDO_ALL] = INITIAL;
+       state_machine_[VALID][SMI_RESTORE] = INITIAL;
        state_machine_[VALID][SMI_READ_ONLY] = RO_VALID;
        // State::INVALID
        state_machine_[INVALID][SMI_INVALID] = INVALID;
        state_machine_[INVALID][SMI_READ_WRITE] = INVALID;
        state_machine_[INVALID][SMI_VALID] = VALID;
-       state_machine_[INVALID][SMI_UNDO_ALL] = INITIAL;
+       state_machine_[INVALID][SMI_RESTORE] = INITIAL;
        state_machine_[INVALID][SMI_READ_ONLY] = RO_INVALID;
        // State::RO_INITIAL
        state_machine_[RO_INITIAL][SMI_READ_ONLY] = RO_INITIAL;
@@ -307,13 +307,13 @@ NoRepeatedApplyReadOnlyPolicy::NoRepeatedApplyReadOnlyPolicy()
        state_machine_[RO_VALID][SMI_READ_ONLY] = RO_VALID;
        state_machine_[RO_VALID][SMI_INVALID] = RO_INVALID;
        state_machine_[RO_VALID][SMI_READ_WRITE] = VALID;
-       state_machine_[RO_VALID][SMI_UNDO_ALL] = RO_INITIAL;
+       state_machine_[RO_VALID][SMI_RESTORE] = RO_INITIAL;
        // State::RO_INVALID
        state_machine_[RO_INVALID][SMI_INVALID] = RO_INVALID;
        state_machine_[RO_INVALID][SMI_READ_ONLY] = RO_INVALID;
        state_machine_[RO_INVALID][SMI_VALID] = RO_VALID;
        state_machine_[RO_INVALID][SMI_READ_WRITE] = INVALID;
-       state_machine_[RO_INVALID][SMI_UNDO_ALL] = RO_INITIAL;
+       state_machine_[RO_INVALID][SMI_RESTORE] = RO_INITIAL;
 }
 
 
@@ -345,12 +345,12 @@ OkApplyCancelReadOnlyPolicy::OkApplyCancelReadOnlyPolicy()
 {
        // Build the state output map
        outputs_[INITIAL] = CLOSE;
-       outputs_[VALID] = UNDO_ALL | OKAY | APPLY | CANCEL;
-       outputs_[INVALID] = UNDO_ALL | CANCEL;
+       outputs_[VALID] = RESTORE | OKAY | APPLY | CANCEL;
+       outputs_[INVALID] = RESTORE | CANCEL;
        outputs_[APPLIED] = OKAY | APPLY | CLOSE;
        outputs_[RO_INITIAL] = CLOSE;
-       outputs_[RO_VALID] = UNDO_ALL | CANCEL;
-       outputs_[RO_INVALID] = UNDO_ALL | CANCEL;
+       outputs_[RO_VALID] = RESTORE | CANCEL;
+       outputs_[RO_INVALID] = RESTORE | CANCEL;
        outputs_[RO_APPLIED] = CLOSE;
 
        // Build the state machine one state at a time
@@ -368,14 +368,14 @@ OkApplyCancelReadOnlyPolicy::OkApplyCancelReadOnlyPolicy()
        state_machine_[VALID][SMI_READ_WRITE] = VALID;
        state_machine_[VALID][SMI_INVALID] = INVALID;
        state_machine_[VALID][SMI_OKAY] = INITIAL;
-       state_machine_[VALID][SMI_UNDO_ALL] = INITIAL;
+       state_machine_[VALID][SMI_RESTORE] = INITIAL;
        state_machine_[VALID][SMI_APPLY] = APPLIED;
        state_machine_[VALID][SMI_READ_ONLY] = RO_VALID;
        // State::INVALID
        state_machine_[INVALID][SMI_INVALID] = INVALID;
        state_machine_[INVALID][SMI_READ_WRITE] = INVALID;
        state_machine_[INVALID][SMI_VALID] = VALID;
-       state_machine_[INVALID][SMI_UNDO_ALL] = INITIAL;
+       state_machine_[INVALID][SMI_RESTORE] = INITIAL;
        state_machine_[INVALID][SMI_READ_ONLY] = RO_INVALID;
        // State::APPLIED
        state_machine_[APPLIED][SMI_APPLY] = APPLIED;
@@ -394,13 +394,13 @@ OkApplyCancelReadOnlyPolicy::OkApplyCancelReadOnlyPolicy()
        state_machine_[RO_VALID][SMI_READ_ONLY] = RO_VALID;
        state_machine_[RO_VALID][SMI_INVALID] = RO_INVALID;
        state_machine_[RO_VALID][SMI_READ_WRITE] = VALID;
-       state_machine_[RO_VALID][SMI_UNDO_ALL] = RO_INITIAL;
+       state_machine_[RO_VALID][SMI_RESTORE] = RO_INITIAL;
        // State::RO_INVALID
        state_machine_[RO_INVALID][SMI_INVALID] = RO_INVALID;
        state_machine_[RO_INVALID][SMI_READ_ONLY] = RO_INVALID;
        state_machine_[RO_INVALID][SMI_VALID] = RO_VALID;
        state_machine_[RO_INVALID][SMI_READ_WRITE] = INVALID;
-       state_machine_[RO_INVALID][SMI_UNDO_ALL] = RO_INITIAL;
+       state_machine_[RO_INVALID][SMI_RESTORE] = RO_INITIAL;
        // State::RO_APPLIED
        state_machine_[RO_APPLIED][SMI_READ_ONLY] = RO_APPLIED;
        state_machine_[RO_APPLIED][SMI_INVALID] = RO_INVALID;
@@ -437,8 +437,8 @@ OkApplyCancelPolicy::OkApplyCancelPolicy()
 {
        // Build the state output map
        outputs_[INITIAL] = CLOSE;
-       outputs_[VALID] = UNDO_ALL | OKAY | APPLY | CANCEL;
-       outputs_[INVALID] = UNDO_ALL | CANCEL;
+       outputs_[VALID] = RESTORE | OKAY | APPLY | CANCEL;
+       outputs_[INVALID] = RESTORE | CANCEL;
        outputs_[APPLIED] = OKAY | APPLY | CLOSE;
 
        // Build the state machine one state at a time
@@ -457,14 +457,14 @@ OkApplyCancelPolicy::OkApplyCancelPolicy()
        state_machine_[VALID][SMI_READ_WRITE] = VALID;
        state_machine_[VALID][SMI_INVALID] = INVALID;
        state_machine_[VALID][SMI_OKAY] = INITIAL;
-       state_machine_[VALID][SMI_UNDO_ALL] = INITIAL;
+       state_machine_[VALID][SMI_RESTORE] = INITIAL;
        state_machine_[VALID][SMI_APPLY] = APPLIED;
        // State::INVALID
        state_machine_[INVALID][SMI_INVALID] = INVALID;
        state_machine_[INVALID][SMI_READ_ONLY] = INVALID;
        state_machine_[INVALID][SMI_READ_WRITE] = INVALID;
        state_machine_[INVALID][SMI_VALID] = VALID;
-       state_machine_[INVALID][SMI_UNDO_ALL] = INITIAL;
+       state_machine_[INVALID][SMI_RESTORE] = INITIAL;
        // State::APPLIED
        state_machine_[APPLIED][SMI_APPLY] = APPLIED;
        state_machine_[APPLIED][SMI_READ_ONLY] = APPLIED;
@@ -503,8 +503,8 @@ NoRepeatedApplyPolicy::NoRepeatedApplyPolicy()
 {
        // Build the state output map
        outputs_[INITIAL] = CLOSE;
-       outputs_[VALID] = UNDO_ALL | OKAY | APPLY | CANCEL;
-       outputs_[INVALID] = UNDO_ALL | CANCEL;
+       outputs_[VALID] = RESTORE | OKAY | APPLY | CANCEL;
+       outputs_[INVALID] = RESTORE | CANCEL;
 
        // Build the state machine one state at a time
        // NOTE:  Since CANCEL and HIDE always go to INITIAL they are
@@ -523,13 +523,13 @@ NoRepeatedApplyPolicy::NoRepeatedApplyPolicy()
        state_machine_[VALID][SMI_INVALID] = INVALID;
        state_machine_[VALID][SMI_OKAY] = INITIAL;
        state_machine_[VALID][SMI_APPLY] = INITIAL;
-       state_machine_[VALID][SMI_UNDO_ALL] = INITIAL;
+       state_machine_[VALID][SMI_RESTORE] = INITIAL;
        // State::INVALID
        state_machine_[INVALID][SMI_INVALID] = INVALID;
        state_machine_[INVALID][SMI_READ_ONLY] = INVALID;
        state_machine_[INVALID][SMI_READ_WRITE] = INVALID;
        state_machine_[INVALID][SMI_VALID] = VALID;
-       state_machine_[INVALID][SMI_UNDO_ALL] = INITIAL;
+       state_machine_[INVALID][SMI_RESTORE] = INITIAL;
 }
 
 
index bf8a758374ff4235bc7e10d65e9f11797ad9cc16..09c739640d17462a03291f982cc0c4c41f75b414 100644 (file)
@@ -109,11 +109,11 @@ public:
                ///
                CANCEL   = 4,
                ///
-               UNDO_ALL = 8
+               RESTORE = 8
        };
        ///
        static const Button ALL_BUTTONS =
-               Button(OKAY | APPLY | CANCEL | UNDO_ALL);
+               Button(OKAY | APPLY | CANCEL | RESTORE);
   
        /** State machine inputs.
            All the policies so far have both CANCEL and HIDE always going to
@@ -124,28 +124,28 @@ public:
            HIDE are treated differently.
         */
        enum SMInput {
-               ///
+               /// the dialog contents are now valid
                SMI_VALID = 0,
-               ///
+               /// the dialog contents are now invalid
                SMI_INVALID,
-               ///
+               /// an apply-and-hide action has happened
                SMI_OKAY,
-               ///
+               /// an apply action has happened 
                SMI_APPLY,
-               ///
+               /// a cancel action has happened
                SMI_CANCEL,
-               ///
-               SMI_UNDO_ALL,
-               ///
+               /// a restore action has happened
+               SMI_RESTORE,
+               /// the dialog has been hidden
                SMI_HIDE,
-               ///
+               /// the dialog contents are read-only
                SMI_READ_ONLY,
-               ///
+               /// the dialog contents can be modified
                SMI_READ_WRITE,
-               ///
+               /// the state of the dialog contents has not changed 
                SMI_NOOP,
-               ///
-               SMI_TOTAL       // not a real input
+               /// for internal use
+               SMI_TOTAL
        };
 
        /// Trigger a transition with this input.
index 9d2c68d84963577182639d2e64ff2be6bfabf10e..294490a6d7969eca0b0249bf654f340324cfbb11 100644 (file)
@@ -1,3 +1,24 @@
+2001-04-03  John Levon  <moz@compsoc.man.ac.uk>
+
+       * ButtonController.h:
+       * ButtonControllerBase.h:
+       * ButtonControllerBase.C:
+       * ButtonPolicies.h:
+       * ButtonPolicies.C:
+       * ControlButton.h:
+       * ControlButton.C:
+       * ControlButtons.h:
+       * ControlButtons.C:
+       * ControlConnections.h:
+       * ControlDialogs.h:
+       * ControlInset.h:
+       * ControlExternal.C:
+       * Makefile.am:
+       * README:
+       * ViewBase.h: s/ControlButton/ControlButtons/
+       s/popup/dialog/
+       s/UndoAll/Restore/ + associated
+
 2001-03-30  Angus Leeming  <a.leeming@ic.ac.uk>
 
        * ControlToc.[Ch]: new files; a controller for the TOC popup.
diff --git a/src/frontends/controllers/ControlButton.C b/src/frontends/controllers/ControlButton.C
deleted file mode 100644 (file)
index 731c452..0000000
+++ /dev/null
@@ -1,49 +0,0 @@
-// -*- C++ -*-
-/* This file is part of
- * ====================================================== 
- *
- *           LyX, The Document Processor
- *
- *           Copyright 2001 The LyX Team.
- *
- * ======================================================
- *
- * \file ControlButton.C
- * \author Angus Leeming <a.leeming@ic.ac.uk>
- */
-
-#include <config.h>
-
-#ifdef __GNUG__
-#pragma implementation
-#endif
-
-#include "ControlButton.h"
-
-void ControlButton::ApplyButton()
-{
-       apply();
-       bc().apply();
-}
-
-
-void ControlButton::OKButton()
-{
-       apply();
-       hide();
-       bc().ok();
-}
-
-
-void ControlButton::CancelButton()
-{
-       hide();
-       bc().cancel();
-}
-
-
-void ControlButton::RestoreButton()
-{
-       update();
-       bc().undoAll();
-}
diff --git a/src/frontends/controllers/ControlButton.h b/src/frontends/controllers/ControlButton.h
deleted file mode 100644 (file)
index 6c29e60..0000000
+++ /dev/null
@@ -1,81 +0,0 @@
-/* This file is part of
- * ====================================================== 
- *
- *           LyX, The Document Processor
- *
- *           Copyright 2001 The LyX Team.
- *
- * ======================================================
- *
- * \file ControlButton.h
- * \author Angus Leeming <a.leeming@ic.ac.uk>
- *
- * ControlButton serves only to control the activation of the Ok, Apply, Cancel
- * and Restore buttons on the View popup.
- *
- * More generally, the class is part of a hierarchy of controller classes
- * that together connect the GUI-dependent popup to any appropriate
- * signals and dispatches any changes to the kernel.
- *
- * These controllers have no knowledge of the actual instantiation of the
- * GUI-dependent View and ButtonController, which should therefore
- * be created elsewhere.
- *
- * Once created, the Controller will take care of their initialisation,
- * management and, ultimately, destruction.
- */
-
-#ifndef CONTROLBUTTON_H
-#define CONTROLBUTTON_H
-
-#ifdef __GNUG__
-#pragma interface
-#endif
-
-#include "DialogBase.h" // This can go eventually
-#include "ButtonControllerBase.h"
-
-class ViewBase;
-
-/** Abstract base class for Controllers with a ButtonController.
- */
-class ControlButton : public DialogBase
-{
-public: // methods
-       ///
-       ControlButton() {}
-       ///
-       virtual ~ControlButton() {};
-
-       /// These functions are called when the controlling buttons are pressed.
-       ///
-       void ApplyButton();
-       ///
-       void OKButton();
-       ///
-       void CancelButton();
-       ///
-       void RestoreButton();
-
-       /** Allow the view to access the ButtonController. This method must be
-           instantiated in a daughter class that creates the actual instance
-           of the ButtonController. */
-       virtual ButtonControllerBase & bc() = 0;
-
-protected:
-       /// Get changed parameters and Dispatch them to the kernel.
-       virtual void apply() = 0;
-       /// Disconnect signals and hide View.
-       virtual void hide() = 0;
-       /// Update dialog before showing it.
-       virtual void update() = 0;
-
-       /** Allow the Controller to access the View. This method must be
-           instantiated in a daughter class that creates the actual instance
-           of the View. */
-       virtual ViewBase & view() = 0;
-};
-
-#include "ViewBase.h"
-
-#endif // CONTROLBUTTON_H
diff --git a/src/frontends/controllers/ControlButtons.C b/src/frontends/controllers/ControlButtons.C
new file mode 100644 (file)
index 0000000..1f27c14
--- /dev/null
@@ -0,0 +1,49 @@
+// -*- C++ -*-
+/* This file is part of
+ * ====================================================== 
+ *
+ *           LyX, The Document Processor
+ *
+ *           Copyright 2001 The LyX Team.
+ *
+ * ======================================================
+ *
+ * \file ControlButtons.C
+ * \author Angus Leeming <a.leeming@ic.ac.uk>
+ */
+
+#include <config.h>
+
+#ifdef __GNUG__
+#pragma implementation
+#endif
+
+#include "ControlButtons.h"
+
+void ControlButtons::ApplyButton()
+{
+       apply();
+       bc().apply();
+}
+
+
+void ControlButtons::OKButton()
+{
+       apply();
+       hide();
+       bc().ok();
+}
+
+
+void ControlButtons::CancelButton()
+{
+       hide();
+       bc().cancel();
+}
+
+
+void ControlButtons::RestoreButton()
+{
+       update();
+       bc().restore();
+}
diff --git a/src/frontends/controllers/ControlButtons.h b/src/frontends/controllers/ControlButtons.h
new file mode 100644 (file)
index 0000000..02c4f22
--- /dev/null
@@ -0,0 +1,81 @@
+/* This file is part of
+ * ====================================================== 
+ *
+ *           LyX, The Document Processor
+ *
+ *           Copyright 2001 The LyX Team.
+ *
+ * ======================================================
+ *
+ * \file ControlButtonss.h
+ * \author Angus Leeming <a.leeming@ic.ac.uk>
+ *
+ * ControlButtons serves only to control the activation of the Ok, Apply, Cancel
+ * and Restore buttons on the View dialog.
+ *
+ * More generally, the class is part of a hierarchy of controller classes
+ * that together connect the GUI-dependent dialog to any appropriate
+ * signals and dispatches any changes to the kernel.
+ *
+ * These controllers have no knowledge of the actual instantiation of the
+ * GUI-dependent View and ButtonController, which should therefore
+ * be created elsewhere.
+ *
+ * Once created, the Controller will take care of their initialisation,
+ * management and, ultimately, destruction.
+ */
+
+#ifndef CONTROLBUTTONS_H
+#define CONTROLBUTTONS_H
+
+#ifdef __GNUG__
+#pragma interface
+#endif
+
+#include "DialogBase.h" // This can go eventually
+#include "ButtonControllerBase.h"
+
+class ViewBase;
+
+/** Abstract base class for Controllers with a ButtonController.
+ */
+class ControlButtons : public DialogBase
+{
+public: // methods
+       ///
+       ControlButtons() {}
+       ///
+       virtual ~ControlButtons() {};
+
+       /// These functions are called when the controlling buttons are pressed.
+       ///
+       void ApplyButton();
+       ///
+       void OKButton();
+       ///
+       void CancelButton();
+       ///
+       void RestoreButton();
+
+       /** Allow the view to access the ButtonController. This method must be
+           instantiated in a daughter class that creates the actual instance
+           of the ButtonController. */
+       virtual ButtonControllerBase & bc() = 0;
+
+protected:
+       /// Get changed parameters and Dispatch them to the kernel.
+       virtual void apply() = 0;
+       /// Disconnect signals and hide View.
+       virtual void hide() = 0;
+       /// Update dialog before showing it.
+       virtual void update() = 0;
+
+       /** Allow the Controller to access the View. This method must be
+           instantiated in a daughter class that creates the actual instance
+           of the View. */
+       virtual ViewBase & view() = 0;
+};
+
+#include "ViewBase.h"
+
+#endif // CONTROLBUTTONS_H
index 6b0dd13966cca295593ab88e9498f131708c1830..56abf2b48fad0920865f281b799837822e4f8247 100644 (file)
  * \author Angus Leeming <a.leeming@ic.ac.uk>
  */
 
+#include <config.h>
 #include <algorithm>
 
 #ifdef __GNUG__
 #pragma implementation
 #endif
 
-#include <config.h>
-
 #include "ControlCitation.h"
 #include "buffer.h"
 #include "Dialogs.h"
index 18b0951ced1ad2d489d129b3f81c603bf5da3004..a42cb6b05763c1036988232eadbac422586a4ba4 100644 (file)
@@ -21,8 +21,7 @@
 #include "ControlCommand.h"
 #include "biblio.h" // biblio::InfoMap
 
-/** A controller for Citation dialogs. All citation-specific functionality
-    should go in here.
+/** A controller for Citation dialogs.
  */
 class ControlCitation : public ControlCommand
 {
index fc1061200d658d2f24fccc3a2867698b3c2eed62..ad0ebb08c70eee03c45e598d67efb3a4f5110341 100644 (file)
  * ControlConnectBase, ControlConnectBI and ControlConnectBD.
  *
  * Together they control the connection/disconnection of signals with the LyX
- * kernel. Controllers of individual popups interacting with the kernel through
+ * kernel. Controllers of individual dialogs interacting with the kernel through
  * signals/slots will all be derived from ControlConnectBI or ControlConnectBD.
  *
- * A popup is classed as "Buffer Dependent" if its contents change with the
- * buffer (document). An example would be the Citation popup. Such a popup
+ * A dialog is classed as "Buffer Dependent" if its contents change with the
+ * buffer (document). An example would be the Citation dialog. Such a dialog
  * would be derived, therefore, from ControlConnectBD.
  *
- * Conversely, a popup is "Buffer Independent" if its contents do not change
- * when the buffer changes. An example would be the Copyright popup. Such a
- * popup, is therefore derived from ControlConnectBI.
+ * Conversely, a dialog is "Buffer Independent" if its contents do not change
+ * when the buffer changes. An example would be the Copyright dialog. Such a
+ * dialog is therefore derived from ControlConnectBI.
  *
  */
 
@@ -34,7 +34,7 @@
 #pragma interface
 #endif
 
-#include "ControlButton.h"
+#include "ControlButtons.h"
 
 class Dialogs;
 class LyXView;
@@ -43,7 +43,7 @@ class LyXView;
     kernel. It is meant to be used solely as the parent class to
     ControlConnectBI and ControlConnectBD.
 */
-class ControlConnectBase : public ControlButton
+class ControlConnectBase : public ControlButtons
 {
 public:
        ///
index 0bfea6048babe9525a998ee093f2b486d4f01599..3898cffac4fd1947bc4383ff3b31e0c2bab58f68 100644 (file)
  * \file ControlDialogs.h
  * \author Angus Leeming <a.leeming@ic.ac.uk>
  *
- * ControlDialog is to be used as a parent class for popups that are not
- * Inset-popups. (An ugly description I know, but I hope the meaning is clear!
- * Can anyone do any better?) Examples would be the Document and Paragraph
- * popups.
+ * ControlDialog is to be used as a parent class for dialogs that are not
+ * views onto parameters of insets. (An ugly description I know, but I hope 
+ * the meaning is clear!  * Can anyone do any better?) Examples would be the 
+ * Document and Paragraph dialogs.
  */
 
 #ifndef CONTROLDIALOGS_H
index 09bffe7da3e1f5ecf688fd5e2a3d9ce1d8f1c2bb..d0c4ed75c9101cbf9c69714545a40d8af4313226 100644 (file)
@@ -62,7 +62,7 @@ void ControlExternal::applyParamsToInset()
 void ControlExternal::editExternal()
 {
        // fill the local, controller's copy of the Params struct with
-       // the contents of the popup's fields.
+       // the contents of the dialog's fields.
        view().apply();
 
        // Create a local copy of the inset and initialise it with this
index d91b7d2c6808685ea86b8b36b363c3a43ae3fbc0..447a245d1ccf193b626de753b950b7e363534389 100644 (file)
@@ -10,9 +10,9 @@
  * \file ControlInsets.h
  * \author Angus Leeming <a.leeming@ic.ac.uk>
  *
- * ControlInset is to be used as a parent class for popups that display and
+ * ControlInset is to be used as a parent class for dialogs that display and
  * can perhaps modify the contents of an individual inset. An example being the
- * ubiquitous Citation popup.
+ * ubiquitous Citation dialog.
  */
 
 #ifndef CONTROLINSET_H
@@ -65,7 +65,7 @@ private:
 
 
        
-       /// Instantiation of ControlButton virtual methods.
+       /// Instantiation of ControlButtons virtual methods.
 
        /// Get changed parameters and Dispatch them to the kernel.
        virtual void apply();
index 0f46bded1f9d8944c1ca1fb1903ef7636b51cadf..6bf0fbb83fe311d2c9571ce6dc16f8045d129432 100644 (file)
@@ -52,7 +52,7 @@ vector<string> const ControlToc::getTypes() const
        Buffer::Lists::const_iterator end = tmp.end();
 
        for (; cit != end; ++cit) {
-               types.push_back(cit->first.c_str());
+               types.push_back(cit->first);
        }
 
        return types;
index 791f83b1f03b60befe1c0fb2386c71ca2b9dc32f..83c71f7bfaa73f65913c0cb7cdf86e51ddabdeef 100644 (file)
@@ -31,6 +31,11 @@ ControlVCLog::ControlVCLog(LyXView & lv, Dialogs & d)
        d_.showVCLogFile.connect(slot(this, &ControlVCLog::show));
 }
 
+// FIXME: this is all wrong, getLogFile() actually creates a file
+// which we must unlink.
+
+// FIXME: I need to get the Buffer Filename for my window title, need
+// to add to params. 
 
 void ControlVCLog::setParams()
 {
index ec940ff01feaefc3a36a2351042479fb9b89c154..b4f862e048c9c2f743cc9820211824954d9a1252 100644 (file)
@@ -23,8 +23,8 @@ libcontrollers_la_SOURCES=\
        ControlBibitem.h \
        ControlBibtex.C \
        ControlBibtex.h \
-       ControlButton.C \
-       ControlButton.h \
+       ControlButtons.C \
+       ControlButtons.h \
        ControlCharacter.C \
        ControlCharacter.h \
        ControlCitation.C \
index fd6472dbf7fa3811e4aef93187ee1c7a77bd5306..aa0ebd0fc4e909cdce52e366980c89ff292c871f 100644 (file)
@@ -1,16 +1,16 @@
 This directory provides the controllers that act as an interface between the
-LyX kernel and the GUI-specific implementations of each popup. It also
+LyX kernel and the GUI-specific implementations of each dialog. It also
 provides abstract base classes from which GUI-specific implemetations of the
-ButtonController and each separate popup should be derived (see
+ButtonController and each separate dialog should be derived (see
 ButtonControlBase.[Ch] and ViewBase.h respectively).
 
-The Controller connects the GUI-specific popup to any appropriate signals and
+The Controller connects the GUI-specific dialog to any appropriate signals and
 dispatches any changes in the data to the kernel. It has no knowledge of the
 actual instantiation of the GUI-dependent View and ButtonController, which
 should therefore be created elsewhere. Once created, the Controller will take
 care of their initialisation, management and, ultimately, destruction.
 
-This leaves the GUI-specific popup (and its author!) to worry only about the
+This leaves the GUI-specific dialog (and its author!) to worry only about the
 data that it has been created to input/modify.
 
 This concept has been instatiated for the Citation dialog only at the moment.
@@ -39,7 +39,7 @@ build) so:
        bc().setOK(dialog_->button_ok);
        bc().setApply(dialog_->button_apply);
        bc().setCancel(dialog_->button_cancel);
-       bc().setUndoAll(dialog_->button_restore);
+       bc().setRestore(dialog_->button_restore);
 The button controller alters the state of the buttons (active/inactive). 
 xforms works by callbacks, so clicking on say the button_ok button
 causes a callback event to (see FormBase.C) 
index 78a4f0e82c0c9f12a592af7fa588fd1945d0db55..70ff2aa308125714d56b12b739fab90025d48c50 100644 (file)
 #define VIEWBASE_H
 
 #include <boost/utility.hpp>
-#include "ControlButton.h"
+#include "ControlButtons.h"
 #include "ControlSplash.h"
 
 class ViewBase {
 public:
        /// 
-       ViewBase(ControlButton & c) : controller_(c) {}
+       ViewBase(ControlButtons & c) : controller_(c) {}
        /// 
        virtual ~ViewBase() {}
 
@@ -50,7 +50,7 @@ public:
 
 protected:
        /// The view is, after all, controlled!
-       ControlButton & controller_;
+       ControlButtons & controller_;
 };
 
 
@@ -84,7 +84,7 @@ template <class GUIbc>
 class ViewBC : public ViewBase {
 public:
        ///
-       ViewBC(ControlButton & c) : ViewBase(c) {}
+       ViewBC(ControlButtons & c) : ViewBase(c) {}
 
 protected:
        ///
index 65f61aa88ceffe993c2313ad0b50a58faedcb514..1f3056f5845e68134e451793d93d4a29822aea86 100644 (file)
@@ -1,3 +1,12 @@
+2001-04-03  John Levon  <moz@compsoc.man.ac.uk>
+
+       * Dialogs.C: s/popup/dialog/
+
+       * FormUrl.C:
+       * GnomeBase.C:
+       * GnomeBase.h: s/ControlButton/ControlButtons/
+       s/UndoAll/Restore/
+       
 2001-04-02  Michael Koziarski  <michael@koziarski.org>
 
        * FormCopyright.[Ch]: Reimplemented as an MVC dialog.
index 721ab5351be86798f2c478417468c9f49f88f779..a64315eed5a3d7198313ec8e2ed420621e50b335 100644 (file)
@@ -64,7 +64,7 @@
 #include "FormMinipage.h"
 */
 
-// Signal enabling all visible popups to be redrawn if so desired.
+// Signal enabling all visible dialogs to be redrawn if so desired.
 // E.g., when the GUI colours have been remapped.
 SigC::Signal0<void> Dialogs::redrawGUI;
 
index f3b6f51b01a80fcd6017cb9a92d6ce44cd82d388..686120f0c723a43b3eec1a40cdfa4f7fe2fbec71 100644 (file)
@@ -48,7 +48,7 @@ void FormUrl::build()
        bc().setOK(ok_btn());
        bc().setCancel(cancel_btn());
        bc().setApply(apply_btn());
-       bc().setUndoAll(restore_btn());
+       bc().setRestore(restore_btn());
 
        // Make sure everything is in the correct state.
        bc().refresh();
index 8b68b16bb706c1f36eccf17f46054a80c3cc9db4..87ace2088f0d0b01d1c99f98b57e3901cdee263d 100644 (file)
@@ -21,7 +21,7 @@
 
 #include <gnome--/dialog.h>
 
-GnomeBase::GnomeBase(ControlButton & c, 
+GnomeBase::GnomeBase(ControlButtons & c, 
                string const & glade_file, string const & name)
        : ViewBC<gnomeBC>(c)
        , file_(glade_file), widget_name_(name), xml_(0)
index b7541b7c731d1b48b0b6b0f82362ec7f4221cbc7..fe3751474e6990fff1a6779fcd677f8be45ff730 100644 (file)
@@ -33,7 +33,7 @@ class Dialog;
 class GnomeBase : public ViewBC<gnomeBC>, public SigC::Object {
 public:
        /// 
-       GnomeBase(ControlButton & c, string const & glade_file, string const & name);
+       GnomeBase(ControlButtons & c, string const & glade_file, string const & name);
        ///
        virtual ~GnomeBase();
 
index 1bd493848003bb7886656b30e34babac51db8854..9bc9b0b1beeb2e9044d49f82981595910deccf26 100644 (file)
@@ -1,3 +1,19 @@
+2001-04-03  John Levon  <moz@compsoc.man.ac.uk>
+
+       * FormCharacter.C:
+       * FormDocument.h:
+       * FormSearch.C:
+       * Dialogs.C: s/popup/dialog/
+
+       * qt2BC.h:
+       * qt2BC.C:
+       * FormCitation.C:
+       * FormDocument.C: s/UndoAll/Restore/
+
+       * Qt2Base.h:
+       * Qt2Base.C: s/ControlButton/ControlButtons/
+
+       
 2001-04-02  Kalle Dalheimer  <kalle@klaralvdalens-datakonsult.se>
 
        * Makefile.am: Simplified Makefile.am
index b2b7166353290522a7079d6ce5269b615df61e3f..f0357d449f63d5d734f714ab169580425273112c 100644 (file)
@@ -53,7 +53,7 @@
 
 #include "qt2BC.h"
 
-// Signal enabling all visible popups to be redrawn if so desired.
+// Signal enabling all visible dialogs to be redrawn if so desired.
 // E.g., when the GUI colours have been remapped.
 SigC::Signal0<void> Dialogs::redrawGUI;
 
index 05262d2a754526b2aa50a50a95e70ff7f82f3b58..81bddf4c77b708be2db0ce044027390a77af263d 100644 (file)
@@ -25,7 +25,7 @@ using Liason::setMinibuffer;
 FormCharacter::FormCharacter(LyXView *v, Dialogs *d)
        : dialog_(0), lv_(v), d_(d), h_(0), u_(0)
 {
-   // let the popup be shown
+   // let the dialog be shown
    // This is a permanent connection so we won't bother
    // storing a copy because we won't be disconnecting.
    d->showLayoutCharacter.connect(slot(this, &FormCharacter::show));
index 53adc6a43b054759a4269139c4317537818c24f1..12f146ff121165c556daa9bbdfe51ba939a884f3 100644 (file)
@@ -80,7 +80,7 @@ void FormCitation::build()
     bc().setOK(dialog_->okPB);
     bc().setApply(dialog_->applyPB);
     bc().setCancel(dialog_->cancelPB);
-    bc().setUndoAll(dialog_->restorePB);
+    bc().setRestore(dialog_->restorePB);
 
     bc().addReadOnly(dialog_->addPB);
     bc().addReadOnly(dialog_->delPB);
index 94e43256006cc2ca30de2a8d1faddc06f432ce76..c42706faa015fc55d0d244215ba251623d8b8d0a 100644 (file)
@@ -64,7 +64,7 @@ void FormDocument::build()
     bc().setOK(dialog_->okPB);
     bc().setApply(dialog_->applyPB);
     bc().setCancel(dialog_->cancelPB);
-    bc().setUndoAll(dialog_->restorePB);
+    bc().setRestore(dialog_->restorePB);
     bc().refresh();
 
     // the document paper page
index 1515f9490f20de512ac5295312b48d0c82f5800d..a251d91c72c7bc42873055138307c1214cf08876 100644 (file)
@@ -30,7 +30,7 @@ class BufferParams;
 class LyXView;
 class Dialogs;
 
-/** This class provides an Qt2 implementation of the FormDocument Popup.
+/** This class provides an Qt2 implementation of the FormDocument dialog.
     The table-layout-form here changes values for latex-tabulars
     @author Kalle Dalheimer
  */
@@ -38,7 +38,6 @@ class FormDocument
   : public Qt2CB<ControlDocument, Qt2DB<FormDocumentDialogImpl> >
 {
 public:
-       /// #FormDocument x(Communicator ..., Popups ...);#
        FormDocument(LyXView *, Dialogs *);
 private:
        ///
@@ -80,11 +79,11 @@ private:
        virtual void build();
 //     /// Filter the inputs
 //     virtual bool input( FL_OBJECT *, long );
-       /// Update the popup.
+       /// Update the dialog.
        virtual void update();
-       /// Apply from popup
+       /// Apply from dialog
        virtual void apply();
-       /// Cancel from popup
+       /// Cancel from dialog
        virtual void cancel();
 
 //     ///
index 98e1fbcd6b552e1332445ea82ba5eac8fd026489..ecd567a007d10101e114ee28b48a66ac2251e7ea 100644 (file)
@@ -24,7 +24,7 @@ using Liason::setMinibuffer;
 FormSearch::FormSearch(LyXView *v, Dialogs *d)
        : dialog_(0), lv_(v), d_(d), h_(0), u_(0)
 {
-   // let the popup be shown
+   // let the dialog be shown
    // This is a permanent connection so we won't bother
    // storing a copy because we won't be disconnecting.
    d->showSearch.connect(SigC::slot(this, &FormSearch::show));
index 0e2e63b7b03504ca36cb86fcbfdad6018ca861f3..6841c940bb57ced3ce8049333440f3def4d8e3e9 100644 (file)
@@ -28,7 +28,7 @@
 #include <stdio.h>
 
 
-Qt2Base::Qt2Base(::ControlButton & c, QString const & t)
+Qt2Base::Qt2Base(ControlButtons & c, QString const & t)
        : ViewBC<qt2BC>(c), title_(t)
 {}
 
index 8dcb95f5043c78bd973fd4a5f4fa068c86f19267..d697dd89331fa63f9e9891c5c8e7bfa39a514799 100644 (file)
@@ -28,7 +28,7 @@ class QDialog;
 #include "ViewBase.h"
 #include "LString.h"
 #include "ButtonPolicies.h"
-#include "ControlButton.h"
+#include "ControlButtons.h"
 
 class qt2BC;
 
@@ -39,7 +39,7 @@ class Qt2Base : public QObject, public ViewBC<qt2BC>
     Q_OBJECT
 public:
        ///
-       Qt2Base(::ControlButton &, const QString &);
+       Qt2Base(ControlButtons &, const QString &);
        ///
        virtual ~Qt2Base() {}
 
@@ -85,7 +85,7 @@ class Qt2DB: public Qt2Base
 {
 protected:
        ///
-       Qt2DB(::ControlButton &, const QString&);
+       Qt2DB(ControlButtons &, const QString&);
        /// Pointer to the actual instantiation of the Qt dialog
        virtual QDialog* form() const;
        /// Real GUI implementation.
@@ -94,7 +94,7 @@ protected:
 
 
 template <class Dialog>
-Qt2DB<Dialog>::Qt2DB(::ControlButton & c, const QString& t)
+Qt2DB<Dialog>::Qt2DB(ControlButtons & c, const QString& t)
        : Qt2Base(c, t)
 {}
 
@@ -111,14 +111,14 @@ class Qt2CB: public Base
 {
 protected:
        ///
-       Qt2CB(::ControlButton &, const QString&);
+       Qt2CB(ControlButtons &, const QString&);
        /// The parent controller
        Controller & controller() const;
 };
 
 
 template <class Controller, class Base>
-Qt2CB<Controller, Base>::Qt2CB(::ControlButton & c, const QString& t)
+Qt2CB<Controller, Base>::Qt2CB(ControlButtons & c, const QString& t)
        : Base(c, t)
 {}
 
index c2d195fc9880fe58b8340c873a7290b99cdc53cd..5a862ab15d9ab0c6be7639be54f5fba55e49ad22 100644 (file)
@@ -1,5 +1,5 @@
 /**
- * \file xformsBC.C
+ * \file qt2BC.C
  * Copyright 2001 the LyX Team
  * Read the file COPYING
  *
@@ -19,7 +19,7 @@
 
 qt2BC::qt2BC(string const & cancel, string const & close)
        : ButtonControllerBase(cancel, close),
-         okay_(0), apply_(0), cancel_(0), undo_all_(0), read_only_()
+         okay_(0), apply_(0), cancel_(0), restore_(0), read_only_()
 {}
 
 
@@ -39,11 +39,11 @@ void qt2BC::refresh()
                    apply_->setEnabled( false );
                }
        }
-       if (undo_all_) {
-               if (bp().buttonStatus(ButtonPolicy::UNDO_ALL)) {
-                   undo_all_->setEnabled( true );
+       if (restore_) {
+               if (bp().buttonStatus(ButtonPolicy::RESTORE)) {
+                   restore_->setEnabled( true );
                } else {
-                   undo_all_->setEnabled( false );
+                   restore_->setEnabled( false );
                }
        }
        if (cancel_) {
index 1f7de47f1691eaa78385ed5d0da21566466a53a6..8d6a602ab43a89654a39504bce13d8a49930f42d 100644 (file)
@@ -58,8 +58,8 @@ public:
                cancel_ = obj;
        }
        ///
-       void setUndoAll(QButton * obj) {
-               undo_all_ = obj;
+       void setRestore(QButton * obj) {
+               restore_ = obj;
        }
        ///
        void addReadOnly(QWidget * obj) {
@@ -82,7 +82,7 @@ private:
        ///
        QButton * cancel_;
        ///
-       QButton * undo_all_;
+       QButton * restore_;
        /// List of items to be deactivated when in one of the read-only states
        std::list<QWidget *> read_only_;
 };
index f8485fb51e48ba75fe4490d6d31e29a17a204e2e..ea9729d47a79836d2a005704de4121de24e19d87 100644 (file)
@@ -1,3 +1,16 @@
+2001-04-03  John Levon  <moz@compsoc.man.ac.uk>
+
+       * Dialogs.C: s/popup/dialog/
+
+       * Form*.C:
+       * FormBase.h:
+       * FormBase.C: s/ControlButton/ControlButtons/
+       move bc().refresh() into base show() method
+
+       * Form*.C:
+       * FormBaseDeprecated.C:
+       s/UndoAll/restore/
+
 2001-03-30  Angus Leeming  <a.leeming@ic.ac.uk>
 
        * FormMathsPanel.C (c-tor): set button controller cancel label to close.
index 0bb03c43c0f9729241109f4e3d7372c5d3e67ae5..0121bd3d100af813cd43a9619c515e0b8d6de209 100644 (file)
@@ -96,7 +96,7 @@
 #include "FormPreferences.h"
 #include "FormTabular.h"
 
-// Signal enabling all visible popups to be redrawn if so desired.
+// Signal enabling all visible dialogs to be redrawn if so desired.
 // E.g., when the GUI colours have been remapped.
 SigC::Signal0<void> Dialogs::redrawGUI;
 
index 8ba2319ff623a06870422be56ac789712229454a..470d0aa368483253860d0a0b81cfd8d977ca33ed 100644 (file)
@@ -25,7 +25,7 @@
 extern "C" int C_FormBaseWMHideCB(FL_FORM * form, void *);
 
 
-FormBase::FormBase(ControlButton & c, string const & t)
+FormBase::FormBase(ControlButtons & c, string const & t)
        : ViewBC<xformsBC>(c), minw_(0), minh_(0), title_(t)
 {}
 
@@ -42,6 +42,8 @@ void FormBase::show()
        if (!form()) {
                build();
 
+               bc().refresh();
                // work around dumb xforms sizing bug
                minw_ = form()->w;
                minh_ = form()->h;
index e2911c42ff19811afa9c3b8892e06c92ab774c55..b43db6a66b4569d0eb284b8c0c4b7829164bd011 100644 (file)
@@ -33,7 +33,7 @@ class FormBase : public ViewBC<xformsBC>
 {
 public:
        ///
-       FormBase(ControlButton &, string const &);
+       FormBase(ControlButtons &, string const &);
        ///
        virtual ~FormBase() {}
 
@@ -76,7 +76,7 @@ class FormDB: public FormBase
 {
 protected:
        ///
-       FormDB(ControlButton &, string const &);
+       FormDB(ControlButtons &, string const &);
        /// Pointer to the actual instantiation of xform's form
        virtual FL_FORM * form() const;
        /// Real GUI implementation.
@@ -85,7 +85,7 @@ protected:
 
 
 template <class Dialog>
-FormDB<Dialog>::FormDB(ControlButton & c, string const & t)
+FormDB<Dialog>::FormDB(ControlButtons & c, string const & t)
        : FormBase(c, t)
 {}
 
@@ -103,14 +103,14 @@ class FormCB: public Base
 {
 protected:
        ///
-       FormCB(ControlButton &, string const &);
+       FormCB(ControlButtons &, string const &);
        /// The parent controller
        Controller & controller() const;
 };
 
 
 template <class Controller, class Base>
-FormCB<Controller, Base>::FormCB(ControlButton & c, string const & t)
+FormCB<Controller, Base>::FormCB(ControlButtons & c, string const & t)
        : Base(c, t)
 {}
 
index 7c0c0b27fb8ddc0f92bfcf10624b7182f17d5df5..d6336b5706b0975c02c01f5334ab657fbdb02abf 100644 (file)
@@ -194,7 +194,7 @@ void FormBaseDeprecated::RestoreCB(FL_OBJECT * ob, long)
        FormBaseDeprecated * pre =
                static_cast<FormBaseDeprecated*>(ob->form->u_vdata);
        Assert(pre);
-       pre->bc().undoAll();
+       pre->bc().restore();
        pre->restore();
 }
 
index 9584cedc3b21050c787e76a288a02c06e64e33d5..0b85396a77120cb9b43a1cef3f9f83830a7579bf 100644 (file)
@@ -36,7 +36,6 @@ void FormBibitem::build()
         // Manage the ok, apply, restore and cancel/close buttons
        bc().setOK(dialog_->button_ok);
        bc().setCancel(dialog_->button_cancel);
-       bc().refresh();
 
        bc().addReadOnly(dialog_->key);
        bc().addReadOnly(dialog_->label);
index cd29bcdd06bc6a6f6f4af9ff1efb2cbb7de4d7fe..923b147684262f894c02e7daa7ba3a62ce808498 100644 (file)
@@ -36,7 +36,6 @@ void FormBibtex::build()
         // Manage the ok, apply, restore and cancel/close buttons
        bc().setOK(dialog_->button_ok);
        bc().setCancel(dialog_->button_cancel);
-       bc().refresh();
 
        bc().addReadOnly(dialog_->database);
        bc().addReadOnly(dialog_->style);
index 64d8610ff54aa07c904b5fb8c8c7e9323e87cff6..54a1f355f0a5b394807bb9be4dc62b1a145f1d6b 100644 (file)
@@ -12,7 +12,7 @@
 #include "form_browser.h"
 #include "xformsBC.h"
 
-FormBrowser::FormBrowser(ControlButton & c, string const & t)
+FormBrowser::FormBrowser(ControlButtons & c, string const & t)
        : FormDB<FD_form_browser>(c, t)
 {}
        
@@ -23,5 +23,4 @@ void FormBrowser::build()
 
        // Manage the close button
        bc().setCancel(dialog_->button_close);
-       bc().refresh();
 }
index ed54aec32334d91508518037e34b367c45d54f8e..1e6a891e3ed57656597d8561278fe44f5d9372ae 100644 (file)
@@ -25,7 +25,7 @@ struct FD_form_browser;
 class FormBrowser : public FormDB<FD_form_browser> {
 public:
        ///
-       FormBrowser(ControlButton &, string const &);
+       FormBrowser(ControlButtons &, string const &);
 
 private:
        /// Build the dialog.
index a96ee602173834b84034a616fba27c5c8607bb3d..161a581fcaf18244d39759d506716d4eab13893a 100644 (file)
@@ -105,7 +105,6 @@ void FormCharacter::build()
        // Manage the ok, apply and cancel/close buttons
        bc().setApply(dialog_->button_apply);
        bc().setCancel(dialog_->button_close);
-       bc().refresh();
        bc().addReadOnly(dialog_->check_toggle_all);
 }
 
index bfeb4d8471cf96073a193e3971edf6c30bf6ebdc..42c2aa61eb513da98e9e14e2da1d332810ae14b2 100644 (file)
@@ -37,10 +37,10 @@ public:
        FormCharacter(ControlCharacter &);
 private:
 
-       /// Apply from popup
+       /// Apply from dialog
        virtual void apply();
    
-       /// Build the popup
+       /// Build the dialog
        virtual void build();
    
        /// Nothing to update...
index 8f235a759da5f2d7700a622f4f6896d5c62f64aa..c31010064b179796e3c2d9b6f1f4eeb29714b226 100644 (file)
@@ -75,7 +75,7 @@ void FormCitation::build()
        bc().setOK(dialog_->button_ok);
        bc().setApply(dialog_->button_apply);
        bc().setCancel(dialog_->button_cancel);
-       bc().setUndoAll(dialog_->button_restore);
+       bc().setRestore(dialog_->button_restore);
 
        bc().addReadOnly(dialog_->button_add);
        bc().addReadOnly(dialog_->button_del);
@@ -85,7 +85,6 @@ void FormCitation::build()
        bc().addReadOnly(dialog_->input_before);
        bc().addReadOnly(dialog_->input_after);
 
-       bc().refresh();
 }
 
 
index 08f132cccbb4cd78fbd20756df1f6b904cf5fe6c..5103aa535a8a73395d88ad448c25a1e3c3731068 100644 (file)
@@ -47,5 +47,4 @@ void FormCopyright::build()
        
         // Manage the cancel/close button
        bc().setCancel(dialog_->button_cancel);
-       bc().refresh();
 }
index 09ff4c597c5786edd8ca2ec24915d7b0469740f9..89c320e55aa844041288d50c3473fe13da68977a 100644 (file)
@@ -35,7 +35,6 @@ void FormCredits::build()
 
        // Manage the cancel/close button
        bc().setCancel(dialog_->button_cancel);
-       bc().refresh();
 
        std::stringstream ss;
        fl_add_browser_line(dialog_->browser_credits, 
index 0a114121bb0a6d3e7b95cb3bc7396e622b3e34fc..b15857a5041adb366760bc7b258ab00d0c0ef371 100644 (file)
@@ -46,7 +46,7 @@ using SigC::slot;
 FormDocument::FormDocument(LyXView * lv, Dialogs * d)
        : FormBaseBD(lv, d, _("Document Layout")), fbullet(0)
 {
-    // let the popup be shown
+    // let the dialog be shown
     // This is a permanent connection so we won't bother
     // storing a copy because we won't be disconnecting.
     d->showLayoutDocument.connect(slot(this, &FormDocument::show));
@@ -84,8 +84,7 @@ void FormDocument::build()
     bc().setOK(dialog_->button_ok);
     bc().setApply(dialog_->button_apply);
     bc().setCancel(dialog_->button_cancel);
-    bc().setUndoAll(dialog_->button_restore);
-    bc().refresh();
+    bc().setRestore(dialog_->button_restore);
 
     // the document paper form
     paper_.reset(build_doc_paper());
@@ -245,7 +244,7 @@ void FormDocument::build()
                                 bullets_->form);
     if ((XpmVersion < 4) || (XpmVersion == 4 && XpmRevision < 7)) {
            lyxerr << _("Your version of libXpm is older than 4.7.\n"
-                       "The `bullet' tab of the document popup "
+                       "The `bullet' tab of the document dialog "
                        "has been disabled") << '\n';
        fl_deactivate_object(fbullet);
        fl_set_object_lcol(fbullet, FL_INACTIVE);
index 2f5d2fc8942ff1c73f4cddf213db2062f795c42a..0f22c5b54a6eea02b581aed0df11e67fbb5d38ab 100644 (file)
@@ -32,13 +32,12 @@ struct FD_form_doc_language;
 struct FD_form_doc_options;
 struct FD_form_doc_bullet;
 
-/** This class provides an XForms implementation of the FormDocument Popup.
+/** This class provides an XForms implementation of the FormDocument dialog.
     The table-layout-form here changes values for latex-tabulars
     @author Jürgen Vigna
  */
 class FormDocument : public FormBaseBD {
 public:
-       /// #FormDocument x(Communicator ..., Popups ...);#
        FormDocument(LyXView *, Dialogs *);
        ///
        static void ComboInputCB(int, void *, Combox *);
@@ -85,11 +84,11 @@ private:
        virtual void build();
        /// Filter the inputs
        virtual bool input( FL_OBJECT *, long );
-       /// Update the popup.
+       /// Update the dialog.
        virtual void update();
-       /// Apply from popup
+       /// Apply from dialog
        virtual void apply();
-       /// Cancel from popup
+       /// Cancel from dialog
        virtual void cancel();
 
        ///
index a475649a00ab38c52326aed6736a7268579f18d6..3611736614960bbba3a6d9d39fee72214ae2fe6b 100644 (file)
@@ -37,7 +37,6 @@ void FormError::build()
 
         // Manage the cancel/close button
        bc().setCancel(dialog_->button_cancel);
-       bc().refresh();
 }
 
 
index 41bb9fa289a4cfa01f1d2a8486f3bbdd4e651aef..edf65d0c4d6609a8868ea56b10b6b2ae31cabb8d 100644 (file)
@@ -57,7 +57,6 @@ void FormExternal::build()
        bc().setOK(dialog_->button_ok);
        bc().setApply(dialog_->button_apply);
        bc().setCancel(dialog_->button_cancel);
-       bc().refresh();
 
        bc().addReadOnly(dialog_->input_filename);
        bc().addReadOnly(dialog_->button_filenamebrowse);
index 36b1ab081f2596ac5b05919ca159c9abc3885c38..a4ef19ad23bcf1e44f69cab5c5119952e1c344b6 100644 (file)
@@ -123,8 +123,7 @@ void FormGraphics::build()
        bc().setOK(dialog_->button_ok);
        bc().setApply(dialog_->button_apply);
        bc().setCancel(dialog_->button_cancel);
-       bc().setUndoAll(dialog_->button_restore);
-       bc().refresh();
+       bc().setRestore(dialog_->button_restore);
 
        bc().addReadOnly(dialog_->input_filename);
        bc().addReadOnly(dialog_->button_browse);
index 78f80f27381f7a4cd184062cc0cd94e6522b049e..372db8d4226861d1638a0612584f51ff6ea76917 100644 (file)
@@ -37,7 +37,6 @@ void FormInclude::build()
        // Manage the ok and cancel buttons
        bc().setOK(dialog_->button_ok);
        bc().setCancel(dialog_->button_cancel);
-       bc().refresh();
 
        bc().addReadOnly(dialog_->button_browse);
        bc().addReadOnly(dialog_->check_verbatim);
index c8e07766b18e694e08c43f966620296710104712..c2057a5a990c4937471c61071fb8d1d7c4716997 100644 (file)
@@ -40,11 +40,10 @@ void FormIndex::build()
        bc().setOK(dialog_->button_ok);
        bc().setApply(dialog_->button_apply);
        bc().setCancel(dialog_->button_cancel);
-       bc().setUndoAll(dialog_->button_restore);
+       bc().setRestore(dialog_->button_restore);
 
        bc().addReadOnly(dialog_->input_key);
 
-       bc().refresh();
 }
 
 
index 91e8a1a64a59808cc473d2987fa02dca26a7dc72..62c51987a472554f6bc6c5cac8776438e031c90a 100644 (file)
@@ -90,7 +90,6 @@ void FormMathsBitmap::build()
        fl_end_form();
 
        bc().setCancel(button_cancel);
-       bc().refresh();
 }
 
 
index ff412d00a268a177fc838295b4919dd0462f7ccf..0e820dfeb3d63e8f5c109cb82ce6f1a62f3cb526 100644 (file)
@@ -41,7 +41,7 @@ private:
        ///
        int GetIndex(FL_OBJECT *);
 
-       /// Build the popup
+       /// Build the dialog
        virtual void build();
        /// apply the data
        virtual void apply();
index dbb12bb24a89c51047c4fe0c12f8a535d9dfd72d..eb422e29652cfc1c67b58a4ae6ae54a50981ba03 100644 (file)
@@ -53,7 +53,6 @@ void FormMathsDeco::build()
 
        bc().setCancel(dialog_->button_cancel);
        bc().addReadOnly(dialog_->bmtable);
-       bc().refresh();
 }
 
 
index c8c9089390a7258923955b29be3e2cb82944d011..ff1a485d78b5107781e6e3e6f4e05b47f26bc341 100644 (file)
@@ -30,7 +30,7 @@ public:
        FormMathsDeco(LyXView *, Dialogs *, FormMathsPanel const &);
 
 private:
-       /// Build the popup
+       /// Build the dialog
        virtual void build();
        /// Apply from dialog (modify or create inset)
        virtual void apply();
@@ -38,7 +38,7 @@ private:
        /// Pointer to the actual instantiation of the xforms form
        virtual FL_FORM * form() const;
 
-       // build the popup
+       // build the form
        FD_form_maths_deco * build_maths_deco();
        
        // Real GUI implementation
index b20405a268bf9db1f8dfd296550ddc3fc5395b9e..049cfb1a671b8269598372012f7ea8ea9681554f 100644 (file)
@@ -75,8 +75,6 @@ void FormMathsDelim::build()
        bc().addReadOnly(dialog_->radio_right);
        bc().addReadOnly(dialog_->radio_left);
        bc().addReadOnly(dialog_->button_pix);
-
-       bc().refresh();
 }
 
 
index 1e3861ac2c80711413d05976d2c920e636630c69..efacd5c6b68d890f443abcf79b8748ac0397e92b 100644 (file)
@@ -30,7 +30,7 @@ public:
        FormMathsDelim(LyXView *, Dialogs *, FormMathsPanel const &);
 
 private:
-       /// Build the popup
+       /// Build the dialog
        virtual void build();
        /// input handler
        virtual bool input(FL_OBJECT *, long);
@@ -40,7 +40,7 @@ private:
        /// Pointer to the actual instantiation of the xforms form
        virtual FL_FORM * form() const;
 
-       // build the popup
+       // build the form
        FD_form_maths_delim * build_maths_delim();
        
        // Real GUI implementation
index 92961e5cd93f4dda12ee5e80ab236e8419c8f55d..f8e95094417fa2392914f8b43495d929c72bfc7c 100644 (file)
@@ -68,8 +68,6 @@ void FormMathsMatrix::build()
        bc().addReadOnly(dialog_->slider_columns);
        bc().addReadOnly(dialog_->choice_valign);
        bc().addReadOnly(dialog_->input_halign);
-
-       bc().refresh();
 }
 
 
index b96103df3f05536c247af904c15c425722f517a4..e071bd128d43d07c93da847c02c78e63ae89f35c 100644 (file)
@@ -31,7 +31,7 @@ public:
        int AlignFilter(char const *, int);
 
 private:
-       /// Build the popup
+       /// Build the dialog
        virtual void build();
        /// input handler
        virtual bool input(FL_OBJECT *, long);
@@ -41,7 +41,7 @@ private:
        /// Pointer to the actual instantiation of the xforms form
        virtual FL_FORM * form() const;
 
-       // build the popup
+       // build the form
        FD_form_maths_matrix * build_maths_matrix();
        
        // Real GUI implementation
index 0f206660f8ed31384d7f14b75319cfc817f668b3..8c4beae9cccaa69f53d430009f556a45a62bca13 100644 (file)
@@ -158,7 +158,6 @@ void FormMathsPanel::build()
        varsize_->addBitmap(14, 3, 5, varsz_width, varsz_height, varsz_bits);
 
        bc().setCancel(dialog_->button_close);
-       bc().refresh();
 }
 
 bool FormMathsPanel::input(FL_OBJECT *, long data)
index 72a330b9fffa722394d94128e1a2d0502a891e97..bb88a4c4ddea58eeba7ffabc0c2656df16a19110 100644 (file)
@@ -62,7 +62,7 @@ private:
        /// Pointer to the actual instantiation of the ButtonController.
        virtual xformsBC & bc();
        
-       /// Build the popup
+       /// Build the dialog
        virtual void build();
        /// input handler
        virtual bool input(FL_OBJECT *, long);
index 31ca06b7673709ad24ced249a964a590ca1445e6..6946a6e919b9b0193df70282edeae1d85d39ecd7 100644 (file)
@@ -51,8 +51,6 @@ void FormMathsSpace::build()
        bc().addReadOnly(dialog_->radio_negative);
        bc().addReadOnly(dialog_->radio_quadratin);
        bc().addReadOnly(dialog_->radio_twoquadratin);
-
-       bc().refresh();
 }
 
 
index cc1e9edfca48ee65b59daba70a07cacc5f2fd651..675cd3fb5d3d5c67b0b4229cdc248ec879fa57de 100644 (file)
@@ -30,7 +30,7 @@ public:
        FormMathsSpace(LyXView *, Dialogs *, FormMathsPanel const &);
 
 private:
-       /// Build the popup
+       /// Build the dialog
        virtual void build();
        /// input handler
        virtual bool input(FL_OBJECT *, long);
@@ -40,7 +40,7 @@ private:
        /// Pointer to the actual instantiation of the xforms form
        virtual FL_FORM * form() const;
 
-       // build the popup
+       // build the form
        FD_form_maths_space * build_maths_space();
        
        // Real GUI implementation
index bf31c4f7c84a867a2b201de25c249f37af1ac8c4..73d9a17645e21636121471d37e4b533e2f445cbf 100644 (file)
@@ -45,15 +45,13 @@ void FormMinipage::build()
        bc().setOK(dialog_->button_ok);
        bc().setApply(dialog_->button_apply);
        bc().setCancel(dialog_->button_cancel);
-       bc().setUndoAll(dialog_->button_restore);
+       bc().setRestore(dialog_->button_restore);
 
        bc().addReadOnly(dialog_->input_width);
        bc().addReadOnly(dialog_->choice_width_units);
        bc().addReadOnly(dialog_->radio_top);
        bc().addReadOnly(dialog_->radio_middle);
        bc().addReadOnly(dialog_->radio_bottom);
-
-       bc().refresh();
 }
 
 
index 02a6f88d497c15c4186b78996f00221db5df4306..7a59f86343e7e3d2aa9946bf3bb6d8556889aaac 100644 (file)
@@ -35,7 +35,7 @@ using SigC::slot;
 FormParagraph::FormParagraph(LyXView * lv, Dialogs * d)
        : FormBaseBD(lv, d, _("Paragraph Layout"))
 {
-    // let the popup be shown
+    // let the dialog be shown
     // This is a permanent connection so we won't bother
     // storing a copy because we won't be disconnecting.
     d->showLayoutParagraph.connect(slot(this, &FormParagraph::show));
@@ -71,8 +71,7 @@ void FormParagraph::build()
     bc_.setOK(dialog_->button_ok);
     bc_.setApply(dialog_->button_apply);
     bc_.setCancel(dialog_->button_cancel);
-    bc_.setUndoAll(dialog_->button_restore);
-    bc_.refresh();
+    bc_.setRestore(dialog_->button_restore);
 
     // the general paragraph data form
     general_.reset(build_paragraph_general());
index 2cd2442ee50dcc44460aeaeb39c8d9091283616c..d72fac11b75286215f85c056eedff46d094cd451 100644 (file)
@@ -28,7 +28,7 @@ struct FD_form_tabbed_paragraph;
 struct FD_form_paragraph_general;
 struct FD_form_paragraph_extra;
 
-/** This class provides an XForms implementation of the FormParagraph Popup.
+/** This class provides an XForms implementation of the FormParagraph dialog.
  *           @author Jürgen Vigna
  */
 class FormParagraph : public FormBaseBD {
@@ -41,11 +41,11 @@ private:
        /** Redraw the form (on receipt of a Signal indicating, for example,
            that the xforms colours have been re-mapped). */
        virtual void redraw();
-       /// Build the popup
+       /// Build the dialog
        virtual void build();
-       /// Apply from popup
+       /// Apply from dialog
        virtual void apply();
-       /// Update the popup.
+       /// Update the dialog
        virtual void update();
        /// Filter the inputs on callback from xforms
        virtual bool input(FL_OBJECT * ob, long);
index 9e37c1df3264942a828b91d21fcee8427945bfee..6e9a13b679ef39456381d1e5e617d18b76cc3f0f 100644 (file)
@@ -36,7 +36,6 @@ void FormPreamble::build()
        bc().setApply(dialog_->button_apply);
        bc().setCancel(dialog_->button_cancel);
        bc().addReadOnly(dialog_->input_preamble);
-       bc().refresh();
 }
 
 
index 27dd6d0ed40b4a042601f6d6947410764e699add..0b124177cfd4b803fe6ba739a28396aa55e2480a 100644 (file)
@@ -25,11 +25,11 @@ public:
        ///
        FormPreamble(ControlPreamble &);
 private:
-       /// Apply from popup
+       /// Apply from dialog 
        virtual void apply();
-       /// Build the popup
+       /// Build the dialog
        virtual void build();
-       /// Update the popup.
+       /// Update the dialog
        virtual void update();
    
        /// Fdesign generated method
index 447a5a7142cc2dc00ad894704a4b818303ec2eeb..80c9375a770229ab38a4ddeb458be9f4833c53dd 100644 (file)
@@ -175,8 +175,7 @@ void FormPreferences::build()
        bc().setOK(dialog_->button_ok);
        bc().setApply(dialog_->button_apply);
        bc().setCancel(dialog_->button_cancel);
-       bc().setUndoAll(dialog_->button_restore);
-       bc().refresh();
+       bc().setRestore(dialog_->button_restore);
 
        // build the tab folders
        converters_tab_.reset(build_outer_tab());
index fd5f7c776e58086751a7d431dbd6472cefd1eb81..5e2c3b9ad08d19c294e41bdee4752695be7fbe7e 100644 (file)
@@ -54,7 +54,6 @@ void FormPrint::build()
        bc().setOK(dialog_->button_ok);
        bc().setApply(dialog_->button_apply);
        bc().setCancel(dialog_->button_cancel);
-       bc().refresh();
 
        // allow controlling of input and ok/apply (de)activation
        fl_set_input_return(dialog_->input_printer,
index 7e245bb14f846906e488106f175a1095213f42d5..5670eca6a4bc277de82760507993765220536e09 100644 (file)
@@ -62,8 +62,7 @@ void FormRef::build()
        bc().setOK(dialog_->button_ok);
        bc().setApply(dialog_->button_apply);
        bc().setCancel(dialog_->button_cancel);
-       bc().setUndoAll(dialog_->button_restore);
-       bc().refresh();
+       bc().setRestore(dialog_->button_restore);
 }
 
 
index ec3387358bb6ef19ccf61d534846fcde02f4324c..34077d94f4e939c2bc8a3268a2ee2841f537d6fc 100644 (file)
@@ -33,7 +33,6 @@ void FormSearch::build()
        bc().addReadOnly(dialog_->input_replace);
        bc().addReadOnly(dialog_->replace);
        bc().addReadOnly(dialog_->replaceall);
-       bc().refresh();
 }
 
 
index 8a0073c3c584467dd8707ab95bfac4781d0e1bfd..5ba8c441f51d64867a5736690cb161def25772b3 100644 (file)
@@ -44,7 +44,6 @@ void FormTabularCreate::build()
        bc().setOK(dialog_->button_ok);
        bc().setApply(dialog_->button_apply);
        bc().setCancel(dialog_->button_cancel);
-       bc().refresh();
 }
 
 
index d818a0707810935803647c02fe912ca5e67317cd..2971305078bf91a8a11482088739722ddedba0f9 100644 (file)
@@ -43,7 +43,6 @@ void FormToc::build()
 
         // Manage the cancel/close button
        bc().setCancel(dialog_->button_cancel);
-       bc().refresh();
 }
 
 
index 62ef744794dc19f544efad39b99efcc7eb4502e1..f8a1f885536d52a3db5d13d6c147623c2c71e587 100644 (file)
@@ -40,8 +40,7 @@ void FormUrl::build()
        bc().setOK(dialog_->button_ok);
        bc().setApply(dialog_->button_apply);
        bc().setCancel(dialog_->button_cancel);
-       bc().setUndoAll(dialog_->button_restore);
-       bc().refresh();
+       bc().setRestore(dialog_->button_restore);
 
        bc().addReadOnly(dialog_->name);
        bc().addReadOnly(dialog_->url);
index ecde4ae6e9f2e0ac9dbcc2e8aea65ab185c4f0ed..e511e10e59cce3400867108b64041bd5411ac540 100644 (file)
@@ -1,6 +1,6 @@
 /* input_validators.C
  * A collection of input filtering and validating functions for use in
- * XForms popups.  Mainly meant for filtering input boxes although may
+ * XForms dialogs.  Mainly meant for filtering input boxes although may
  * be extended to include other generally useful xforms-specific tools.
  */
 
index 5b68c7fad80daf67f430899d3778e9c1ba124d56..d0736a901dd23f46abbc85f10a73a424b50edd14 100644 (file)
@@ -12,7 +12,7 @@
 
 /** Input validators and filters for xforms.
  * A collection of input filtering and validating functions for use in
- * XForms popups.  Mainly meant for filtering input boxes although may
+ * XForms dialogs.  Mainly meant for filtering input boxes although may
  * be extended to include other generally useful xforms-specific tools.
  */