+2003-07-23 Angus Leeming <leeming@lyx.org>
+
+ * factory.C (createInset): changed interface to the external and
+ graphics mailers' string2params functions.
+
2003-07-23 Angus Leeming <leeming@lyx.org>
* factory.C (createInset): pass a
return inset;
} else if (name == "external") {
- Buffer const * buffer = cmd.view()->buffer();
+ Buffer const & buffer = *cmd.view()->buffer();
InsetExternal::Params iep;
InsetExternalMailer::string2params(cmd.argument,
buffer, iep);
return inset;
} else if (name == "graphics") {
- string const fpath = cmd.view()->buffer()->filePath();
+ Buffer const & buffer = *cmd.view()->buffer();
InsetGraphicsParams igp;
- InsetGraphicsMailer::string2params(cmd.argument, fpath,
- igp);
+ InsetGraphicsMailer::string2params(cmd.argument,
+ buffer, igp);
InsetGraphics * inset = new InsetGraphics;
inset->setParams(igp);
return inset;
+2003-07-23 Angus Leeming <leeming@lyx.org>
+
+ * ControlExternal.C: pass a Buffer const & rather than a Buffer const *
+ to the mailer's string2params, params2string functions.
+
+ * ControlGraphics.C pass a Buffer const & rather than a string const &
+ buffer_path to the mailer's string2params, params2string functions.
+
2003-07-23 Angus Leeming <leeming@lyx.org>
* Kernel.[Ch] (bufferFilepath): new wrapper for Buffer::filePath.
bool ControlExternal::initialiseParams(string const & data)
{
params_.reset(new InsetExternal::Params);
- InsetExternalMailer::string2params(data, kernel().buffer(), *params_);
+ InsetExternalMailer::string2params(data, *kernel().buffer(), *params_);
return true;
}
void ControlExternal::dispatchParams()
{
- string const lfun =
- InsetExternalMailer::params2string(params(), kernel().buffer());
+ string const lfun = InsetExternalMailer::params2string(params(),
+ *kernel().buffer());
kernel().dispatch(FuncRequest(LFUN_INSET_APPLY, lfun));
}
dialog().view().apply();
string const lfun =
- InsetExternalMailer::params2string(params(), kernel().buffer());
+ InsetExternalMailer::params2string(params(), *kernel().buffer());
kernel().dispatch(FuncRequest(LFUN_EXTERNAL_EDIT, lfun));
}
bool ControlGraphics::initialiseParams(string const & data)
{
- string const bufpath = kernel().bufferFilepath();
InsetGraphicsParams params;
- InsetGraphicsMailer::string2params(data, bufpath, params);
+ InsetGraphicsMailer::string2params(data, *kernel().buffer(), params);
params_.reset(new InsetGraphicsParams(params));
return true;
}
void ControlGraphics::dispatchParams()
{
- string const buffer_path = kernel().bufferFilepath();
InsetGraphicsParams tmp_params(params());
string const lfun =
- InsetGraphicsMailer::params2string(tmp_params, buffer_path);
+ InsetGraphicsMailer::params2string(tmp_params, *kernel().buffer());
kernel().dispatch(FuncRequest(LFUN_INSET_APPLY, lfun));
}
+2003-07-23 Angus Leeming <leeming@lyx.org>
+
+ * mailinset.[Ch] (inset2string):
+ * insetcommand.[Ch] (inset2string):
+ * insetert.[Ch] (inset2string):
+ * insetexternal.[Ch] (inset2string):
+ * insetfloat.[Ch] (inset2string):
+ * insetgraphics.[Ch] (inset2string):
+ * insetinclude.[Ch] (inset2string):
+ * insetminipage.[Ch] (inset2string):
+ * insetnote.[Ch] (inset2string):
+ * insettabular.[Ch] (inset2string):
+ * insetwrap.[Ch] (inset2string): now requires a Buffer const & arg.
+
+ * insetexternal.[Ch]:
+ * insetgraphics.[Ch]: get rid of the view() function. Associated
+ changes to the mailers' string2params and params2string functions.
+
2003-07-23 Angus Leeming <leeming@lyx.org>
* insetexternal.[Ch]: store the external file name in a FileName
{}
-string const InsetCommandMailer::inset2string() const
+string const InsetCommandMailer::inset2string(Buffer const &) const
{
return params2string(name(), inset_.params());
}
///
virtual string const & name() const { return name_; }
///
- virtual string const inset2string() const;
+ virtual string const inset2string(Buffer const &) const;
///
static void string2params(string const &, InsetCommandParams &);
///
{}
-string const InsetERTMailer::inset2string() const
+string const InsetERTMailer::inset2string(Buffer const &) const
{
return params2string(inset_.status());
}
///
virtual string const & name() const { return name_; }
///
- virtual string const inset2string() const;
+ virtual string const inset2string(Buffer const &) const;
///
static void string2params(string const &, InsetERT::ERTStatus &);
///
case LFUN_EXTERNAL_EDIT: {
Assert(cmd.view());
- Buffer const * buffer = cmd.view()->buffer();
+ Buffer const & buffer = *cmd.view()->buffer();
InsetExternal::Params p;
InsetExternalMailer::string2params(cmd.argument, buffer, p);
- editExternal(p, buffer);
+ editExternal(p, &buffer);
return DISPATCHED_NOUPDATE;
}
case LFUN_INSET_MODIFY: {
Assert(cmd.view());
- Buffer const * buffer = cmd.view()->buffer();
+ Buffer const & buffer = *cmd.view()->buffer();
InsetExternal::Params p;
InsetExternalMailer::string2params(cmd.argument, buffer, p);
setParams(p);
}
-BufferView * InsetExternal::view() const
-{
- return renderer_->view();
-}
-
-
string const InsetExternal::editMessage() const
{
return getScreenLabel(params_);
{}
-string const InsetExternalMailer::inset2string() const
+string const InsetExternalMailer::inset2string(Buffer const & buffer) const
{
- BufferView * bv = inset_.view();
- if (!bv)
- return string();
- return params2string(inset_.params(), bv->buffer());
+ return params2string(inset_.params(), buffer);
}
void InsetExternalMailer::string2params(string const & in,
- Buffer const * buffer,
+ Buffer const & buffer,
InsetExternal::Params & params)
{
params = InsetExternal::Params();
if (lex.isOK()) {
InsetExternal inset;
- inset.read(buffer, lex);
+ inset.read(&buffer, lex);
params = inset.params();
}
}
string const
InsetExternalMailer::params2string(InsetExternal::Params const & params,
- Buffer const * buffer)
+ Buffer const & buffer)
{
InsetExternal inset;
inset.setParams(params);
ostringstream data;
data << name_ << ' ';
- inset.write(buffer, data);
+ inset.write(&buffer, data);
data << "\\end_inset\n";
return STRCONV(data.str());
}
/// Set the inset parameters.
virtual void setParams(Params const &);
- virtual BufferView * view() const;
-
/** update the file represented by the template.
If \param external_in_tmpdir == true, then the generated file is
place in the buffer's temporary directory.
///
virtual string const & name() const { return name_; }
///
- virtual string const inset2string() const;
+ virtual string const inset2string(Buffer const &) const;
///
- static void string2params(string const &, Buffer const *,
+ static void string2params(string const &, Buffer const &,
InsetExternal::Params &);
///
static string const params2string(InsetExternal::Params const &,
- Buffer const *);
+ Buffer const &);
private:
///
static string const name_;
{}
-string const InsetFloatMailer::inset2string() const
+string const InsetFloatMailer::inset2string(Buffer const &) const
{
return params2string(inset_.params());
}
///
virtual string const & name() const { return name_; }
///
- virtual string const inset2string() const;
+ virtual string const inset2string(Buffer const &) const;
///
static void string2params(string const &, InsetFloatParams &);
///
{
switch (cmd.action) {
case LFUN_INSET_MODIFY: {
- string const bufpath = cmd.view()->buffer()->filePath();
+ Buffer const & buffer = *cmd.view()->buffer();
InsetGraphicsParams p;
- InsetGraphicsMailer::string2params(cmd.argument, bufpath, p);
+ InsetGraphicsMailer::string2params(cmd.argument, buffer, p);
if (!p.filename.empty()) {
setParams(p);
cmd.view()->updateInset(this);
}
-BufferView * InsetGraphics::view() const
-{
- return graphic_->view();
-}
-
-
string const InsetGraphicsMailer::name_("graphics");
InsetGraphicsMailer::InsetGraphicsMailer(InsetGraphics & inset)
{}
-string const InsetGraphicsMailer::inset2string() const
+string const InsetGraphicsMailer::inset2string(Buffer const & buffer) const
{
- BufferView * bv = inset_.view();
- if (bv)
- return params2string(inset_.params(), bv->buffer()->filePath());
- return string();
+ return params2string(inset_.params(), buffer);
}
void InsetGraphicsMailer::string2params(string const & in,
- string const & buffer_path,
+ Buffer const & buffer,
InsetGraphicsParams & params)
{
params = InsetGraphicsParams();
if (lex.isOK()) {
InsetGraphics inset;
- inset.readInsetGraphics(lex, buffer_path);
+ inset.readInsetGraphics(lex, buffer.filePath());
params = inset.params();
}
}
string const
InsetGraphicsMailer::params2string(InsetGraphicsParams const & params,
- string const & buffer_path)
+ Buffer const & buffer)
{
ostringstream data;
data << name_ << ' ';
- params.Write(data, buffer_path);
+ params.Write(data, buffer.filePath());
data << "\\end_inset\n";
return STRCONV(data.str());
}
/// Get the inset parameters, used by the GUIndependent dialog.
InsetGraphicsParams const & params() const;
- virtual BufferView * view() const;
private:
///
friend class InsetGraphicsMailer;
///
virtual string const & name() const { return name_; }
///
- virtual string const inset2string() const;
+ virtual string const inset2string(Buffer const &) const;
///
static void string2params(string const & data,
- string const & buffer_path,
+ Buffer const & buffer,
InsetGraphicsParams &);
///
static string const params2string(InsetGraphicsParams const &,
- string const & buffer_path);
+ Buffer const &);
private:
///
static string const name_;
{}
-string const InsetIncludeMailer::inset2string() const
+string const InsetIncludeMailer::inset2string(Buffer const &) const
{
return params2string(inset_.params());
}
///
virtual string const & name() const { return name_; }
///
- virtual string const inset2string() const;
+ virtual string const inset2string(Buffer const &) const;
///
static void string2params(string const &, InsetInclude::Params &);
///
{}
-string const InsetMinipageMailer::inset2string() const
+string const InsetMinipageMailer::inset2string(Buffer const &) const
{
return params2string(inset_.params());
}
///
virtual string const & name() const { return name_; }
///
- virtual string const inset2string() const;
+ virtual string const inset2string(Buffer const &) const;
///
static void string2params(string const &, InsetMinipage::Params &);
///
}
-string const InsetNoteMailer::inset2string() const
+string const InsetNoteMailer::inset2string(Buffer const &) const
{
return params2string(name_, inset_.params());
}
///
virtual string const & name() const { return name_; }
///
- virtual string const inset2string() const;
+ virtual string const inset2string(Buffer const &) const;
///
static string const params2string(string const &, InsetNoteParams const &);
///
{}
-string const InsetTabularMailer::inset2string() const
+string const InsetTabularMailer::inset2string(Buffer const &) const
{
return params2string(inset_);
}
///
virtual string const & name() const { return name_; }
///
- virtual string const inset2string() const;
+ virtual string const inset2string(Buffer const &) const;
/// Returns the active cell if successful, else -1.
static int string2params(string const &, InsetTabular &);
///
{}
-string const InsetWrapMailer::inset2string() const
+string const InsetWrapMailer::inset2string(Buffer const &) const
{
return params2string(inset_.params());
}
///
virtual string const & name() const { return name_; }
///
- virtual string const inset2string() const;
+ virtual string const inset2string(Buffer const &) const;
///
static void string2params(string const &, InsetWrapParams &);
///
void MailInset::showDialog(BufferView * bv) const
{
Assert(bv);
- bv->owner()->getDialogs().show(name(), inset2string(), &inset());
+ bv->owner()->getDialogs().show(name(), inset2string(*bv->buffer()),
+ &inset());
}
{
Assert(bv);
if(bv->owner()->getDialogs().visible(name()))
- bv->owner()->getDialogs().update(name(), inset2string());
+ bv->owner()->getDialogs().update(name(),
+ inset2string(*bv->buffer()));
}
class InsetBase;
+class Buffer;
class BufferView;
///
void hideDialog() const;
///
- virtual string const inset2string() const = 0;
+ virtual string const inset2string(Buffer const &) const = 0;
protected:
///
return theName;
}
///
- virtual string const inset2string() const
+ virtual string const inset2string(Buffer const &) const
{
ostringstream data;
//data << name() << " active_cell " << inset.getActCell() << '\n';