///
UndoElement(UndoKind kin, CursorData const & cb,
StableDocIterator const & cel,
- pit_type fro, pit_type en, ParagraphList * pl,
- MathData * ar, BufferParams const & bp,
- bool ifb, bool lc, size_t gid) :
- kind(kin), cur_before(cb), cell(cel), from(fro), end(en),
- pars(pl), array(ar), bparams(0), isFullBuffer(ifb),
+ pit_type fro, pit_type en, ParagraphList * pl, MathData * ar,
+ bool lc, size_t gid) :
+ kind(kin), cur_before(cb), cell(cel), from(fro), end(en),
+ pars(pl), array(ar), bparams(0),
+ lyx_clean(lc), group_id(gid)
+ {
+ }
+ ///
+ UndoElement(CursorData const & cb, BufferParams const & bp,
+ bool lc, size_t gid) :
+ kind(ATOMIC_UNDO), cur_before(cb), cell(), from(0), end(0),
+ pars(0), array(0), bparams(new BufferParams(bp)),
lyx_clean(lc), group_id(gid)
{
- if (isFullBuffer)
- bparams = new BufferParams(bp);
}
///
UndoElement(UndoElement const & ue)
end = ue.end;
pars = ue.pars;
array = ue.array;
- bparams = ue.isFullBuffer
- ? new BufferParams(*ue.bparams) : ue.bparams;
- isFullBuffer = ue.isFullBuffer;
+ bparams = ue.bparams
+ ? new BufferParams(*ue.bparams) : 0;
lyx_clean = ue.lyx_clean;
group_id = ue.group_id;
}
///
~UndoElement()
{
- if (isFullBuffer)
+ if (bparams)
delete bparams;
}
/// Which kind of operation are we recording for?
MathData * array;
/// Only used in case of full backups
BufferParams const * bparams;
- /// Only used in case of full backups
- bool isFullBuffer;
/// Was the buffer clean at this point?
bool lyx_clean;
/// the element's group id
pit_type first_pit,
pit_type last_pit,
CursorData const & cur,
- bool isFullBuffer,
UndoElementStack & stack);
///
void recordUndo(UndoKind kind,
DocIterator const & cell,
pit_type first_pit,
pit_type last_pit,
- CursorData const & cur,
- bool isFullBuffer);
+ CursorData const & cur);
+ ///
+ void doRecordUndoBufferParams(CursorData const & cur, UndoElementStack & stack);
+ ///
+ void recordUndoBufferParams(CursorData const & cur);
///
Buffer & buffer_;
DocIterator const & cell,
pit_type first_pit, pit_type last_pit,
CursorData const & cur_before,
- bool isFullBuffer,
UndoElementStack & stack)
{
if (!group_level) {
return;
}
- if (isFullBuffer)
- LYXERR(Debug::UNDO, "Create full buffer undo element of group " << group_id);
- else
- LYXERR(Debug::UNDO, "Create undo element of group " << group_id);
+ LYXERR(Debug::UNDO, "Create undo element of group " << group_id);
// create the position information of the Undo entry
UndoElement undo(kind, cur_before, cell, from, end, 0, 0,
- buffer_.params(), isFullBuffer, buffer_.isClean(), group_id);
+ buffer_.isClean(), group_id);
// fill in the real data to be saved
if (cell.inMathed()) {
void Undo::Private::recordUndo(UndoKind kind,
DocIterator const & cell,
pit_type first_pit, pit_type last_pit,
- CursorData const & cur,
- bool isFullBuffer)
+ CursorData const & cur)
{
LASSERT(first_pit <= cell.lastpit(), return);
LASSERT(last_pit <= cell.lastpit(), return);
doRecordUndo(kind, cell, first_pit, last_pit, cur,
- isFullBuffer, undostack_);
+ undostack_);
+
+ // next time we'll try again to combine entries if possible
+ undo_finished_ = false;
+
+ // If we ran recordUndo, it means that we plan to change the buffer
+ buffer_.markDirty();
+
+ redostack_.clear();
+}
+
+
+void Undo::Private::doRecordUndoBufferParams(CursorData const & cur_before,
+ UndoElementStack & stack)
+{
+ if (!group_level) {
+ LYXERR0("There is no group open (creating one)");
+ ++group_id;
+ }
+
+ LYXERR(Debug::UNDO, "Create full buffer undo element of group " << group_id);
+ // create the position information of the Undo entry
+ UndoElement undo(cur_before, buffer_.params(), buffer_.isClean(),
+ group_id);
+
+ // push the undo entry to undo stack
+ stack.push(undo);
+}
+
+
+void Undo::Private::recordUndoBufferParams(CursorData const & cur)
+{
+ doRecordUndoBufferParams(cur, undostack_);
// next time we'll try again to combine entries if possible
undo_finished_ = false;
buffer_.markDirty();
redostack_.clear();
- //lyxerr << "undostack:\n";
- //for (size_t i = 0, n = buf.undostack().size(); i != n && i < 6; ++i)
- // lyxerr << " " << i << ": " << buf.undostack()[i] << endl;
}
// We will store in otherstack the part of the document under 'undo'
DocIterator cell_dit = undo.cell.asDocIterator(&buffer_);
- doRecordUndo(ATOMIC_UNDO, cell_dit,
- undo.from, cell_dit.lastpit() - undo.end, undo.cur_after,
- undo.isFullBuffer, otherstack);
+ if (undo.bparams)
+ doRecordUndoBufferParams(undo.cur_after, otherstack);
+ else
+ doRecordUndo(ATOMIC_UNDO, cell_dit,
+ undo.from, cell_dit.lastpit() - undo.end, undo.cur_after,
+ otherstack);
otherstack.top().cur_after = undo.cur_before;
// This does the actual undo/redo.
//LYXERR0("undo, performing: " << undo);
DocIterator dit = undo.cell.asDocIterator(&buffer_);
- if (undo.isFullBuffer) {
- LBUFERR(undo.pars);
- // This is a full document
+ if (undo.bparams) {
+ // This is a params undo element
delete otherstack.top().bparams;
otherstack.top().bparams = new BufferParams(buffer_.params());
buffer_.params() = *undo.bparams;
- swap(buffer_.paragraphs(), *undo.pars);
- delete undo.pars;
- undo.pars = 0;
} else if (dit.inMathed()) {
// We stored the full cell here as there is not much to be
// gained by storing just 'a few' paragraphs (most if not
void Undo::recordUndo(CursorData const & cur, UndoKind kind)
{
- d->recordUndo(kind, cur, cur.pit(), cur.pit(), cur, false);
+ d->recordUndo(kind, cur, cur.pit(), cur.pit(), cur);
}
if (!inset || inset == &cur.inset()) {
DocIterator c = cur;
c.pop_back();
- d->recordUndo(kind, c, c.pit(), c.pit(), cur, false);
+ d->recordUndo(kind, c, c.pit(), c.pit(), cur);
} else if (inset == cur.nextInset())
recordUndo(cur, kind);
else
void Undo::recordUndo(CursorData const & cur, UndoKind kind, pit_type from)
{
- d->recordUndo(kind, cur, cur.pit(), from, cur, false);
+ d->recordUndo(kind, cur, cur.pit(), from, cur);
}
void Undo::recordUndo(CursorData const & cur, UndoKind kind,
pit_type from, pit_type to)
{
- d->recordUndo(kind, cur, from, to, cur, false);
+ d->recordUndo(kind, cur, from, to, cur);
+}
+
+
+void Undo::recordUndoBufferParams(CursorData const & cur)
+{
+ d->recordUndoBufferParams(cur);
}
-void Undo::recordUndoFullDocument(CursorData const & cur)
+void Undo::recordUndoFullBuffer(CursorData const & cur)
{
// This one may happen outside of the main undo group, so we
// put it in its own subgroup to avoid complaints.
beginUndoGroup();
d->recordUndo(ATOMIC_UNDO, doc_iterator_begin(&d->buffer_),
- 0, d->buffer_.paragraphs().size() - 1, cur, true);
+ 0, d->buffer_.paragraphs().size() - 1, cur);
+ d->recordUndoBufferParams(cur);
endUndoGroup();
}
{
int args_in_def = maxArgumentInDefinition();
if (args_in_def != numargs_) {
- cur.recordUndoFullDocument();
+ // FIXME: implement precise undo handling (only a few places
+ // need undo)
+ cur.recordUndoFullBuffer();
changeArity(cur, inset_pos, args_in_def);
}
insertMissingArguments(args_in_def);
{
if (pos <= numargs_ && pos >= optionals_ && numargs_ < 9) {
++numargs_;
-
+
// append example #n
if (addarg) {
shiftArguments(pos, 1);
case LFUN_MATH_MACRO_ADD_PARAM:
if (numargs_ < 9) {
commitEditChanges(cur, cur);
- cur.recordUndoFullDocument();
+ // FIXME: implement precise undo handling (only a few places
+ // need undo)
+ cur.recordUndoFullBuffer();
size_t pos = numargs_;
if (!arg.empty())
pos = (size_t)convert<int>(arg) - 1; // it is checked for >=0 in getStatus
case LFUN_MATH_MACRO_REMOVE_PARAM:
if (numargs_ > 0) {
commitEditChanges(cur, cur);
- cur.recordUndoFullDocument();
+ // FIXME: implement precise undo handling (only a few places
+ // need undo)
+ cur.recordUndoFullBuffer();
size_t pos = numargs_ - 1;
if (!arg.empty())
pos = (size_t)convert<int>(arg) - 1; // it is checked for >=0 in getStatus
case LFUN_MATH_MACRO_APPEND_GREEDY_PARAM:
if (numargs_ < 9) {
commitEditChanges(cur, cur);
- cur.recordUndoFullDocument();
+ // FIXME: implement precise undo handling (only a few places
+ // need undo)
+ cur.recordUndoFullBuffer();
insertParameter(cur, cur, numargs_, true);
}
break;
case LFUN_MATH_MACRO_REMOVE_GREEDY_PARAM:
if (numargs_ > 0) {
commitEditChanges(cur, cur);
- cur.recordUndoFullDocument();
+ // FIXME: implement precise undo handling (only a few places
+ // need undo)
+ cur.recordUndoFullBuffer();
removeParameter(cur, cur, numargs_ - 1, true);
}
break;
case LFUN_MATH_MACRO_MAKE_OPTIONAL:
commitEditChanges(cur, cur);
- cur.recordUndoFullDocument();
+ // FIXME: implement precise undo handling (only a few places
+ // need undo)
+ cur.recordUndoFullBuffer();
makeOptional(cur, cur);
break;
case LFUN_MATH_MACRO_MAKE_NONOPTIONAL:
commitEditChanges(cur, cur);
- cur.recordUndoFullDocument();
+ // FIXME: implement precise undo handling (only a few places
+ // need undo)
+ cur.recordUndoFullBuffer();
makeNonOptional(cur, cur);
break;
case LFUN_MATH_MACRO_ADD_OPTIONAL_PARAM:
if (numargs_ < 9) {
commitEditChanges(cur, cur);
- cur.recordUndoFullDocument();
+ // FIXME: implement precise undo handling (only a few places
+ // need undo)
+ cur.recordUndoFullBuffer();
insertParameter(cur, cur, optionals_);
makeOptional(cur, cur);
}
case LFUN_MATH_MACRO_REMOVE_OPTIONAL_PARAM:
if (optionals_ > 0) {
commitEditChanges(cur, cur);
- cur.recordUndoFullDocument();
+ // FIXME: implement precise undo handling (only a few places
+ // need undo)
+ cur.recordUndoFullBuffer();
removeParameter(cur, cur, optionals_ - 1);
} break;
case LFUN_MATH_MACRO_ADD_GREEDY_OPTIONAL_PARAM:
if (numargs_ == optionals_) {
commitEditChanges(cur, cur);
- cur.recordUndoFullDocument();
+ // FIXME: implement precise undo handling (only a few places
+ // need undo)
+ cur.recordUndoFullBuffer();
insertParameter(cur, cur, 0, true);
makeOptional(cur, cur);
}
projects / features.git / commitdiff