More llvm/clang warnings

This is mostly unused private class members.

There are also a few unused functions that got #if'ed out. I never know in this case whether the code should be nuked.

diff --git a/src/Text.cpp b/src/Text.cpp
index 347b7a1205e61e10fc1147e7d6f7589f7bbca61f..38e865f039158e142972385bd41428aec59a0b5b 100644 (file)
--- a/src/Text.cpp
+++ b/src/Text.cpp
@@ -582,7 +582,7 @@ class TextCompletionList : public CompletionList
 public:
        ///
        TextCompletionList(Cursor const & cur, WordList const * list)
-               : buffer_(cur.buffer()), pos_(0), list_(list)
+               : buffer_(cur.buffer()), list_(list)
        {}
        ///
        virtual ~TextCompletionList() {}
@@ -604,8 +604,6 @@ private:
        ///
        Buffer const * buffer_;
        ///
-       size_t pos_;
-       ///
        WordList const * list_;
 };
 

diff --git a/src/frontends/qt4/EmptyTable.h b/src/frontends/qt4/EmptyTable.h
index 518ea1c4760cf86dc4dfaae2070fcba8127e6e6e..d9ffa030377c1ef2ec9200987286cf0857884d72 100644 (file)
--- a/src/frontends/qt4/EmptyTable.h
+++ b/src/frontends/qt4/EmptyTable.h
@@ -48,11 +48,6 @@ protected:
        virtual void resetCellSize();
 
 private:
-       /// number of current columns
-       unsigned int cols;
-       /// number of current rows
-       unsigned int rows;
-
 };
 
 

diff --git a/src/frontends/qt4/GuiCharacter.cpp b/src/frontends/qt4/GuiCharacter.cpp
index 53ca720d2f2ac129451d935ffa76fa5d8bd1ff3c..e1fe98491c12343c6649b192753eaf6c55674dae 100644 (file)
--- a/src/frontends/qt4/GuiCharacter.cpp
+++ b/src/frontends/qt4/GuiCharacter.cpp
@@ -160,7 +160,7 @@ void fillCombo(QComboBox * combo, QList<T> const & list)
 
 GuiCharacter::GuiCharacter(GuiView & lv)
        : GuiDialog(lv, "character", qt_("Text Style")), font_(ignore_font, ignore_language),
-         toggleall_(false), reset_lang_(false)
+         toggleall_(false)
 {
        setupUi(this);
 

diff --git a/src/frontends/qt4/GuiCharacter.h b/src/frontends/qt4/GuiCharacter.h
index 599807f0ae8a6b1a386a09593256e3cb453a88dc..5d4f346ee7b58679009a9f4fa3843d66a231c5cf 100644 (file)
--- a/src/frontends/qt4/GuiCharacter.h
+++ b/src/frontends/qt4/GuiCharacter.h
@@ -95,9 +95,6 @@ private:
        Font font_;
        ///
        bool toggleall_;
-       /// If true the language should be reset.
-       /// If false the language of font_ is used.
-       bool reset_lang_;
 };
 
 } // namespace frontend

diff --git a/src/frontends/qt4/GuiPrefs.h b/src/frontends/qt4/GuiPrefs.h
index 02156ab8de789f9b341eb79540db36fe50e8bc3e..2c665853d13ad3c64665a720a45aedda7b6f596c 100644 (file)
--- a/src/frontends/qt4/GuiPrefs.h
+++ b/src/frontends/qt4/GuiPrefs.h
@@ -125,7 +125,6 @@ private:
        /// A list of colors to be dispatched
        std::vector<std::string> colors_;
 
-       bool redraw_gui_;
        bool update_screen_font_;
 };
 

diff --git a/src/frontends/qt4/GuiToolbar.cpp b/src/frontends/qt4/GuiToolbar.cpp
index a6f4505ce0418c5dd4da613150ff89bc5f833ece..f41fd2c76b9a3083b517b5477b242ac7d1875c27 100644 (file)
--- a/src/frontends/qt4/GuiToolbar.cpp
+++ b/src/frontends/qt4/GuiToolbar.cpp
@@ -272,7 +272,7 @@ void GuiToolbar::add(ToolbarItem const & item)
                tb->setToolTip(label);
                tb->setStatusTip(label);
                tb->setText(label);
-               InsertTableWidget * iv = new InsertTableWidget(owner_, tb);
+               InsertTableWidget * iv = new InsertTableWidget(tb);
                connect(tb, SIGNAL(clicked(bool)), iv, SLOT(show(bool)));
                connect(iv, SIGNAL(visible(bool)), tb, SLOT(setChecked(bool)));
                connect(this, SIGNAL(updated()), iv, SLOT(updateParent()));

diff --git a/src/frontends/qt4/InsertTableWidget.cpp b/src/frontends/qt4/InsertTableWidget.cpp
index 32dfe9eb4ed0d635088e64f1014b1dbbed4c6433..889e056abc7ec66b6f1b6871f28c6cf4ba9ac94a 100644 (file)
--- a/src/frontends/qt4/InsertTableWidget.cpp
+++ b/src/frontends/qt4/InsertTableWidget.cpp
@@ -29,8 +29,8 @@
 namespace lyx {
 namespace frontend {
 
-InsertTableWidget::InsertTableWidget(GuiView & lyxView, QWidget * parent)
-       : QWidget(parent, Qt::Popup), colwidth_(20), rowheight_(12), lyxView_(lyxView)
+InsertTableWidget::InsertTableWidget(QWidget * parent)
+       : QWidget(parent, Qt::Popup), colwidth_(20), rowheight_(12)
 {
        init();
        setMouseTracking(true);

diff --git a/src/frontends/qt4/InsertTableWidget.h b/src/frontends/qt4/InsertTableWidget.h
index 36e6dfa9e10b03429d69c8cf43eea7ffccf25866..f38d3dbe9b729c4f7085d99d0c85020c564382b8 100644 (file)
--- a/src/frontends/qt4/InsertTableWidget.h
+++ b/src/frontends/qt4/InsertTableWidget.h
@@ -24,7 +24,7 @@ class InsertTableWidget : public QWidget {
        Q_OBJECT
 public:
 
-       InsertTableWidget(GuiView &, QWidget *);
+       InsertTableWidget(QWidget *);
 
 Q_SIGNALS:
        //! widget is visible
@@ -62,8 +62,6 @@ private:
        int bottom_;
        //! column of pointer
        int right_;
-       //! the lyxview we need to dispatch the funcrequest
-       GuiView & lyxView_;
        //! widget under mouse
        bool underMouse_;
 };

diff --git a/src/insets/InsetText.h b/src/insets/InsetText.h
index e986d3650d947df404b10672606a1386f61914e8..bbdf2abc367644e057f8da06eee8ea04eb25894c 100644 (file)
--- a/src/insets/InsetText.h
+++ b/src/insets/InsetText.h
@@ -225,8 +225,6 @@ private:
        ///
        ColorCode frame_color_;
        ///
-       mutable pit_type old_pit;
-       ///
        mutable Text text_;
 };
 

diff --git a/src/mathed/InsetMath.h b/src/mathed/InsetMath.h
index c1b1b05720f00adf3c287a13bf8d94b453b10c77..5e5f492dc925a260e0989940b142eff92c122628 100644 (file)
--- a/src/mathed/InsetMath.h
+++ b/src/mathed/InsetMath.h
@@ -168,8 +168,6 @@ public:
        /// identifies things that can get \limits or \nolimits
        virtual bool takesLimits() const { return false; }
 
-       /// char char code if possible
-       virtual void handleFont(docstring const &) {}
        /// replace things by other things
        virtual void replace(ReplaceData &) {}
        /// do we contain a given subsequence?

diff --git a/src/mathed/MathAutoCorrect.cpp b/src/mathed/MathAutoCorrect.cpp
index e49959a16d3aacf4c33454a9af25c6f34585d4c6..3e1405b3dc6b97f2647447e1993903aca4e7be7c 100644 (file)
--- a/src/mathed/MathAutoCorrect.cpp
+++ b/src/mathed/MathAutoCorrect.cpp
@@ -94,6 +94,7 @@ bool Correction::correct(MathAtom & at, char_type c) const
 }
 
 
+#if 0
 idocstream & operator>>(idocstream & is, Correction & corr)
 {
        corr.read(is);
@@ -106,7 +107,7 @@ odocstream & operator<<(odocstream & os, Correction & corr)
        corr.write(os);
        return os;
 }
-
+#endif
 
 
 

diff --git a/src/mathed/MathData.cpp b/src/mathed/MathData.cpp
index 9adcbfa932dcfcba5df0f0cfb64048a74376b88f..edd808945721cd071b2209ddd29d2ef264a8d78d 100644 (file)
--- a/src/mathed/MathData.cpp
+++ b/src/mathed/MathData.cpp
@@ -216,6 +216,7 @@ void MathData::touch() const
 }
 
 
+#if 0
 namespace {
 
 bool isInside(DocIterator const & it, MathData const & ar,
@@ -230,7 +231,7 @@ bool isInside(DocIterator const & it, MathData const & ar,
 }
 
 }
-
+#endif
 
 
 void MathData::metrics(MetricsInfo & mi, Dimension & dim) const