]> git.lyx.org Git - features.git/commitdiff
Avoid potential leak of memory pointed to by QStandardItem catItem
authorStephan Witt <switt@lyx.org>
Thu, 13 Feb 2020 14:24:12 +0000 (15:24 +0100)
committerJean-Marc Lasgouttes <lasgouttes@lyx.org>
Thu, 18 Jun 2020 13:48:52 +0000 (15:48 +0200)
src/frontends/qt/GuiDocument.cpp

index ac4b1f1bf19977582364692c03ff3e40c5339daf..8778790fb9879e759188185b101726b91428e4c1 100644 (file)
@@ -4467,12 +4467,13 @@ void GuiDocument::updateAvailableModules()
        unavbrush.setColor(Qt::gray);
        for (modInfoStruct const & m : modInfoList) {
                QStandardItem * item = new QStandardItem();
-               QStandardItem * catItem = new QStandardItem();
+               QStandardItem * catItem;
                QString const catname = m.category;
                QList<QStandardItem *> fcats = modules_av_model_.findItems(catname, Qt::MatchExactly);
                if (!fcats.empty())
                        catItem = fcats.first();
                else {
+                       catItem = new QStandardItem();
                        catItem->setText(catname);
                        catItem->setFont(catfont);
                        modules_av_model_.insertRow(i, catItem);