Remove questionable Mutex copy code

It is no longer needed, and it had a comment that it needed review...
Now anybody who tries to make a copy again is forced to think about it,
instead of trying and using possibly wrong semantics by accident.

diff --git a/src/support/mutex.cpp b/src/support/mutex.cpp
index 042c9b88cd172fe54110b30c782a11752b469601..9f3babda27a5508f07346aa802995bc6facb9687 100644 (file)
--- a/src/support/mutex.cpp
+++ b/src/support/mutex.cpp
@@ -40,22 +40,6 @@ Mutex::~Mutex()
 }
 
 
-// It makes no sense to copy the mutex,
-// each instance has its own QMutex,
-// therefore nothing to copy!
-// TODO review
-Mutex::Mutex(const Mutex&) : d(new Private)
-{
-}
-
-
-Mutex& Mutex::operator=(const Mutex&)
-{
-       return *this;
-}
-
-
-
 Mutex::Locker::Locker(Mutex* mtx) : mutex_(mtx)
 {
        mutex_->d->qmutex_.lock();

diff --git a/src/support/mutex.h b/src/support/mutex.h
index ed3954f03f5a0bce02737a11308ba74fb9192e75..5f34f7de514f3161d27ba3d6682b114e54a07a20 100644 (file)
--- a/src/support/mutex.h
+++ b/src/support/mutex.h
@@ -21,6 +21,9 @@ namespace lyx {
 
 class Mutex
 {
+       /// noncopyable
+       Mutex(const Mutex&);
+       Mutex& operator=(const Mutex&);
 public:
        Mutex();
        ~Mutex();
@@ -45,12 +48,6 @@ public:
                Locker& operator=(const Locker& rhs);
                Mutex* mutex_;
        };
-       
-
-       // pseude-value semantic
-       // needed by GuiPrefs which makes a copy
-       Mutex(const Mutex&);
-       Mutex& operator=(const Mutex&);
 
 private:
        struct Private;