Initialize client's name in main()

Initializing clientName at declaration time is not a good idea.

Spotted by Coverity scan.

diff --git a/src/client/client.cpp b/src/client/client.cpp
index 0a80107009020a7a8e1d6dba4392cc23d4583817..02ea67c00895fa2163a7614aa12a97098fe684d6 100644 (file)
--- a/src/client/client.cpp
+++ b/src/client/client.cpp
@@ -460,8 +460,7 @@ int h(vector<docstring> const &)
 }
 
 
-docstring clientName =
-       from_ascii(to_string(::getppid()) + ">" + to_string(::getpid()));
+docstring clientName;
 
 int n(vector<docstring> const & arg)
 {
@@ -710,9 +709,12 @@ int LyXClientApp::run()
 
 int main(int argc, char * argv[])
 {
-       lyx::lyxerr.setStream(cerr);
+       using namespace lyx;
+       lyxerr.setStream(cerr);
+       cmdline::clientName =
+               from_ascii(to_string(::getppid()) + ">" + to_string(::getpid()));
 
-       lyx::LyXClientApp app(argc, argv);
+       LyXClientApp app(argc, argv);
        return app.exec();
 }